[patch][gdb] Fix crashes in bz24364
Paul Pluzhnikov via gdb-patches
gdb-patches@sourceware.org
Mon Jun 17 20:57:00 GMT 2019
Simon,
On Mon, Jun 17, 2019 at 12:31 PM Simon Marchi <simon.marchi@polymtl.ca> wrote:
>
> On 2019-06-17 13:38, Tom Tromey wrote:
> >>>>>> "Paul" == Paul Pluzhnikov via gdb-patches
> >>>>>> <gdb-patches@sourceware.org> writes:
> >
> > Paul> This is somewhat on the obvious side.
> > Paul> Fix all crashes from bz24364.
> >
> > Paul> gdb/ChangeLog
> >
> > Paul> PR gdb/24364
> > Paul> * gdb/dtrace-probe.c
> > (dtrace_static_probe_ops::get_probe): Don't
> > Paul> call dtrace_process_dof with NULL dof.
> >
> > Thank you for the patch. This is ok.
> >
> > Tom
>
> Could you please just change the commit title to state what is changed
> concretely?
I've already committed this patch, but I'd like to understand your
request for the future.
What changed concretely is that we don't call dtrace_process_dof()
with NULL dof anymore. I am not sure how to express this clearer.
> Also, put in the commit message at least a small example of
> how to trigger the bug.
To trigger the bug, run gdb on any of the examples attached to bugzilla 24364.
They are all artificial (generated by fuzzing).
Cheers,
--
Paul Pluzhnikov
More information about the Gdb-patches
mailing list