[PATCH] Fix new-ui tty stream leak

Simon Marchi simark@simark.ca
Thu Jul 18 20:09:00 GMT 2019


On 2019-07-18 2:41 p.m., Pedro Alves wrote:
> I noticed that we never close the stream opened by new-ui.
> 
> This fixes it, by adding a new struct ui ctor that takes ownership of
> the passed-in stream.

Hi Pedro,

If I am not mistaken, we never delete the UIs themselves either, so it won't
make a difference today, is that right?  They just live until the end of the
GDB process.

Still, I think this patch is fine, in that it makes things right in case we
decide to make it possible to close an existing UI some day.

Simon



More information about the Gdb-patches mailing list