[PATCH 0/3] Normalize common includes
Tom Tromey
tom@tromey.com
Fri Jan 25 21:32:00 GMT 2019
>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
John> On 1/24/19 8:17 PM, Joel Brobecker wrote:
>>> I think the norm in gdb is to include files from common using
>>> "common/filename.h" -- but this is not enforced, because the Makefiles
>>> provide -I$(srcdir)/common.
>>>
>>> This series rewrites gdb to use the norm everywhere, and then removes
>>> the -I options. The bulk of the change was done by script.
>>>
>>> Let me know what you think. It would be better for this to go in (if
>>> it goes in) before the include sorting patch.
>>
>> I think it's a good idea indeed. It's immediately clearer to me when
>> I see #include "common/something.h". The downside is having to update
>> all the includes when we move one file, but I think this one-off
>> is worth the extra clarity.
John> I think it is a good idea as well. It probably makes the codebase a bit
John> more accessible to newcomers to have the explicit paths.
Thanks for the feedback. I will check it in a bit later.
Tom
More information about the Gdb-patches
mailing list