[PATCH v2] AArch64 AAPCS: Ignore static members

Pedro Alves palves@redhat.com
Wed Jan 23 16:52:00 GMT 2019


This is OK with the tiny nit below fixed.

On 01/22/2019 10:50 AM, Alan Hayward wrote:

> diff --git a/gdb/testsuite/gdb.base/infcall-nested-structs.c b/gdb/testsuite/gdb.base/infcall-nested-structs.c
> index 5c25956c50..56257e8798 100644
> --- a/gdb/testsuite/gdb.base/infcall-nested-structs.c
> +++ b/gdb/testsuite/gdb.base/infcall-nested-structs.c
> @@ -21,6 +21,10 @@
>     scalar fields, the fields can be inside nested structures, and there can
>     be empty structures around too.
>  
> +   When compiled for C++ this file also tests structures containing static
> +   members (which live in global memory).  In addition, empty structures in C++
> +   have a size of 1 (compared to 0 in C), which can effect structure padding.

Say "in GNU C" instead of "in C".  Empty structures in C is a GNU extension:
 https://gcc.gnu.org/onlinedocs/gcc/Empty-Structures.html

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list