[PATCH] Remove duplicate or commented-out #includes
Gary Benson
gbenson@redhat.com
Mon Jan 21 17:28:00 GMT 2019
Tom Tromey wrote:
> I wrote a little script to detect duplicate or commented-out
> #includes and ran it on gdb. This patch is the result. Tested
> by rebuilding.
Looks good to me :) I did something similar a few years back,
though possibly only for system headers, or for just the ones
in common-defs.h. So obviously I approve!
> It would be possible to sort #includes, or maybe run
> include-what-you-use on gdb, but I haven't tried that. I'd be
> interested to hear if you think this would be worthwhile, thoug.
I'd consider it worthwhile. I'd really like sorted #includes.
Some files have random whitespace in the list too, that maybe
made sense once.
Cheers,
Gary
More information about the Gdb-patches
mailing list