[RFA 3/3] Make symtab.c better styled.
Tom Tromey
tom@tromey.com
Sat Jan 12 22:58:00 GMT 2019
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
Philippe> To differentiate between data and text, would the condition
Philippe> in expand_symtab_containing_pc be ok ?
Philippe> i.e. variable styling would be used for data, i.e. :
Philippe> (MSYMBOL_TYPE (msymbol.minsym) == mst_data
Philippe> || MSYMBOL_TYPE (msymbol.minsym) == mst_bss
Philippe> || MSYMBOL_TYPE (msymbol.minsym) == mst_abs
Philippe> || MSYMBOL_TYPE (msymbol.minsym) == mst_file_data
Philippe> || MSYMBOL_TYPE (msymbol.minsym) == mst_file_bss))
Philippe> and function name styling would be used for the rest i.e.:
Philippe> mst_text, /* Generally executable instructions */
Philippe> mst_text_gnu_ifunc, /* Executable code returning address
Philippe> of executable code */
Philippe> mst_data_gnu_ifunc, /* Executable code returning address
Philippe> of executable code */
Philippe> mst_slot_got_plt, /* GOT entries for .plt sections */
Philippe> mst_solib_trampoline, /* Shared library trampoline code */
Philippe> mst_file_text, /* Static version of mst_text */
Yes, I think that's reasonable.
Tom
More information about the Gdb-patches
mailing list