[PATCH] Remove cleanup from remote.c

[Simon Marchi]

On 2019-01-06 15:12, Tom Tromey wrote:
> This removes the remaining cleanup from remote.c, by changing
> remote_state::buf to be a gdb::char_vector, and then fixing up all the
> fallout.  The resulting patch is somewhat ugly, but on the other hand,
> it eliminates some possibilities for mistakes.
> 
> Regression tested using the
> Fedora-x86_64-native-extended-gdbserver-m64 builder on the buildbot.

All of this for a single cleanup :).  This is fine with me.  I think we 
could later get rid of a few ->data() by having some functions take a 
gdb::char_vector or gdb::array_view instead of a char*.

Simon