Feedback sought: patch to enable gdb to build on macOS Mojave

[John Baldwin]

On 2/19/19 10:50 PM, Joubert Nel wrote:
> Great. 
> 
> I read the contribution checklist and I think those are all great guidelines. 
> 
> Before I prepare a formal submission email, it would be helpful to hear whether the actual code differences seem acceptable: https://gist.github.com/joubertnel/267ca0fff4eaad494cc19ec3ba7953ed

Especially for a patch that small it is easier to review it inline.

I think the first hunk is fine.

The second one probably isn't the right fix.  The earlier 'res' is an
'int' for the return value from darwin_decode_notify_message.  The
later one is a pid_t for the return value from wait4.  I would perhaps
rename the second 'res' to 'wpid' instead of using the int.

For the third one it looks like you can just remove the line entirely.
priv is already set to 'get_darwin_inferior (inf)' at the start of the
function, so that assignment is redundant.

-- 
John Baldwin

                                                                           Â