[PATCH 2/4] Define gdb.Value(bufobj, type) constructor

Tom Tromey tom@tromey.com
Mon Feb 18 22:46:00 GMT 2019


>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:

FWIW I think this whole series looks quite reasonable and would be a
good addition.

Kevin> +  Py_buffer py_buf;

Elsewhere in the Python code, Py_buffer is only used conditionally on
"#ifdef IS_PY3K".  I don't know exactly why, though.  Py_buffer seems to
be in Python 2.7, maybe it wasn't in some earlier version that gdb still
supports?

I don't know whether anyone still relies on older versions of Python
(2.7 was released in 2010 so it seems plenty old at this point; after
all we require compilers released after this).

However, this seems like a decision to make consciously.
I'm not completely sure how to proceed, though one idea might be to find
the most recent Python 2.[456] compatibility patch and then asking the
author whether this support is still relevant.

thanks,
Tom



More information about the Gdb-patches mailing list