[RFA/commit] (Windows) remove thread notification for main thread of inferior

[Joel Brobecker]

> Your rationale makes sense, I am fine with your original code too since you
> gave a good justification.  However you prefer.
> 
> I agree about the fact that literal values in function calls are often not
> that readable, and not only true/false.

I went with what you suggested. Both are equally good, I think.

> > gdb/ChangeLog
> > 
> >         * windows-nat.c (windows_add_thread): Add new parameter
> >         "main_thread_p" with default value set to false.  Update
> >         function documentation as well as all callers.
> >         (windows_delete_thread): Likewise.
> >         (fake_create_process): Update call to windows_add_thread.
> >         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
> >         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
> >         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
> >         call to windows_delete_thread.
> > 
> > Tested on x86-windows (MinGW) using AdaCore's testsuite.
> > OK to push?
> > 
> > Thanks!
> 
> There is still a mention of "deleted" in the windows_add_thread doc,
> otherwise LGTM.

Argh! Talk about tunnel vision :-(. Fixed thusly, and pushed.

Thanks Simon.
-- 
Joel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Windows-remove-thread-notification-for-main-thread-o.patch
Type: text/x-diff
Size: 7618 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20190214/a5d3391a/attachment.bin>