[PATCH v5] gdb: CTF support update
Tom Tromey
tom@tromey.com
Thu Dec 19 20:27:00 GMT 2019
>>>>> Weimin Pan <weimin.pan@oracle.com> writes:
> This patch addresses Tom Tromey's comments on the CTF reader:
> * Use the type-safe registry for ctf_file_key;
> * Drop "typedef" when defining "struct ctf_context";
> * Use ANOFFSET with SECT_OFF_TEXT to get the text base address;
Thanks for the patch.
> +struct ctf_fp_info
> + {
This brace should be in the leftmost column.
> + ctf_fp_info (ctf_file_t *cfp) : fp (cfp) {}
Single-argument constructors should be marked "explicit".
This patch is ok with these fixes. Thanks.
Tom
More information about the Gdb-patches
mailing list