[review] Remove "fix" call for "long long" from ARI
Tom Tromey (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Fri Dec 13 19:27:00 GMT 2019
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/755
......................................................................
Patch Set 1:
(1 comment)
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,17 @@
| +Parent: 13e991b1 (Accept -Wno- prefix in ARI)
| +Author: Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-12-12 09:10:49 -0700
| +Commit: Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-12-12 10:31:38 -0700
| +
| +Remove "fix" call for "long long" from ARI
| +
| +ARI has a "fix" call for "long long", but this call is incorrect.
| +This patch removes it.
PS1, Line 10:
> More like the definitions of ULONGEST/LONGEST moved from defs.h to gdbsupport/common-types.h. I don't see markers there, don't we need them?
Yeah, probably so. There are a few ways of running ARI, and
the one I'm mostly using doesn't note these. If you do enable
more warnings, you'll see a lot -- my "-Wari" run shows 637
(but some of these are warnings about deprecated or legacy
things, which I think aren't very interesting).
| +
| +gdb/ChangeLog
| +2019-12-12 Tom Tromey <tromey@adacore.com>
| +
| + * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
| +
| +Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
Gerrit-Change-Number: 755
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 19:27:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list