[review] Silence ARI for valid calls to abort

Tom Tromey (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Thu Dec 12 17:21:00 GMT 2019


Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/744
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+2
> 
> Ahaha, yeah, I forgot to point at that "only 3 calls" comment in the threads series.  :-)

I see now there's a fix() call about this in gdb_ari.sh.
In general I think these fix() calls should be removed in favor
of annotations at the point of call.  I'll comment on that in another
patch as well.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I09ce6aa5010bbe4e5bb73ffdb727481be39d34d6
Gerrit-Change-Number: 744
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 12 Dec 2019 17:21:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment



More information about the Gdb-patches mailing list