New ARI warning Thu Dec 12 02:12:59 UTC 2019 in gdb-9-branch

GDB Administrator gdbadmin@sourceware.org
Thu Dec 12 02:13:00 GMT 2019


1d0
< gdb/ada-lang.c:1140: code: editCase function: Function name starts lower case but has uppercased letters.
gdb/ada-lang.c:1140:ada_remove_Xbn_suffix (const char *encoded, int *len)
52a52,60
> gdb/cli/cli-option.c:36: regression: boolean: Do not use 'boolean',  use 'bool' instead
gdb/cli/cli-option.c:36:  bool boolean;
> gdb/cli/cli-option.c:262: regression: boolean: Do not use 'boolean',  use 'bool' instead
gdb/cli/cli-option.c:262:	    val.boolean = true;
> gdb/cli/cli-option.c:355: regression: boolean: Do not use 'boolean',  use 'bool' instead
gdb/cli/cli-option.c:355:	val.boolean = res;
> gdb/cli/cli-option.c:588: regression: boolean: Do not use 'boolean',  use 'bool' instead
gdb/cli/cli-option.c:588:	bool value = ov->value.has_value () ? ov->value->boolean : true;
> gdb/cli/cli-option.c:589: regression: boolean: Do not use 'boolean',  use 'bool' instead
gdb/cli/cli-option.c:589:	*ov->option.var_address.boolean (ov->option, ov->ctx) = value;
> gdb/cli/cli-option.c:783: regression: boolean: Do not use 'boolean',  use 'bool' instead
gdb/cli/cli-option.c:783:				   option.var_address.boolean (option, data),
> gdb/cli/cli-option.h:85: regression: boolean: Do not use 'boolean',  use 'bool' instead
gdb/cli/cli-option.h:85:      bool *(*boolean) (const option_def &, void *ctx);
> gdb/cli/cli-option.h:163: regression: var_boolean: Replace var_boolean with add_setshow_boolean_cmd
gdb/cli/cli-option.h:163:    : option_def (long_option_, var_boolean,
> gdb/cli/cli-option.h:168: regression: boolean: Do not use 'boolean',  use 'bool' instead
gdb/cli/cli-option.h:168:    var_address.boolean = detail::get_var_address<bool, Context>;
66,98d73
< gdb/common/agent.c:154: regression: strerror: Do not use strerror(), instead use safe_strerror()
gdb/common/agent.c:154:      warning (_('), strerror (errno));
< gdb/common/agent.c:173: regression: strerror: Do not use strerror(), instead use safe_strerror()
gdb/common/agent.c:173:		 path, strerror (errno));
< gdb/common/array-view.h:252: code: function call in first column: Function name in first column should be restricted to function implementation
gdb/common/array-view.h:252:make_array_view (U *array, size_t size) noexcept
< gdb/common/buffer.c:100: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:100:	      sprintf (str, ', va_arg (ap, int));
< gdb/common/buffer.c:103: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:103:	      sprintf (str, ', va_arg (ap, unsigned int));
< gdb/common/buffer.c:106: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:106:	      sprintf (str, ', va_arg (ap, unsigned int));
< gdb/common/buffer.c:109: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:109:	      sprintf (str, ', va_arg (ap, unsigned int));
< gdb/common/buffer.c:116: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:116:		  sprintf (str, ', va_arg (ap, long));
< gdb/common/buffer.c:119: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:119:		  sprintf (str, ', va_arg (ap, unsigned long));
< gdb/common/buffer.c:122: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:122:		  sprintf (str, ', va_arg (ap, unsigned long));
< gdb/common/buffer.c:125: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:125:		  sprintf (str, ', va_arg (ap, unsigned long));
< gdb/common/buffer.c:132: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:132:		      sprintf (str, ' PRId64,
< gdb/common/buffer.c:133: code: long long: Do not use 'long long', instead use LONGEST
gdb/common/buffer.c:133:			       (int64_t) va_arg (ap, long long));
< gdb/common/buffer.c:136: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:136:		      sprintf (str, ' PRIu64,
< gdb/common/buffer.c:137: code: long long: Do not use 'long long', instead use LONGEST
gdb/common/buffer.c:137:			       (uint64_t) va_arg (ap, unsigned long long));
< gdb/common/buffer.c:140: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:140:		      sprintf (str, ' PRIx64,
< gdb/common/buffer.c:141: code: long long: Do not use 'long long', instead use LONGEST
gdb/common/buffer.c:141:			       (uint64_t) va_arg (ap, unsigned long long));
< gdb/common/buffer.c:144: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/common/buffer.c:144:		      sprintf (str, ' PRIo64,
< gdb/common/buffer.c:145: code: long long: Do not use 'long long', instead use LONGEST
gdb/common/buffer.c:145:			       (uint64_t) va_arg (ap, unsigned long long));
< gdb/common/common-types.h:28: code: long long: Do not use 'long long', instead use LONGEST
gdb/common/common-types.h:28:typedef unsigned long long CORE_ADDR;
< gdb/common/common-types.h:30: code: long long: Do not use 'long long', instead use LONGEST
gdb/common/common-types.h:30:typedef long long LONGEST;
< gdb/common/common-types.h:31: code: long long: Do not use 'long long', instead use LONGEST
gdb/common/common-types.h:31:typedef unsigned long long ULONGEST;
< gdb/common/common-types.h:52: code: long long: Do not use 'long long', instead use LONGEST
gdb/common/common-types.h:52:typedef long long LONGEST;
< gdb/common/common-types.h:53: code: long long: Do not use 'long long', instead use LONGEST
gdb/common/common-types.h:53:typedef unsigned long long ULONGEST;
< gdb/common/common-utils.c:164: regression: vsprintf: Do not use vsprintf(), instead use xstrvprintf
gdb/common/common-utils.c:164:  vsprintf (&str[0], fmt, vp);
< gdb/common/common-utils.c:186: regression: vsprintf: Do not use vsprintf(), instead use xstrvprintf
gdb/common/common-utils.c:186:  vsprintf (&str[0], fmt, args);
< gdb/common/common-utils.c:222: regression: vsprintf: Do not use vsprintf(), instead use xstrvprintf
gdb/common/common-utils.c:222:  vsprintf (&str[curr_size], fmt, args);
< gdb/common/common-utils.h:42: regression: __func__: Do not use __func__, ISO C 90 does not support this macro
gdb/common/common-utils.h:42:#define FUNCTION_NAME		__func__   
< gdb/common/gdb_optional.h:173: code: OP eol: Do not use &&, or || at the end of a line
gdb/common/gdb_optional.h:173:  T &&operator* () &&
< gdb/common/gdb_optional.h:176: code: OP eol: Do not use &&, or || at the end of a line
gdb/common/gdb_optional.h:176:  constexpr const T &&operator* () const &&
< gdb/common/mingw-strerror.c:38: regression: strerror: Do not use strerror(), instead use safe_strerror()
gdb/common/mingw-strerror.c:38:    return strerror (errnum);
< gdb/common/posix-strerror.c:29: regression: strerror: Do not use strerror(), instead use safe_strerror()
gdb/common/posix-strerror.c:29:  msg = strerror (errnum);
< gdb/common/underlying.h:27: code: function call in first column: Function name in first column should be restricted to function implementation
gdb/common/underlying.h:27:to_underlying (E val) noexcept
120a96,97
> gdb/ctfread.c:1071: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/ctfread.c:1071:  if ((tid = ctf_lookup_by_symbol (ccp->fp, idx)) == CTF_ERR)
> gdb/ctfread.c:1418: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/ctfread.c:1418:      if ((tid = ctf_lookup_by_symbol (cfp, idx)) == CTF_ERR)
135d111
< gdb/defs.h:614: deprecated: deprecated interactive_hook: Do not use deprecated interactive_hook, see declaration for details
gdb/defs.h:614:extern void (*deprecated_interactive_hook) (void);
151,153d126
< gdb/disasm.c:359: deprecated: deprecated dis_line_entry: Do not use deprecated dis_line_entry, see declaration for details
gdb/disasm.c:359:    alloca (nlines * sizeof (struct deprecated_dis_line_entry));
< gdb/disasm.c:403: deprecated: deprecated dis_line_entry: Do not use deprecated dis_line_entry, see declaration for details
gdb/disasm.c:403:    qsort (mle, newlines, sizeof (struct deprecated_dis_line_entry),
< gdb/dwarf-index-cache.c:118: gettext: trailing new line: A message should not have a trailing new line
gdb/dwarf-index-cache.c:118:	  warning (_("index cache: could not make cache directory: %s\n"),
165a139,140
> gdb/dwarf2read.c:17388: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/dwarf2read.c:17388:  else if ((attr = dwarf2_attr (die, DW_AT_byte_size, cu)) != nullptr)
> gdb/dwarf2read.c:23143: code: function call in first column: Function name in first column should be restricted to function implementation
gdb/dwarf2read.c:23143:dwarf_unit_type_name (int unit_type) {
169a145
> gdb/event-top.c:884: regression: abort: Do not use abort, instead use internal_error; GDB should never abort
gdb/event-top.c:884:    abort ();
214a191,219
> gdb/gdbsupport/array-view.h:252: code: function call in first column: Function name in first column should be restricted to function implementation
gdb/gdbsupport/array-view.h:252:make_array_view (U *array, size_t size) noexcept
> gdb/gdbsupport/buffer.c:100: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:100:	      sprintf (str, ', va_arg (ap, int));
> gdb/gdbsupport/buffer.c:103: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:103:	      sprintf (str, ', va_arg (ap, unsigned int));
> gdb/gdbsupport/buffer.c:106: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:106:	      sprintf (str, ', va_arg (ap, unsigned int));
> gdb/gdbsupport/buffer.c:109: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:109:	      sprintf (str, ', va_arg (ap, unsigned int));
> gdb/gdbsupport/buffer.c:116: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:116:		  sprintf (str, ', va_arg (ap, long));
> gdb/gdbsupport/buffer.c:119: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:119:		  sprintf (str, ', va_arg (ap, unsigned long));
> gdb/gdbsupport/buffer.c:122: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:122:		  sprintf (str, ', va_arg (ap, unsigned long));
> gdb/gdbsupport/buffer.c:125: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:125:		  sprintf (str, ', va_arg (ap, unsigned long));
> gdb/gdbsupport/buffer.c:132: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:132:		      sprintf (str, ' PRId64,
> gdb/gdbsupport/buffer.c:133: code: long long: Do not use 'long long', instead use LONGEST
gdb/gdbsupport/buffer.c:133:			       (int64_t) va_arg (ap, long long));
> gdb/gdbsupport/buffer.c:136: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:136:		      sprintf (str, ' PRIu64,
> gdb/gdbsupport/buffer.c:137: code: long long: Do not use 'long long', instead use LONGEST
gdb/gdbsupport/buffer.c:137:			       (uint64_t) va_arg (ap, unsigned long long));
> gdb/gdbsupport/buffer.c:140: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:140:		      sprintf (str, ' PRIx64,
> gdb/gdbsupport/buffer.c:141: code: long long: Do not use 'long long', instead use LONGEST
gdb/gdbsupport/buffer.c:141:			       (uint64_t) va_arg (ap, unsigned long long));
> gdb/gdbsupport/buffer.c:144: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/gdbsupport/buffer.c:144:		      sprintf (str, ' PRIo64,
> gdb/gdbsupport/buffer.c:145: code: long long: Do not use 'long long', instead use LONGEST
gdb/gdbsupport/buffer.c:145:			       (uint64_t) va_arg (ap, unsigned long long));
> gdb/gdbsupport/common-exceptions.h:117: gettext: _ markup: All messages should be marked up with _.
gdb/gdbsupport/common-exceptions.h:117:      error (GDB_NO_ERROR)
> gdb/gdbsupport/common-types.h:28: code: long long: Do not use 'long long', instead use LONGEST
gdb/gdbsupport/common-types.h:28:typedef unsigned long long CORE_ADDR;
> gdb/gdbsupport/common-types.h:30: code: long long: Do not use 'long long', instead use LONGEST
gdb/gdbsupport/common-types.h:30:typedef long long LONGEST;
> gdb/gdbsupport/common-types.h:31: code: long long: Do not use 'long long', instead use LONGEST
gdb/gdbsupport/common-types.h:31:typedef unsigned long long ULONGEST;
> gdb/gdbsupport/common-types.h:52: code: long long: Do not use 'long long', instead use LONGEST
gdb/gdbsupport/common-types.h:52:typedef long long LONGEST;
> gdb/gdbsupport/common-types.h:53: code: long long: Do not use 'long long', instead use LONGEST
gdb/gdbsupport/common-types.h:53:typedef unsigned long long ULONGEST;
> gdb/gdbsupport/common-utils.c:92: regression: vsprintf: Do not use vsprintf(), instead use xstrvprintf
gdb/gdbsupport/common-utils.c:92:  vsprintf (&str[0], fmt, vp);
> gdb/gdbsupport/common-utils.c:114: regression: vsprintf: Do not use vsprintf(), instead use xstrvprintf
gdb/gdbsupport/common-utils.c:114:  vsprintf (&str[0], fmt, args);
> gdb/gdbsupport/common-utils.c:150: regression: vsprintf: Do not use vsprintf(), instead use xstrvprintf
gdb/gdbsupport/common-utils.c:150:  vsprintf (&str[curr_size], fmt, args);
> gdb/gdbsupport/gdb_optional.h:173: code: OP eol: Do not use &&, or || at the end of a line
gdb/gdbsupport/gdb_optional.h:173:  T &&operator* () &&
> gdb/gdbsupport/gdb_optional.h:176: code: OP eol: Do not use &&, or || at the end of a line
gdb/gdbsupport/gdb_optional.h:176:  constexpr const T &&operator* () const &&
> gdb/gdbsupport/underlying.h:27: code: function call in first column: Function name in first column should be restricted to function implementation
gdb/gdbsupport/underlying.h:27:to_underlying (E val) noexcept
223d227
< gdb/guile/guile-internal.h:154: regression: __func__: Do not use __func__, ISO C 90 does not support this macro
gdb/guile/guile-internal.h:154:#define FUNC_NAME __func__
286d289
< gdb/interps.c:355: deprecated: deprecated interactive_hook: Do not use deprecated interactive_hook, see declaration for details
gdb/interps.c:355:  deprecated_interactive_hook = 0;
295d297
< gdb/linux-fork.c:164: code: OP eol: Do not use &&, or || at the end of a line
gdb/linux-fork.c:164:  if (fork_list != NULL && fork_list->next == NULL &&
296a299
> gdb/linux-fork.c:632: regression: ATTRIBUTE_UNUSED: Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, consequently, is not able to tolerate false warnings.  Since -Wunused-param produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED are used by GDB
gdb/linux-fork.c:632:  for (thread_info *tp ATTRIBUTE_UNUSED : current_inferior ()->threads ())
298d300
< gdb/linux-nat.c:1432: regression: strerror: Do not use strerror(), instead use safe_strerror()
gdb/linux-nat.c:1432:		       lwpid, strerror (errno));
324c326
< gdb/minsyms.c:540: code: OP eol: Do not use &&, or || at the end of a line
gdb/minsyms.c:540:	      if (strcmp (MSYMBOL_LINKAGE_NAME (msymbol), name) == 0 &&
> gdb/mi/mi-symbol-cmds.c:178: code: long long: Do not use 'long long', instead use LONGEST
gdb/mi/mi-symbol-cmds.c:178:  long long val = strtoll (arg, &ptr, 10);
402a405
> gdb/printcmd.c:1223: code: OP eol: Do not use &&, or || at the end of a line
gdb/printcmd.c:1223:  if (voidprint || (val && value_type (val) &&
407c410
< gdb/python/py-unwind.c:457: regression: __FUNCTION__: Do not use __FUNCTION__, ISO C 90 does not support this macro
gdb/python/py-unwind.c:457:      fprintf_unfiltered (gdb_stdlog, ', __FUNCTION__);
> gdb/python/py-unwind.c:453: regression: __FUNCTION__: Do not use __FUNCTION__, C++11 does not support this macro
gdb/python/py-unwind.c:453:      fprintf_unfiltered (gdb_stdlog, ', __FUNCTION__);
409,411c412,414
< gdb/python/py-unwind.c:473: regression: __FUNCTION__: Do not use __FUNCTION__, ISO C 90 does not support this macro
gdb/python/py-unwind.c:473:  TRACE_PY_UNWIND (1, "%s (frame=%p,...,reg=%d)\n", __FUNCTION__, this_frame,
gdb/python/py-unwind.c:473:  TRACE_PY_UNWIND (1, ', __FUNCTION__, this_frame,
< gdb/python/py-unwind.c:495: regression: __FUNCTION__: Do not use __FUNCTION__, ISO C 90 does not support this macro
gdb/python/py-unwind.c:495:  TRACE_PY_UNWIND (3, ', __FUNCTION__,
< gdb/python/py-unwind.c:589: regression: __FUNCTION__: Do not use __FUNCTION__, ISO C 90 does not support this macro
gdb/python/py-unwind.c:589:  TRACE_PY_UNWIND (3, ', __FUNCTION__);
> gdb/python/py-unwind.c:469: regression: __FUNCTION__: Do not use __FUNCTION__, C++11 does not support this macro
gdb/python/py-unwind.c:469:  TRACE_PY_UNWIND (1, "%s (frame=%p,...,reg=%d)\n", __FUNCTION__, this_frame,
gdb/python/py-unwind.c:469:  TRACE_PY_UNWIND (1, ', __FUNCTION__, this_frame,
> gdb/python/py-unwind.c:491: regression: __FUNCTION__: Do not use __FUNCTION__, C++11 does not support this macro
gdb/python/py-unwind.c:491:  TRACE_PY_UNWIND (3, ', __FUNCTION__,
> gdb/python/py-unwind.c:585: regression: __FUNCTION__: Do not use __FUNCTION__, C++11 does not support this macro
gdb/python/py-unwind.c:585:  TRACE_PY_UNWIND (3, ', __FUNCTION__);
471,473c474
< gdb/s12z-tdep.c:92: gettext: trailing new line: A message should not have a trailing new line
gdb/s12z-tdep.c:92:  warning (_("%s Failed to find end of prologue PC = %08x\n"),
< gdb/s12z-tdep.c:93: regression: __FUNCTION__: Do not use __FUNCTION__, ISO C 90 does not support this macro
gdb/s12z-tdep.c:93:                      __FUNCTION__, (unsigned int) pc);
< gdb/s12z-tdep.c:214: gettext: trailing new line: A message should not have a trailing new line
gdb/s12z-tdep.c:214:      warning (_("Couldn't find function including address %s SP is %s\n"),
> gdb/s12z-tdep.c:94: regression: __FUNCTION__: Do not use __FUNCTION__, C++11 does not support this macro
gdb/s12z-tdep.c:94:	   __FUNCTION__, (unsigned int) pc);
488,491d488
< gdb/solib-spu.c:200: code: long long: Do not use 'long long', instead use LONGEST
gdb/solib-spu.c:200:      unsigned long long addr;
< gdb/solib-spu.c:252: code: long long: Do not use 'long long', instead use LONGEST
gdb/solib-spu.c:252:      unsigned long long addr;
< gdb/solib-spu.c:348: code: long long: Do not use 'long long', instead use LONGEST
gdb/solib-spu.c:348:  unsigned long long addr;
< gdb/spu-tdep.c:2680: deprecate: read_pc: Replace READ_PC() with frame_pc_unwind; at present the inferior function call code still uses this
gdb/spu-tdep.c:2680:  set_gdbarch_read_pc (gdbarch, spu_read_pc);
gdb/spu-tdep.c:2680:  set_gdbarch_read_pc (gdbarch, spu_read_pc);
537d533
< gdb/top.c:228: deprecated: deprecated interactive_hook: Do not use deprecated interactive_hook, see declaration for details
gdb/top.c:228:void (*deprecated_interactive_hook) (void);
562,573d557
< gdb/tui/tui-hooks.c:278: deprecated: deprecated query_hook: Do not use deprecated query_hook, see declaration for details
gdb/tui/tui-hooks.c:278:  deprecated_query_hook = 0;
< gdb/tui/tui-regs.c:77: code: OP eol: Do not use &&, or || at the end of a line
gdb/tui/tui-regs.c:77:      num_lines = (TUI_DATA_WIN->detail.data_display_info.regs_content_count /
< gdb/tui/tui-regs.c:122: code: OP eol: Do not use &&, or || at the end of a line
gdb/tui/tui-regs.c:122:	    TUI_DATA_WIN->detail.data_display_info.regs_column_count) -
< gdb/tui/tui-regs.c:452: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/tui/tui-regs.c:452:	      if ((line = tui_line_from_reg_element_no (		 TUI_DATA_WIN->detail.data_display_info.regs_content_count - 1)) < 0)
< gdb/tui/tui-source.c:136: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/tui/tui-source.c:136:      if ((ret = tui_alloc_source_buffer (TUI_SRC_WIN)) == TUI_SUCCESS)
< gdb/tui/tui-source.c:152: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tui/tui-source.c:152:		  sprintf (name, ', filename, line_no);
< gdb/tui/tui-stack.c:159: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tui/tui-stack.c:159:      sprintf (buf, ',
< gdb/tui/tui-stack.c:165: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tui/tui-stack.c:165:      sprintf (buf, ',
< gdb/tui/tui-stack.c:181: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tui/tui-stack.c:181:        sprintf (buf, ', PROC_PREFIX,
< gdb/tui/tui-stack.c:184: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tui/tui-stack.c:184:        sprintf (buf, ', PROC_PREFIX,
< gdb/tui/tui-stack.c:191: code: sprintf: Do not use sprintf, instead use xsnprintf or xstrprintf
gdb/tui/tui-stack.c:191:      sprintf (buf, ', LINE_PREFIX,
< gdb/tui/tui-stack.c:405: code: OP eol: Do not use &&, or || at the end of a line
gdb/tui/tui-stack.c:405:	      start_line = (item->locator.line_no -
576,577d559
< gdb/tui/tui-win.c:1423: deprecated: deprecated safe_get_selected_frame: Do not use deprecated safe_get_selected_frame, see declaration for details
gdb/tui/tui-win.c:1423:      else if (deprecated_safe_get_selected_frame () != NULL)
< gdb/tui/tui-win.c:1428: deprecated: deprecated safe_get_selected_frame: Do not use deprecated safe_get_selected_frame, see declaration for details
gdb/tui/tui-win.c:1428:	  struct frame_info *frame = deprecated_safe_get_selected_frame ();
586,588c568,569
< gdb/tui/tui-windata.c:76: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/tui/tui-windata.c:76:  if ((first_element_no = tui_first_reg_element_no_inline (line_no)) == -1)
< gdb/tui/tui-windata.c:141: code: OP eol: Do not use &&, or || at the end of a line
gdb/tui/tui-windata.c:141:      if (TUI_DATA_WIN->detail.data_display_info.data_content !=
< gdb/tui/tui-winsource.c:115: code: OP eol: Do not use &&, or || at the end of a line
gdb/tui/tui-winsource.c:115:	  sal.line = line_or_addr.u.line_no +
> gdb/tui/tui-winsource.c:386: deprecated: deprecated safe_get_selected_frame: Do not use deprecated safe_get_selected_frame, see declaration for details
gdb/tui/tui-winsource.c:386:  else if (deprecated_safe_get_selected_frame () != NULL)
> gdb/tui/tui-winsource.c:391: deprecated: deprecated safe_get_selected_frame: Do not use deprecated safe_get_selected_frame, see declaration for details
gdb/tui/tui-winsource.c:391:      struct frame_info *frame = deprecated_safe_get_selected_frame ();
590a572
> gdb/ui-out.c:653: code: long long: Do not use 'long long', instead use LONGEST
gdb/ui-out.c:653:	  call_do_message (style, current_substring, va_arg (args, long long));
608,609d589
< gdb/utils.c:711: deprecated: deprecated interactive_hook: Do not use deprecated interactive_hook, see declaration for details
gdb/utils.c:711:  if (deprecated_interactive_hook)
< gdb/utils.c:712: deprecated: deprecated interactive_hook: Do not use deprecated interactive_hook, see declaration for details
gdb/utils.c:712:    deprecated_interactive_hook ();
621a602
> gdb/valops.c:560: gettext: multiple messages: Do not use multiple calls to warning or error, instead use a single call
gdb/valops.c:560:      error (_('));
655d635
< gdb/windows-nat.c:2742: regression: strerror: Do not use strerror(), instead use safe_strerror()
gdb/windows-nat.c:2742:	warning (_('), strerror (errno));
674,675d653
< gdb/common/mingw-strerror.c:0: internal: gdb/common/mingw-strerror.c missing strerror: Expecting 1 occurances of bug strerror in file gdb/common/mingw-strerror.c, only found 0
gdb/common/mingw-strerror.c:0:#endif  
< gdb/common/posix-strerror.c:0: internal: gdb/common/posix-strerror.c missing strerror: Expecting 1 occurances of bug strerror in file gdb/common/posix-strerror.c, only found 0
gdb/common/posix-strerror.c:0:#endif  



More information about the Gdb-patches mailing list