[PATCH] Fix build on macOS
Simon Marchi
simark@simark.ca
Wed Dec 11 14:07:00 GMT 2019
On 2019-12-11 8:52 a.m., Tom Tromey wrote:
> @@ -36,8 +37,31 @@
> #endif
>
> #ifdef USE_PTHREAD_SETNAME_NP
> +
> #include <pthread.h>
> -#endif
> +
> +DIAGNOSTIC_PUSH
> +DIAGNOSTIC_IGNORE_UNUSED_FUNCTION
> +
> +/* Handle platform discrepancies in pthread_setname_np: macOS uses a
> + single-argument form, while Linux uses a two-argument form. This
> + wrapper template handles the difference. */
This comment still mentions "template", you might want to change it?
Otherwise, that LGTM.
Simon
More information about the Gdb-patches
mailing list