[PATCH v2] Fix scripted probe breakpoints
George Barrett
bob@bob131.so
Mon Dec 9 21:43:00 GMT 2019
On Mon, Dec 09, 2019 at 04:37:47PM -0500, Simon Marchi wrote:
> so would you like me to push the patch on your behalf?
Yes, please.
> I found some other really small nits, I'll fix them before pushing if I end
> up pushing for you.
> I missed this last time, but also in GNU style we compare pointers and
> integers explicitly, so either one of these would be good:
> I would change null to NULL or nullptr to match the language nomenclature.
> non-zero -> true
I appreciate the tips, sorry for the additional round-trips.
Thank you for your patience and speedy review!
More information about the Gdb-patches
mailing list