[PATCH 1/3] gdb/testsuite/fortran: Fix info-modules/info-types for gfortran 8+

Pedro Alves palves@redhat.com
Fri Dec 6 19:46:00 GMT 2019


On 12/4/19 11:41 AM, Andrew Burgess wrote:

> Rather than building increasingly complex patterns that would always
> be at risk of breaking with future versions of GCC I have instead
> added a new library that parses the output of the following commands:
> 
>   info types
>   info variables
>   info functions
>   info modules
>   info module functions
>   info module variables
> 
> into a data structure, the test can than run checks against the
> contents of this data structure.

Looks like a good idea to me.

The patch LGTM.  Minor nits below.

> +	set _entries $new_entries
> +
> +	if { $found_match } {
> +	    pass $testname
> +	} else {
> +	    fail $testname
> +	}

Could be gdb_assert.

> +    }
> +
> +    # Check that there is no entry in the _entries list matching
> +    # FILENAME, MODULE, LINENO, and TEXT.  The LINENO and TEXT are
> +    # optional, and will be replaced with '.*' is missing.

Did you mean s/is missing/if missing/ ?  (likewise in the other
instances of this text.)

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list