[review] Core file build-id support

[Tom Tromey (Code Review)]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/509
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

I'm sorry about the delay on this review.

This patch looks good.  Impressive test case!  Thank you for doing this.

I had one nit in a comment, but no need for a re-review.

One thing I don't understand is how shared libraries work in this scenario.
How does gdb find the correct version of these from the core file?

| --- gdb/build-id.h
| +++ gdb/build-id.h
| @@ -39,10 +37,19 @@ /* Find and open a BFD given a build-id.  If no BFD can be found,
| -   the caller.  */
| +/* Find and open a BFD for a debuginfo file  given a build-id.  If no BFD
| +   can be found, return NULL.  The returned reference to the BFD must be
| +   released by the caller.  */
|  
|  extern gdb_bfd_ref_ptr build_id_to_debug_bfd (size_t build_id_len,
|  					      const bfd_byte *build_id);
|  
| +/* Find and open a BFD for an executable file given a build-id.  If no BFD
| +   can be found, return NULL.  The returned reference to the BFD must be
| +   released by the caller.  */

PS1, Line 46:

This text is just a leftover from before we had ref pointers.
Now I think it's implicit in the type and can just be left out.

| +
| +extern gdb_bfd_ref_ptr build_id_to_exec_bfd (size_t build_id_len,
| +					     const bfd_byte *build_id);
| +
|  /* Find the separate debug file for OBJFILE, by using the build-id
|     associated with OBJFILE's BFD.  If successful, returns the file name for the
|     separate debug file, otherwise, return an empty string.  */
|  
|  extern std::string find_separate_debug_file_by_buildid

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I15e9e8e58f10c68b5cae55e2eba58df1e8aef529
Gerrit-Change-Number: 509
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Seitz <keiths@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 05 Dec 2019 20:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment