[review] Change ARI usage to GNU style

Pedro Alves (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Thu Dec 5 17:02:00 GMT 2019


Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/749
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/contrib/ari/gdb_ari.sh
| +++ gdb/contrib/ari/gdb_ari.sh
| @@ -56,17 +55,18 @@ Usage:
| +    $0 --print-doc --print-idx -Wall -Werror -WCATEGORY FILE ...
|  Options:
|    --print-doc    Print a list of all potential problems, then exit.
|    --print-idx    Include the problems IDX (index or key) in every message.
|    --src=file     Write source lines to file.
|    -Werror        Treat all problems as errors.
|    -Wall          Report all problems.
|    -Wari          Report problems that should be fixed in new code.
| -  -W<category>   Report problems in the specifed category.  Valid categories
| +  -WCATEGORY     Report problems in the specifed category.  Valid categories

PS1, Line 63:

The disadvantage here is that W is also uppercase.  In this case it
looks unambiguous enough, though.  Not sure this is an improvement
because of that, but I guess it is fine.

|                   are: ${all}
|  EOF
|      exit 1
|  }
|  
|  
|  # Parse the various options
|  Woptions=
|  srclines=""

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
Gerrit-Change-Number: 749
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 17:02:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment



More information about the Gdb-patches mailing list