[review] Avoid ARI warnings with #include

Pedro Alves (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Thu Dec 5 16:55:00 GMT 2019


Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/746
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/gdb_vfork.h
| +++ gdb/gdb_vfork.h
| @@ -13,14 +13,14 @@ /* GDB-friendly replacement for <vfork.h>.
|     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
|     GNU General Public License for more details.
|  
|     You should have received a copy of the GNU General Public License
|     along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
|  
|  #ifndef GDB_VFORK_H
|  #define GDB_VFORK_H
|  
|  #if HAVE_VFORK_H
| -#include <vfork.h>
| +#include <vfork.h>		/* ARI: vfork.h */
|  #endif

PS1, Line 24:

Isn't this:

 BEGIN { doc["vfork.h"] = "\
 Do not include vfork.h, instead include gdb_vfork.h"
     fix("vfork.h", "gdb/gdb_vfork.h", 1);
                     ^^^^^^^^^^^^^^^
     category["vfork.h"] = ari_regression
 }

... supposed to suppress this case?

Same for the gdb_regex.h file.

|  
|  #endif /* GDB_VFORK_H */

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I215683952dec75379ea0a259e79c8dafbae210b9
Gerrit-Change-Number: 746
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 16:55:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment



More information about the Gdb-patches mailing list