[review] Share handle_exception

Pedro Alves (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Wed Dec 4 16:32:00 GMT 2019


Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/716
......................................................................


Patch Set 1: Code-Review+2

> Patch Set 1:
> > Patch Set 1:
> > Did you consider not having the new callbacks and instead install target_ops::thread_name on gdbserver too?
> 
> I tried today.  There's no shared target_read_string API, and I don't want
> to add any more things to this series than are strictly required -- it's already
> too long.

Fair enough.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4e6e0d17b868cd51964c273fb28ec066fea6b767
Gerrit-Change-Number: 716
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 04 Dec 2019 16:32:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment



More information about the Gdb-patches mailing list