[review] Add bit-field test for scalar_storage_order
Tom Tromey (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Wed Dec 4 14:36:00 GMT 2019
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/731
......................................................................
Patch Set 1:
> Patch Set 1:
>
> > Patch Set 1: Code-Review+2
> >
> > LGTM.
> >
> > When reading this, I wondered if you could arbitrarily nest structures with big and little endianness. I tested with:
>
> I looked at the DWARF for this test case, and it seems fine, so now I'm
> debugging gdb to see if there's something wrong there.
I guess I tried the wrong version of gdb, because this test case works fine
with this series.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9e07d1b3e08e7c3384832b68ef286afe1d11479a
Gerrit-Change-Number: 731
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Wed, 04 Dec 2019 14:36:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list