[review v11] gdb/mi: Add -symbol-info-module-{variables,functions}

Simon Marchi (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Tue Dec 3 16:38:00 GMT 2019


Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/268
......................................................................


Patch Set 11: Code-Review+2

> Gcc 7.3.1 is what's installed on my machine by default.  If I switch to a 10.0 compiler then I can reproduce this failure.
> 
> I've updated the patch and will get a better default version of GCC setup.
> 
> Sorry for wasting your time with this mistake.

No worries.  It would not be reasonable to ask everybody to test their patches with a bunch of different compilers.  Others or the CI can report the breakage if the patch builds with your gcc version, but not with an older or newer one.

Anyway, it builds now, LGTM.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic96f12dd14bd7e34774c3cde008fec30a4055bfe
Gerrit-Change-Number: 268
Gerrit-PatchSet: 11
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Joel Brobecker <brobecker@adacore.com>
Gerrit-Comment-Date: Tue, 03 Dec 2019 16:38:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment



More information about the Gdb-patches mailing list