[review v9] gdb/mi: Add -symbol-info-module-{variables,functions}
Andrew Burgess (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Mon Dec 2 19:16:00 GMT 2019
Andrew Burgess has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/268
......................................................................
Patch Set 9:
(1 comment)
| --- gdb/mi/mi-symbol-cmds.c
| +++ gdb/mi/mi-symbol-cmds.c
| @@ -219,0 +256,19 @@ /* Helper for mi_info_module_functions_or_variables. Display the results
| + from ITER up to END or until we find a symbol that is in a different
| + module than the first symbol we print. Update and return the new value
| + for ITER. */
| +static auto
| +output_module_symbols_in_single_module (struct ui_out *uiout,
| + auto iter,
| + auto end,
| + enum search_domain kind)
| +{
| + gdb_assert ((*iter).first.symbol != nullptr);
PS8, Line 265:
Yes I can! New patch uploaded.
| + gdb_assert ((*iter).second.symbol != nullptr);
| +
| + /* The symbol for the module in which the first result resides. */
| + const symbol *first_module_symbol = (*iter).first.symbol;
| +
| + /* Create output formatting. */
| + ui_out_emit_tuple module_tuple (uiout, nullptr);
| + uiout->field_string ("module", first_module_symbol->print_name ());
| + ui_out_emit_list files_list (uiout, "files");
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ic96f12dd14bd7e34774c3cde008fec30a4055bfe
Gerrit-Change-Number: 268
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Joel Brobecker <brobecker@adacore.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Mon, 02 Dec 2019 19:16:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list