[PATCH] Remove some variables in favor of using gdb::optional

Simon Marchi simon.marchi@polymtl.ca
Sat Aug 24 23:56:00 GMT 2019


On 2019-08-24 07:22, Ruslan Kabatsayev wrote:
> Since GDB uses C++11, and we don't really rely on conversion to int
> here, why not use enum class? This would protect from unwanted
> conversions. Additionally, we'll be forced to use a "scoped" name
> instead of "prefixed" one, like symbol_nature::unknown vs
> symbol_nature_unknown, which seems a bit more explicit (will need to
> do something with "static" though, since it's a keyword).

Good point, I'll try this for the new version.

Simon



More information about the Gdb-patches mailing list