[PATCH] Remove some variables in favor of using gdb::optional

Simon Marchi simon.marchi@polymtl.ca
Fri Aug 23 22:24:00 GMT 2019


On 2019-08-23 4:23 p.m., Pedro Alves wrote:
> Sorry for the delayed nit, but the first time I didn't really pay attention
> the the enumerator names you were using.  Reading back, I notice that you
> used "dynamic".  I don't know what that means here?  Don't you mean
> "external", as opposed to static?  Like, wouldn't this be more to the point?
> 
>   enum {
>     symbol_linkage_unknown,
>     symbol_linkage_static,
>     symbol_linkage_extern,
>   } symbol_linkage = symbol_linkage_unknown;

Oh yes of course, I was confused static/extern with static/dynamic.  I'll use that, thanks.

Simon



More information about the Gdb-patches mailing list