[PATCH v3] Convert the RX target to make use of target descriptions.
Yoshinori Sato
ysato@users.sourceforge.jp
Fri Aug 23 13:41:00 GMT 2019
On Fri, 23 Aug 2019 01:56:52 +0900,
Kevin Buettner wrote:
>
> On Thu, 22 Aug 2019 23:30:26 +0900
> Yoshinori Sato <ysato@users.sourceforge.jp> wrote:
>
> > gdb/ChangeLog
> >
> > 2019-08-22 Yoshinori Sato <ysato@users.sourceforge.jp>
> >
> > * gdb/rx-tdep.c (rx_register_names): New.
> > (rx_register_name): delete.
> > (rx_psw_type): delete.
> > (rx_fpsw_type): delete.
> > (rx_register_type): delete.
> > (rx_gdbarch_init): Convert target-descriptions.
> > (_initialize_rx_tdep): Add initialize_tdesc_rx.
> > * gdb/features/Makefile: Add rx.xml.
> > * gdb/features/rx.xml: New.
> > * gdb/features/rx.c: Likewise.
> > * gdb/NEWS: Mention target description support.
>
> One small nit - for gdb/features/rx.c, I'd prefer to see a ChangeLog
> comment saying that it's been generated. I.e.
>
> * gdb/features/rx.c: Generate.
>
> The rest looks good to me. If there are no other suggestions from
> someone else, go ahead and commit it with that small tweak.
>
> Kevin
OK.
This log will be fixed when I commit.
--
Yosinori Sato
More information about the Gdb-patches
mailing list