[PATCH][gdb/testsuite] Make gdb_test message unique in multi-term-settings.exp

Pedro Alves palves@redhat.com
Thu Aug 22 14:46:00 GMT 2019


On 8/22/19 3:21 PM, Tom de Vries wrote:
> Hi,
> 
> This racy fail message, reported in PR24929:
> ...
> FAIL: gdb.multi/multi-term-settings.exp: inf1_how=attach: inf2_how=attach: \
>   stop with control-c
> ...
> does not make clear which gdb_test fails here:
> ...
>     if {$expect_ttou} {
>        gdb_test "" "Quit" "stop with control-c"
>     } else {
>        gdb_test "" "received signal SIGINT.*" "stop with control-c"
>     }
> ...
> 
> Fix this by making the gdb_test message argument unique.

Pedantically, adding " (foo)" is not considered to make a message
unique.  

" (foo)" is just informative (and likewise used in other parts of
the testcase in that fashion).

The message is already unique given the "inf1_how=attach: inf2_how=attach:"
prefix.

> 
> Tested on x86_64-linux.
> 
> OK for trunk?

OK.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list