[PATCH] Remove some variables in favor of using gdb::optional
Wed Aug 21 19:38:00 GMT 2019
On 8/4/19 9:10 PM, Simon Marchi wrote:
> - bool have_is_static = false;
> - bool is_static;
> + gdb::optional<bool> is_static;
std::optional<bool> is evil. :-)
E.g. it's very easy to write (or miss converting)
and not realize that that is doing the wrong thing.
Not saying to change the code (*), but seeing it gives me the creeps, so I couldn't resist. :-)
* - a yes/no/unknown tristate type a-la boost::tribool would be nice
to have, IMO. It could be used more clearly in these situations
and could supersede auto_boolean.
More information about the Gdb-patches