[PATCH v2 2/8] Handle copy relocations
Tom Tromey
tromey@adacore.com
Wed Aug 21 19:11:00 GMT 2019
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>> +struct minimal_symbol *
>> +lookup_minimal_symbol_linkage (const char *name, struct objfile *objf)
Andrew> I found the name chosen for this function rather confusing. When
Andrew> comparing to say 'lookup_minimal_symbol_text' which does
Andrew> sort-of-almost the same thing but for text type symbols, I might have
Andrew> been tempted to go with 'lookup_minimal_symbol_data'. Am I missing
Andrew> something behind the choice of function name?
You aren't missing anything.
lookup_minimal_symbol_data seems maybe confusing too, because
lookup_minimal_symbol_text loops over all objfiles, but this one does not.
I guess I don't care all that much (as evidenced by the original choice
of name ;) so if you still like that better, I'll make the change.
Tom
More information about the Gdb-patches
mailing list