[PATCH][gdb] Make maint info sections print relocated addresses

Tom Tromey tom@tromey.com
Thu Aug 15 20:08:00 GMT 2019

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> gdb/ChangeLog:

Tom> 2019-08-14  Tom de Vries  <tdevries@suse.de>

Tom> 	* maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
Tom> 	print_objfile_section_info.


Tom> +      if (arg && strcmp (arg, "ALLOBJ") == 0)
Tom> +	{
Tom> +	  arg = NULL;
Tom> +	  allobj = true;
Tom> +	}

It took me a minute to understand that this was equivalent to the old
code.  It looked like the intent was to use match_substring, but then
other code defeated that.  If this was more user-facing I'd say "ALLOBJ"
should be replaced with a real option; but since this is a maint command
I would not bother.

This patch is ok.  Thanks.


More information about the Gdb-patches mailing list