[PATCH] [readline] Fix compilation on MinGW

Christian Biesinger via gdb-patches gdb-patches@sourceware.org
Tue Aug 13 19:59:00 GMT 2019

On Tue, Aug 13, 2019 at 2:46 PM Tom Tromey <tom@tromey.com> wrote:
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
> Christian> S_ISLNK should not be called outside of an #ifdef.
> Christian> However, this specific call is actually unnecessary, because
> Christian> linkok can only be 0 if S_ISLNK is true, per the code above.
> Christian> I have sent a bug report to bug-readline, though it does not show
> Christian> up in the online archive yet.
> I didn't see it show up there.  I wonder if something went wrong.

I also emailed Chet directly, hopefully that worked.

> Christian> 2019-08-13  Christian Biesinger  <cbiesinger@google.com>
> Christian>      * colors.c (_rl_print_color_indicator): Remove unnecessary
> Christian>      S_ISLNK check to fix compilation on MinGW.
> This looks fine to me.  Please check it in.


> It's important to be sure to follow up with upstream readline; and to
> update the patch in the local tree if Chet uses a different patch.

Will do.


More information about the Gdb-patches mailing list