[PATCH V2] AArch64 pauth: Indicate unmasked addresses in backtrace

Pedro Alves palves@redhat.com
Fri Aug 9 16:51:00 GMT 2019


On 8/9/19 3:46 PM, Alan Hayward wrote:

> I was thinking of the following:

Ah, I thought you meant create a "uiout->field_addr_flags(...);" method.

> 
> char *flags = gdbarch_print_pc_addr_flags(frame, pc);  /* Returns null or “PAC” or “FOO,BAR” etc */
> if (flags)
> {
>   uiout->text (“ [“);
>   uiout->field_string (“addr_flags", flags);
>   uiout->text (“]“);
> }
> 
> addr_flags can be printed by any target that wishes. And PAC only needs to be in
> AArch64 specifics.
Sounds fine to me.

Maybe return a std::string instead of a pointer to a static buffer.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list