[PATCH] Fix access to uninitialized variable in fill_in_stop_func
Thu Aug 8 17:42:00 GMT 2019
On Thu, 08 Aug 2019 11:14:22 -0600
Tom Tromey <email@example.com> wrote:
> >>>>> "Pedro" == Pedro Franco de Carvalho <firstname.lastname@example.org> writes:
> Pedro> This patch changes fill_in_stop_func to check the return value of
> Pedro> find_pc_partial_function before accessing the block pointer that is only
> Pedro> written by find_pc_partial_function if it returns a success status.
> Pedro> gdb/ChangeLog:
> Pedro> YYYY-MM-DD Pedro Franco de Carvalho <email@example.com>
> Pedro> * infrun.c (fill_in_stop_func): Use return value of
> Pedro> find_pc_partial_function, remove comment.
> The comment for find_pc_partial_function says:
> nullptr is used as a return value for *BLOCK if no block is found.
> ... which implies to me that the function was intended to set *BLOCK
> unconditionally. Perhaps Kevin could say, as I think he added the block
Yes, that was the intent, but unfortunately, that's not what's happening.
find_pc_partial_function contains the following return path...
if (msymbol.minsym == NULL)
/* No available symbol. */
if (name != NULL)
*name = 0;
if (address != NULL)
*address = 0;
if (endaddr != NULL)
*endaddr = 0;
...which does not set *BLOCK.
I think I'd prefer to see...
if (block != nullptr)
*block = nullptr;
...added to find_pc_partial_function instead.
More information about the Gdb-patches