[PATCH] AArch64: Allow additional sizes in prologue

Tom Tromey tom@tromey.com
Mon Aug 5 17:43:00 GMT 2019


>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:

Alan> When saving registers to the stack at the start of a function, not all state
Alan> needs to be saved. For example, only the first 64bits of float registers need
Alan> saving.  However, a program may choose to store extra state if it wishes,
Alan> there is nothing preventing it doing so.

Alan> The aarch64_analyze_prologue will error if it detects extra state being
Alan> stored.  Relex this restriction.

I don't know anything about AArch64, so I can't really comment on the
content of the patch, but I did happen to see a nit:

Alan>  	  stack.store (pv_add_constant (regs[rn],
Alan>  					inst.operands[1].addr.offset.imm),
Alan> -		       is64 ? 8 : 4, regs[rt]);
Alan> +					size, regs[rt]);

...this addition looked mis-indented to me.

Tom



More information about the Gdb-patches mailing list