[RFAv2 1/3] New "info sources" args [-dirname | -basename] [--] [REGEXP]

Philippe Waroquiers philippe.waroquiers@skynet.be
Sat Aug 3 19:42:00 GMT 2019


On Wed, 2019-07-24 at 13:14 -0600, Tom Tromey wrote:
> One idea might be to separate the main text from the parenthetical text,
> so like:
> 
>   printf_filtered (_("Source files for which symbols have been read in"));
>   if (blah)
>     printf_filtered (_("(dirname matching regular expression \"%s\")"), dirname);
>   ...
>   printf_filtered (_(":\n"));
> 
> The "if"s could be factored into a helper function.
> 
> Otherwise this patch seems good to me.  Thanks for doing this.
Thanks for the review.

Pushed after fixing the above, adding a copyright header that was missing
in a test file.

Philippe
 



More information about the Gdb-patches mailing list