[PATCH] Fix out-of-bounds read in tui_addr_is_displayed

Tom Tromey tom@tromey.com
Fri Aug 2 18:07:00 GMT 2019


>>>>> "Bogdan" == Bogdan Harjoc <harjoc@gmail.com> writes:

Bogdan> In tui_addr_is_displayed(), if win_info->content.size() is less than 2, then
win_info-> content.size () - threshold

Bogdan> will wrap to SIZE_MAX if threshold = SCROLL_THRESHOLD = 2.

Bogdan> The attached patch avoids calling win_info->content[i] below with i=0
Bogdan> which is past the end of the vector of size 0.

Thank you for the patch.  Nice catch.

This needs a ChangeLog entry but is otherwise ok.

Tom



More information about the Gdb-patches mailing list