[PATCH] Increase timeout in gdb.mi/list-thread-groups-available.exp

Tom Tromey tom@tromey.com
Fri Aug 2 13:43:00 GMT 2019

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> for me, both tests fail with a timeout.  And if we're increasing the
Tom> timeout, how about we only do that if check-read1 is used?

I'm reluctant to make the test suite more sensitive to the environment
it's running it.  Is the reason to do this that the test can time out
normally, and so we'd like to avoid lengthy timeouts?  If that's the
case, can the test be fixed somehow instead?

I guess my mental model here is that a timeout should not matter unless
a test is flaky.  But maybe that's naive?  I don't know :-)

Tom> +proc with_timeout_factor { factor body {body_uplevel 1}} {

I think body_uplevel shouldn't be needed.

Tom> +    return [with_timeout_factor $factor $body 2]

... since this can just do

    return [uplevel [list with_timeout_factor $factor $body]]


More information about the Gdb-patches mailing list