[PATCH 3/4] testsuite: Disable tests when logging

Tom Tromey tom@tromey.com
Thu Apr 25 14:36:00 GMT 2019


>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:

Alan> 	* gdb.base/breakpoint-in-ro-region.exp: Disable when debugging.
[...]

My first reaction to this was negative, but after thinking about it a
little I came around.  I think my view is that enabling debug logging
for the test suite is primarily a debugging tool, and so it's fine --
especially for tests that are already enabling debugging -- for it not
to work universally.

Alan> +# Do not run if gdb debug is enabled

Normally comments should have a "." at the end.
It would perhaps be good if the comments explained why.

Alan> +# Do not run if gdb debug is enabled - it interferes with the command history.

... like this one.  Is that reasonable?

thanks,
Tom



More information about the Gdb-patches mailing list