Still some style problems with 8.3 branch

Eli Zaretskii eliz@gnu.org
Fri Apr 12 12:39:00 GMT 2019


> From: Tom Tromey <tom@tromey.com>
> Cc: Philippe Waroquiers <philippe.waroquiers@skynet.be>,  Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
> Date: Thu, 11 Apr 2019 13:20:16 -0600
> 
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> Eli> I don't think it's due to buffering.  If I #ifdef away this part near
> Eli> the end of prompt_for_continue:
> 
> Eli>   /* Restore the current styling.  */
> Eli>   if (can_emit_style_escape (gdb_stdout))
> Eli>     emit_style_escape (applied_style);
> 
> Eli> then the problem seems to go away.  So I think this style setting is
> Eli> what causes the problem, probably because applied_style has the wrong
> Eli> value here?
> 
> I think this is correct.  Certainly applied_style has the wrong value
> here, since it was reset by the call to emit_style_escape near the top
> of prompt_for_continue.  
> 
> So, I think a patch to remove these lines is ok.  I can do it if you want.

Thanks, I pushed this now to both branches.



More information about the Gdb-patches mailing list