[FYI] Sort includes for files gdb/[a-f]*.[chyl].

Tom Tromey tom@tromey.com
Sat Apr 6 01:17:00 GMT 2019


This patch sorts the include files for the files [a-f]*.[chyl].
The patch was written by a script.

Tested by the buildbot.

I will follow up with patches to sort the remaining files, by sorting
a subset, testing them, and then checking them in.

gdb/ChangeLog
2019-04-05  Tom Tromey  <tom@tromey.com>

	* ft32-tdep.c: Sort headers.
	* frv-tdep.c: Sort headers.
	* frv-linux-tdep.c: Sort headers.
	* frame.c: Sort headers.
	* frame-unwind.c: Sort headers.
	* frame-base.c: Sort headers.
	* fork-child.c: Sort headers.
	* findvar.c: Sort headers.
	* findcmd.c: Sort headers.
	* filesystem.c: Sort headers.
	* filename-seen-cache.h: Sort headers.
	* filename-seen-cache.c: Sort headers.
	* fbsd-tdep.c: Sort headers.
	* fbsd-nat.h: Sort headers.
	* fbsd-nat.c: Sort headers.
	* f-valprint.c: Sort headers.
	* f-typeprint.c: Sort headers.
	* f-lang.c: Sort headers.
	* extension.h: Sort headers.
	* extension.c: Sort headers.
	* extension-priv.h: Sort headers.
	* expprint.c: Sort headers.
	* exec.h: Sort headers.
	* exec.c: Sort headers.
	* exceptions.c: Sort headers.
	* event-top.c: Sort headers.
	* event-loop.c: Sort headers.
	* eval.c: Sort headers.
	* elfread.c: Sort headers.
	* dwarf2read.h: Sort headers.
	* dwarf2read.c: Sort headers.
	* dwarf2loc.c: Sort headers.
	* dwarf2expr.h: Sort headers.
	* dwarf2expr.c: Sort headers.
	* dwarf2-frame.c: Sort headers.
	* dwarf2-frame-tailcall.c: Sort headers.
	* dwarf-index-write.h: Sort headers.
	* dwarf-index-write.c: Sort headers.
	* dwarf-index-common.c: Sort headers.
	* dwarf-index-cache.h: Sort headers.
	* dwarf-index-cache.c: Sort headers.
	* dummy-frame.c: Sort headers.
	* dtrace-probe.c: Sort headers.
	* disasm.h: Sort headers.
	* disasm.c: Sort headers.
	* disasm-selftests.c: Sort headers.
	* dictionary.c: Sort headers.
	* dicos-tdep.c: Sort headers.
	* demangle.c: Sort headers.
	* dcache.h: Sort headers.
	* dcache.c: Sort headers.
	* darwin-nat.h: Sort headers.
	* darwin-nat.c: Sort headers.
	* darwin-nat-info.c: Sort headers.
	* d-valprint.c: Sort headers.
	* d-namespace.c: Sort headers.
	* d-lang.c: Sort headers.
	* ctf.c: Sort headers.
	* csky-tdep.c: Sort headers.
	* csky-linux-tdep.c: Sort headers.
	* cris-tdep.c: Sort headers.
	* cris-linux-tdep.c: Sort headers.
	* cp-valprint.c: Sort headers.
	* cp-support.c: Sort headers.
	* cp-namespace.c: Sort headers.
	* cp-abi.c: Sort headers.
	* corelow.c: Sort headers.
	* corefile.c: Sort headers.
	* continuations.c: Sort headers.
	* completer.h: Sort headers.
	* completer.c: Sort headers.
	* complaints.c: Sort headers.
	* coffread.c: Sort headers.
	* coff-pe-read.c: Sort headers.
	* cli-out.h: Sort headers.
	* cli-out.c: Sort headers.
	* charset.c: Sort headers.
	* c-varobj.c: Sort headers.
	* c-valprint.c: Sort headers.
	* c-typeprint.c: Sort headers.
	* c-lang.c: Sort headers.
	* buildsym.c: Sort headers.
	* buildsym-legacy.c: Sort headers.
	* build-id.h: Sort headers.
	* build-id.c: Sort headers.
	* btrace.c: Sort headers.
	* bsd-uthread.c: Sort headers.
	* breakpoint.h: Sort headers.
	* breakpoint.c: Sort headers.
	* break-catch-throw.c: Sort headers.
	* break-catch-syscall.c: Sort headers.
	* break-catch-sig.c: Sort headers.
	* blockframe.c: Sort headers.
	* block.c: Sort headers.
	* bfin-tdep.c: Sort headers.
	* bfin-linux-tdep.c: Sort headers.
	* bfd-target.c: Sort headers.
	* bcache.c: Sort headers.
	* ax-general.c: Sort headers.
	* ax-gdb.h: Sort headers.
	* ax-gdb.c: Sort headers.
	* avr-tdep.c: Sort headers.
	* auxv.c: Sort headers.
	* auto-load.c: Sort headers.
	* arm-wince-tdep.c: Sort headers.
	* arm-tdep.c: Sort headers.
	* arm-symbian-tdep.c: Sort headers.
	* arm-pikeos-tdep.c: Sort headers.
	* arm-obsd-tdep.c: Sort headers.
	* arm-nbsd-tdep.c: Sort headers.
	* arm-nbsd-nat.c: Sort headers.
	* arm-linux-tdep.c: Sort headers.
	* arm-linux-nat.c: Sort headers.
	* arm-fbsd-tdep.c: Sort headers.
	* arm-fbsd-nat.c: Sort headers.
	* arm-bsd-tdep.c: Sort headers.
	* arch-utils.c: Sort headers.
	* arc-tdep.c: Sort headers.
	* arc-newlib-tdep.c: Sort headers.
	* annotate.h: Sort headers.
	* annotate.c: Sort headers.
	* amd64-windows-tdep.c: Sort headers.
	* amd64-windows-nat.c: Sort headers.
	* amd64-tdep.c: Sort headers.
	* amd64-sol2-tdep.c: Sort headers.
	* amd64-obsd-tdep.c: Sort headers.
	* amd64-obsd-nat.c: Sort headers.
	* amd64-nbsd-tdep.c: Sort headers.
	* amd64-nbsd-nat.c: Sort headers.
	* amd64-nat.c: Sort headers.
	* amd64-linux-tdep.c: Sort headers.
	* amd64-linux-nat.c: Sort headers.
	* amd64-fbsd-tdep.c: Sort headers.
	* amd64-fbsd-nat.c: Sort headers.
	* amd64-dicos-tdep.c: Sort headers.
	* amd64-darwin-tdep.c: Sort headers.
	* amd64-bsd-nat.c: Sort headers.
	* alpha-tdep.c: Sort headers.
	* alpha-obsd-tdep.c: Sort headers.
	* alpha-nbsd-tdep.c: Sort headers.
	* alpha-mdebug-tdep.c: Sort headers.
	* alpha-linux-tdep.c: Sort headers.
	* alpha-linux-nat.c: Sort headers.
	* alpha-bsd-tdep.c: Sort headers.
	* alpha-bsd-nat.c: Sort headers.
	* aix-thread.c: Sort headers.
	* agent.c: Sort headers.
	* addrmap.c: Sort headers.
	* ada-varobj.c: Sort headers.
	* ada-valprint.c: Sort headers.
	* ada-typeprint.c: Sort headers.
	* ada-tasks.c: Sort headers.
	* ada-lang.c: Sort headers.
	* aarch64-tdep.c: Sort headers.
	* aarch64-ravenscar-thread.c: Sort headers.
	* aarch64-newlib-tdep.c: Sort headers.
	* aarch64-linux-tdep.c: Sort headers.
	* aarch64-linux-nat.c: Sort headers.
	* aarch64-fbsd-tdep.c: Sort headers.
	* aarch64-fbsd-nat.c: Sort headers.
	* aarch32-linux-nat.c: Sort headers.
---
 gdb/ChangeLog                  | 164 +++++++++++++++++++++++++++++++++
 gdb/aarch32-linux-nat.c        |  10 +-
 gdb/aarch64-fbsd-nat.c         |  12 ++-
 gdb/aarch64-fbsd-tdep.c        |   9 +-
 gdb/aarch64-linux-nat.c        |  36 ++++----
 gdb/aarch64-linux-tdep.c       |  36 ++++----
 gdb/aarch64-newlib-tdep.c      |   3 +-
 gdb/aarch64-ravenscar-thread.c |   8 +-
 gdb/aarch64-tdep.c             |  64 +++++++------
 gdb/ada-lang.c                 |  71 +++++++-------
 gdb/ada-tasks.c                |  12 ++-
 gdb/ada-typeprint.c            |  32 ++++---
 gdb/ada-valprint.c             |  20 ++--
 gdb/ada-varobj.c               |   4 +-
 gdb/addrmap.c                  |   6 +-
 gdb/agent.c                    |   4 +-
 gdb/aix-thread.c               |  25 ++---
 gdb/alpha-bsd-nat.c            |  19 ++--
 gdb/alpha-bsd-tdep.c           |   5 +-
 gdb/alpha-linux-nat.c          |  15 +--
 gdb/alpha-linux-tdep.c         |  10 +-
 gdb/alpha-mdebug-tdep.c        |  15 +--
 gdb/alpha-nbsd-tdep.c          |  11 ++-
 gdb/alpha-obsd-tdep.c          |   9 +-
 gdb/alpha-tdep.c               |  38 ++++----
 gdb/amd64-bsd-nat.c            |   2 +
 gdb/amd64-darwin-tdep.c        |  27 +++---
 gdb/amd64-dicos-tdep.c         |   4 +-
 gdb/amd64-fbsd-nat.c           |  21 +++--
 gdb/amd64-fbsd-tdep.c          |  13 +--
 gdb/amd64-linux-nat.c          |  26 +++---
 gdb/amd64-linux-tdep.c         |  29 +++---
 gdb/amd64-nat.c                |   9 +-
 gdb/amd64-nbsd-nat.c           |   7 +-
 gdb/amd64-nbsd-tdep.c          |  11 ++-
 gdb/amd64-obsd-nat.c           |   9 +-
 gdb/amd64-obsd-tdep.c          |  19 ++--
 gdb/amd64-sol2-tdep.c          |  11 ++-
 gdb/amd64-tdep.c               |  36 ++++----
 gdb/amd64-windows-nat.c        |   9 +-
 gdb/amd64-windows-tdep.c       |  26 +++---
 gdb/annotate.c                 |  11 ++-
 gdb/annotate.h                 |   2 +-
 gdb/arc-newlib-tdep.c          |   3 +-
 gdb/arc-tdep.c                 |   4 +-
 gdb/arch-utils.c               |  22 ++---
 gdb/arm-bsd-tdep.c             |   5 +-
 gdb/arm-fbsd-nat.c             |  12 ++-
 gdb/arm-fbsd-tdep.c            |   5 +-
 gdb/arm-linux-nat.c            |  33 +++----
 gdb/arm-linux-tdep.c           |  56 +++++------
 gdb/arm-nbsd-nat.c             |  17 ++--
 gdb/arm-nbsd-tdep.c            |   3 +-
 gdb/arm-obsd-tdep.c            |   9 +-
 gdb/arm-pikeos-tdep.c          |   4 +-
 gdb/arm-symbian-tdep.c         |   6 +-
 gdb/arm-tdep.c                 |  77 ++++++++--------
 gdb/arm-wince-tdep.c           |   9 +-
 gdb/auto-load.c                |  36 +++++---
 gdb/auxv.c                     |  26 +++---
 gdb/avr-tdep.c                 |  20 ++--
 gdb/ax-gdb.c                   |  41 +++++----
 gdb/ax-gdb.h                   |   2 +-
 gdb/ax-general.c               |   5 +-
 gdb/bcache.c                   |   4 +-
 gdb/bfd-target.c               |   4 +-
 gdb/bfin-linux-tdep.c          |  10 +-
 gdb/bfin-tdep.c                |  26 +++---
 gdb/block.c                    |  10 +-
 gdb/blockframe.c               |  22 +++--
 gdb/break-catch-sig.c          |  17 ++--
 gdb/break-catch-syscall.c      |  12 ++-
 gdb/break-catch-throw.c        |  26 +++---
 gdb/breakpoint.c               |  80 ++++++++--------
 gdb/breakpoint.h               |  16 ++--
 gdb/bsd-uthread.c              |   8 +-
 gdb/btrace.c                   |  18 ++--
 gdb/build-id.c                 |   8 +-
 gdb/build-id.h                 |   2 +-
 gdb/buildsym-legacy.c          |   2 +
 gdb/buildsym.c                 |  30 +++---
 gdb/c-lang.c                   |  24 +++--
 gdb/c-typeprint.c              |  24 ++---
 gdb/c-valprint.c               |  17 ++--
 gdb/c-varobj.c                 |   6 +-
 gdb/charset.c                  |  18 ++--
 gdb/cli-out.c                  |   6 +-
 gdb/cli-out.h                  |   4 +-
 gdb/coff-pe-read.c             |  18 ++--
 gdb/coffread.c                 |  34 +++----
 gdb/complaints.c               |   8 +-
 gdb/completer.c                |  24 +++--
 gdb/completer.h                |   2 +-
 gdb/continuations.c            |   4 +-
 gdb/corefile.c                 |  22 +++--
 gdb/corelow.c                  |  40 ++++----
 gdb/cp-abi.c                   |   7 +-
 gdb/cp-namespace.c             |  22 +++--
 gdb/cp-support.c               |  26 +++---
 gdb/cp-valprint.c              |  26 +++---
 gdb/cris-linux-tdep.c          |   7 +-
 gdb/cris-tdep.c                |  35 ++++---
 gdb/csky-linux-tdep.c          |  10 +-
 gdb/csky-tdep.c                |  56 +++++------
 gdb/ctf.c                      |  22 +++--
 gdb/d-lang.c                   |  12 ++-
 gdb/d-namespace.c              |   8 +-
 gdb/d-valprint.c               |   8 +-
 gdb/darwin-nat-info.c          |  29 +++---
 gdb/darwin-nat.c               |  71 +++++++-------
 gdb/darwin-nat.h               |   4 +-
 gdb/dcache.c                   |   4 +-
 gdb/dcache.h                   |   2 +-
 gdb/demangle.c                 |   6 +-
 gdb/dicos-tdep.c               |   8 +-
 gdb/dictionary.c               |  12 ++-
 gdb/disasm-selftests.c         |   2 +
 gdb/disasm.c                   |  20 ++--
 gdb/disasm.h                   |   2 +-
 gdb/dtrace-probe.c             |  18 ++--
 gdb/dummy-frame.c              |  12 ++-
 gdb/dwarf-index-cache.c        |  15 ++-
 gdb/dwarf-index-cache.h        |   2 +-
 gdb/dwarf-index-common.c       |   2 +
 gdb/dwarf-index-write.c        |  14 +--
 gdb/dwarf-index-write.h        |   2 +-
 gdb/dwarf2-frame-tailcall.c    |  10 +-
 gdb/dwarf2-frame.c             |  22 +++--
 gdb/dwarf2expr.c               |  12 ++-
 gdb/dwarf2expr.h               |   2 +-
 gdb/dwarf2loc.c                |  40 ++++----
 gdb/dwarf2read.c               | 108 ++++++++++++----------
 gdb/dwarf2read.h               |   2 +
 gdb/elfread.c                  |  36 ++++----
 gdb/eval.c                     |  32 ++++---
 gdb/event-loop.c               |   4 +-
 gdb/event-top.c                |  32 ++++---
 gdb/exceptions.c               |  14 +--
 gdb/exec.c                     |  44 +++++----
 gdb/exec.h                     |   4 +-
 gdb/expprint.c                 |  19 ++--
 gdb/extension-priv.h           |   4 +-
 gdb/extension.c                |  12 ++-
 gdb/extension.h                |   4 +-
 gdb/f-lang.c                   |  27 +++---
 gdb/f-typeprint.c              |  12 ++-
 gdb/f-valprint.c               |  18 ++--
 gdb/fbsd-nat.c                 |  36 ++++----
 gdb/fbsd-nat.h                 |   4 +-
 gdb/fbsd-tdep.c                |  17 ++--
 gdb/filename-seen-cache.c      |   2 +
 gdb/filename-seen-cache.h      |   2 +-
 gdb/filesystem.c               |   2 +
 gdb/findcmd.c                  |  16 +++-
 gdb/findvar.c                  |  22 +++--
 gdb/fork-child.c               |  14 +--
 gdb/frame-base.c               |   2 +
 gdb/frame-unwind.c             |  10 +-
 gdb/frame.c                    |  36 ++++----
 gdb/frv-linux-tdep.c           |  18 ++--
 gdb/frv-tdep.c                 |  30 +++---
 gdb/ft32-tdep.c                |  34 +++----
 162 files changed, 1757 insertions(+), 1261 deletions(-)

diff --git a/gdb/aarch32-linux-nat.c b/gdb/aarch32-linux-nat.c
index e23dbb1bbbe..6471626810b 100644
--- a/gdb/aarch32-linux-nat.c
+++ b/gdb/aarch32-linux-nat.c
@@ -17,12 +17,12 @@
 
 #include "defs.h"
 
-#include "regcache.h"
-#include "arm-tdep.h"
-#include "arm-linux-tdep.h"
-#include "arch/arm-linux.h"
-
+/* Local non-gdb includes.  */
 #include "aarch32-linux-nat.h"
+#include "arch/arm-linux.h"
+#include "arm-linux-tdep.h"
+#include "arm-tdep.h"
+#include "regcache.h"
 
 /* Supply GP registers contents, stored in REGS, to REGCACHE.  ARM_APCS_32
    is true if the 32-bit mode is in use, otherwise, it is false.  */
diff --git a/gdb/aarch64-fbsd-nat.c b/gdb/aarch64-fbsd-nat.c
index bb187a600d0..cb4130a2844 100644
--- a/gdb/aarch64-fbsd-nat.c
+++ b/gdb/aarch64-fbsd-nat.c
@@ -18,16 +18,18 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "target.h"
 
-#include <sys/types.h>
-#include <sys/ptrace.h>
+/* Standard C includes.  */
 #include <machine/reg.h>
+#include <sys/ptrace.h>
+#include <sys/types.h>
 
-#include "fbsd-nat.h"
-#include "aarch64-tdep.h"
+/* Local non-gdb includes.  */
 #include "aarch64-fbsd-tdep.h"
+#include "aarch64-tdep.h"
+#include "fbsd-nat.h"
 #include "inf-ptrace.h"
+#include "target.h"
 
 struct aarch64_fbsd_nat_target final : public fbsd_nat_target
 {
diff --git a/gdb/aarch64-fbsd-tdep.c b/gdb/aarch64-fbsd-tdep.c
index c611ff350bd..63850abe5a1 100644
--- a/gdb/aarch64-fbsd-tdep.c
+++ b/gdb/aarch64-fbsd-tdep.c
@@ -19,15 +19,16 @@
 
 #include "defs.h"
 
-#include "gdbarch.h"
-#include "fbsd-tdep.h"
-#include "aarch64-tdep.h"
+/* Local non-gdb includes.  */
 #include "aarch64-fbsd-tdep.h"
+#include "aarch64-tdep.h"
+#include "fbsd-tdep.h"
+#include "gdbarch.h"
 #include "osabi.h"
 #include "solib-svr4.h"
 #include "target.h"
-#include "tramp-frame.h"
 #include "trad-frame.h"
+#include "tramp-frame.h"
 
 /* Register maps.  */
 
diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
index 6d43eb7070f..b9e68801dd1 100644
--- a/gdb/aarch64-linux-nat.c
+++ b/gdb/aarch64-linux-nat.c
@@ -20,29 +20,29 @@
 
 #include "defs.h"
 
-#include "inferior.h"
-#include "gdbcore.h"
-#include "regcache.h"
-#include "linux-nat.h"
-#include "target-descriptions.h"
+/* Standard C includes.  */
+#include <asm/ptrace.h>
+#include <sys/utsname.h>
+
+/* Local non-gdb includes.  */
+#include "aarch32-linux-nat.h"
+#include "aarch64-linux-tdep.h"
+#include "aarch64-tdep.h"
 #include "auxv.h"
+#include "elf/common.h"
+#include "elf/external.h"
 #include "gdbcmd.h"
-#include "aarch64-tdep.h"
-#include "aarch64-linux-tdep.h"
-#include "aarch32-linux-nat.h"
-#include "nat/aarch64-linux.h"
+#include "gdbcore.h"
+#include "gregset.h"
+#include "inferior.h"
+#include "linux-nat.h"
+#include "linux-tdep.h"
 #include "nat/aarch64-linux-hw-point.h"
+#include "nat/aarch64-linux.h"
 #include "nat/aarch64-sve-linux-ptrace.h"
-
-#include "elf/external.h"
-#include "elf/common.h"
-
 #include "nat/gdb_ptrace.h"
-#include <sys/utsname.h>
-#include <asm/ptrace.h>
-
-#include "gregset.h"
-#include "linux-tdep.h"
+#include "regcache.h"
+#include "target-descriptions.h"
 
 /* Defines ps_err_e, struct ps_prochandle.  */
 #include "gdb_proc_service.h"
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 7f2193f2fa5..5a126b0c83c 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -20,33 +20,33 @@
 
 #include "defs.h"
 
-#include "gdbarch.h"
+/* Standard C includes.  */
+#include <ctype.h>
+
+/* Local non-gdb includes.  */
+#include "aarch64-linux-tdep.h"
+#include "aarch64-tdep.h"
 #include "arch-utils.h"
+#include "auxv.h"
+#include "cli/cli-utils.h"
+#include "elf/common.h"
+#include "gdbarch.h"
 #include "glibc-tdep.h"
+#include "inferior.h"
+#include "linux-record.h"
 #include "linux-tdep.h"
-#include "aarch64-tdep.h"
-#include "aarch64-linux-tdep.h"
 #include "osabi.h"
-#include "solib-svr4.h"
-#include "symtab.h"
-#include "tramp-frame.h"
-#include "trad-frame.h"
-
-#include "inferior.h"
+#include "parser-defs.h"
+#include "record-full.h"
 #include "regcache.h"
 #include "regset.h"
-
-#include "cli/cli-utils.h"
+#include "solib-svr4.h"
 #include "stap-probe.h"
-#include "parser-defs.h"
+#include "symtab.h"
+#include "trad-frame.h"
+#include "tramp-frame.h"
 #include "user-regs.h"
 #include "xml-syscall.h"
-#include <ctype.h>
-
-#include "record-full.h"
-#include "linux-record.h"
-#include "auxv.h"
-#include "elf/common.h"
 
 /* Signal frame handling.
 
diff --git a/gdb/aarch64-newlib-tdep.c b/gdb/aarch64-newlib-tdep.c
index 131f0991970..3c1c8986bef 100644
--- a/gdb/aarch64-newlib-tdep.c
+++ b/gdb/aarch64-newlib-tdep.c
@@ -20,8 +20,9 @@
 
 #include "defs.h"
 
-#include "gdbarch.h"
+/* Local non-gdb includes.  */
 #include "aarch64-tdep.h"
+#include "gdbarch.h"
 #include "osabi.h"
 
 /* Implement the 'init_osabi' method of struct gdb_osabi_handler.  */
diff --git a/gdb/aarch64-ravenscar-thread.c b/gdb/aarch64-ravenscar-thread.c
index 3e87a4bf5b9..b6709fca22e 100644
--- a/gdb/aarch64-ravenscar-thread.c
+++ b/gdb/aarch64-ravenscar-thread.c
@@ -18,12 +18,14 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdbcore.h"
-#include "regcache.h"
+
+/* Local non-gdb includes.  */
+#include "aarch64-ravenscar-thread.h"
 #include "aarch64-tdep.h"
+#include "gdbcore.h"
 #include "inferior.h"
 #include "ravenscar-thread.h"
-#include "aarch64-ravenscar-thread.h"
+#include "regcache.h"
 
 #define NO_OFFSET -1
 
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 68b6549ba9b..ca0d0023126 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -20,46 +20,44 @@
 
 #include "defs.h"
 
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "aarch64-ravenscar-thread.h"
+#include "aarch64-tdep.h"
+#include "arch-utils.h"
+#include "arch/aarch64-insn.h"
+#include "ax-gdb.h"
+#include "ax.h"
+#include "common/selftest.h"
+#include "common/vec.h"
+#include "dis-asm.h"
+#include "dwarf2-frame.h"
+#include "dwarf2.h"
+#include "elf-bfd.h"
+#include "elf/aarch64.h"
+#include "frame-base.h"
+#include "frame-unwind.h"
 #include "frame.h"
-#include "inferior.h"
 #include "gdbcmd.h"
 #include "gdbcore.h"
-#include "dis-asm.h"
-#include "regcache.h"
-#include "reggroups.h"
-#include "value.h"
-#include "arch-utils.h"
-#include "osabi.h"
-#include "frame-unwind.h"
-#include "frame-base.h"
-#include "trad-frame.h"
-#include "objfiles.h"
-#include "dwarf2.h"
-#include "dwarf2-frame.h"
 #include "gdbtypes.h"
+#include "infcall.h"
+#include "inferior.h"
+#include "language.h"
+#include "objfiles.h"
+#include "opcode/aarch64.h"
+#include "osabi.h"
 #include "prologue-value.h"
+#include "record-full.h"
+#include "record.h"
+#include "regcache.h"
+#include "reggroups.h"
 #include "target-descriptions.h"
+#include "trad-frame.h"
 #include "user-regs.h"
-#include "language.h"
-#include "infcall.h"
-#include "ax.h"
-#include "ax-gdb.h"
-#include "common/selftest.h"
-
-#include "aarch64-tdep.h"
-#include "aarch64-ravenscar-thread.h"
-
-#include "elf-bfd.h"
-#include "elf/aarch64.h"
-
-#include "common/vec.h"
-
-#include "record.h"
-#include "record-full.h"
-#include "arch/aarch64-insn.h"
-
-#include "opcode/aarch64.h"
-#include <algorithm>
+#include "value.h"
 
 #define submask(x) ((1L << ((x) + 1)) - 1)
 #define bit(obj,st) (((obj) >> (st)) & 1)
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 51615dcd361..10ae7cb75de 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -19,50 +19,55 @@
 
 
 #include "defs.h"
+
+/* Standard C includes.  */
 #include <ctype.h>
+#include <sys/stat.h>
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "ada-lang.h"
+#include "annotate.h"
+#include "arch-utils.h"
+#include "block.h"
+#include "breakpoint.h"
+#include "c-lang.h"
+#include "cli/cli-utils.h"
+#include "common/byte-vector.h"
+#include "common/function-view.h"
+#include "common/gdb_vecs.h"
+#include "common/vec.h"
+#include "completer.h"
 #include "demangle.h"
-#include "gdb_regex.h"
+#include "dictionary.h"
+#include "expression.h"
 #include "frame.h"
-#include "symtab.h"
-#include "gdbtypes.h"
+#include "gdb_obstack.h"
+#include "gdb_regex.h"
 #include "gdbcmd.h"
-#include "expression.h"
-#include "parser-defs.h"
-#include "language.h"
-#include "varobj.h"
-#include "c-lang.h"
-#include "inferior.h"
-#include "symfile.h"
-#include "objfiles.h"
-#include "breakpoint.h"
 #include "gdbcore.h"
+#include "gdbtypes.h"
 #include "hashtab.h"
-#include "gdb_obstack.h"
-#include "ada-lang.h"
-#include "completer.h"
-#include <sys/stat.h>
-#include "ui-out.h"
-#include "block.h"
 #include "infcall.h"
-#include "dictionary.h"
-#include "annotate.h"
-#include "valprint.h"
-#include "source.h"
+#include "inferior.h"
+#include "language.h"
+#include "mi/mi-common.h"
+#include "namespace.h"
+#include "objfiles.h"
 #include "observable.h"
-#include "common/vec.h"
+#include "parser-defs.h"
+#include "psymtab.h"
+#include "source.h"
 #include "stack.h"
-#include "common/gdb_vecs.h"
+#include "symfile.h"
+#include "symtab.h"
 #include "typeprint.h"
-#include "namespace.h"
-
-#include "psymtab.h"
+#include "ui-out.h"
+#include "valprint.h"
 #include "value.h"
-#include "mi/mi-common.h"
-#include "arch-utils.h"
-#include "cli/cli-utils.h"
-#include "common/function-view.h"
-#include "common/byte-vector.h"
-#include <algorithm>
+#include "varobj.h"
 
 /* Define whether or not the C operator '/' truncates towards zero for
    differently signed operands (truncation direction is undefined in C).
diff --git a/gdb/ada-tasks.c b/gdb/ada-tasks.c
index ccabc631040..b143c67aa7c 100644
--- a/gdb/ada-tasks.c
+++ b/gdb/ada-tasks.c
@@ -16,15 +16,17 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "observable.h"
-#include "gdbcmd.h"
-#include "target.h"
+
+/* Local non-gdb includes.  */
 #include "ada-lang.h"
+#include "gdbcmd.h"
 #include "gdbcore.h"
-#include "inferior.h"
 #include "gdbthread.h"
-#include "progspace.h"
+#include "inferior.h"
 #include "objfiles.h"
+#include "observable.h"
+#include "progspace.h"
+#include "target.h"
 
 static int ada_build_task_list ();
 
diff --git a/gdb/ada-typeprint.c b/gdb/ada-typeprint.c
index efcd14bedc5..4502b81a741 100644
--- a/gdb/ada-typeprint.c
+++ b/gdb/ada-typeprint.c
@@ -17,24 +17,28 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdb_obstack.h"
-#include "bfd.h"		/* Binary File Description */
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "expression.h"
-#include "value.h"
-#include "gdbcore.h"
-#include "target.h"
+
+/* Standard C includes.  */
+#include <ctype.h>
+
+/* Local non-gdb includes.  */
+#include "ada-lang.h"
+#include "bfd.h"
+#include "c-lang.h"
+#include "cli/cli-style.h"
 #include "command.h"
+#include "demangle.h"
+#include "expression.h"
+#include "gdb_obstack.h"
 #include "gdbcmd.h"
+#include "gdbcore.h"
+#include "gdbtypes.h"
 #include "language.h"
-#include "demangle.h"
-#include "c-lang.h"
-#include "cli/cli-style.h"
-#include "typeprint.h"
+#include "symtab.h"
 #include "target-float.h"
-#include "ada-lang.h"
-#include <ctype.h>
+#include "target.h"
+#include "typeprint.h"
+#include "value.h"
 
 static int print_selected_record_field_types (struct type *, struct type *,
 					      int, int,
diff --git a/gdb/ada-valprint.c b/gdb/ada-valprint.c
index d4661e1f1d4..3fa7d909817 100644
--- a/gdb/ada-valprint.c
+++ b/gdb/ada-valprint.c
@@ -18,20 +18,24 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Standard C includes.  */
 #include <ctype.h>
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "expression.h"
-#include "value.h"
-#include "demangle.h"
-#include "valprint.h"
-#include "language.h"
-#include "annotate.h"
+
+/* Local non-gdb includes.  */
 #include "ada-lang.h"
+#include "annotate.h"
 #include "c-lang.h"
+#include "demangle.h"
+#include "expression.h"
+#include "gdbtypes.h"
 #include "infcall.h"
+#include "language.h"
 #include "objfiles.h"
+#include "symtab.h"
 #include "target-float.h"
+#include "valprint.h"
+#include "value.h"
 
 static int print_field_values (struct type *, const gdb_byte *,
 			       int,
diff --git a/gdb/ada-varobj.c b/gdb/ada-varobj.c
index a4d553d3786..3f375c8f04a 100644
--- a/gdb/ada-varobj.c
+++ b/gdb/ada-varobj.c
@@ -18,10 +18,12 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "ada-lang.h"
-#include "varobj.h"
 #include "language.h"
 #include "valprint.h"
+#include "varobj.h"
 
 /* Implementation principle used in this unit:
 
diff --git a/gdb/addrmap.c b/gdb/addrmap.c
index 6c3ed6945fb..d49076b5ae7 100644
--- a/gdb/addrmap.c
+++ b/gdb/addrmap.c
@@ -18,9 +18,11 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "splay-tree.h"
-#include "gdb_obstack.h"
+
+/* Local non-gdb includes.  */
 #include "addrmap.h"
+#include "gdb_obstack.h"
+#include "splay-tree.h"
 
 
 /* The "abstract class".  */
diff --git a/gdb/agent.c b/gdb/agent.c
index 8b777d0b3b7..aa3e0df7780 100644
--- a/gdb/agent.c
+++ b/gdb/agent.c
@@ -16,10 +16,12 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "command.h"
+#include "common/agent.h"
 #include "gdbcmd.h"
 #include "target.h"
-#include "common/agent.h"
 
 /* Enum strings for "set|show agent".  */
 
diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
index ffa3352d039..7646a3da6ce 100644
--- a/gdb/aix-thread.c
+++ b/gdb/aix-thread.c
@@ -40,21 +40,24 @@
      */
 
 #include "defs.h"
-#include "gdbthread.h"
-#include "target.h"
-#include "inferior.h"
-#include "regcache.h"
-#include "gdbcmd.h"
-#include "ppc-tdep.h"
-#include "observable.h"
-#include "objfiles.h"
 
+/* Standard C includes.  */
 #include <procinfo.h>
-#include <sys/types.h>
-#include <sys/ptrace.h>
-#include <sys/reg.h>
 #include <sched.h>
 #include <sys/pthdebug.h>
+#include <sys/ptrace.h>
+#include <sys/reg.h>
+#include <sys/types.h>
+
+/* Local non-gdb includes.  */
+#include "gdbcmd.h"
+#include "gdbthread.h"
+#include "inferior.h"
+#include "objfiles.h"
+#include "observable.h"
+#include "ppc-tdep.h"
+#include "regcache.h"
+#include "target.h"
 
 #if !HAVE_DECL_GETTHRDS
 extern int getthrds (pid_t, struct thrdsinfo64 *, int, tid_t *, int);
diff --git a/gdb/alpha-bsd-nat.c b/gdb/alpha-bsd-nat.c
index b12d19f3434..d51660458b9 100644
--- a/gdb/alpha-bsd-nat.c
+++ b/gdb/alpha-bsd-nat.c
@@ -18,20 +18,21 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "inferior.h"
-#include "regcache.h"
 
-#include "alpha-tdep.h"
-#include "alpha-bsd-tdep.h"
-#include "inf-ptrace.h"
-
-#include <sys/types.h>
-#include <sys/ptrace.h>
+/* Standard C includes.  */
 #include <machine/reg.h>
-
 #ifdef HAVE_SYS_PROCFS_H
 #include <sys/procfs.h>
 #endif
+#include <sys/ptrace.h>
+#include <sys/types.h>
+
+/* Local non-gdb includes.  */
+#include "alpha-bsd-tdep.h"
+#include "alpha-tdep.h"
+#include "inf-ptrace.h"
+#include "inferior.h"
+#include "regcache.h"
 
 #ifndef HAVE_GREGSET_T
 typedef struct reg gregset_t;
diff --git a/gdb/alpha-bsd-tdep.c b/gdb/alpha-bsd-tdep.c
index 350c197b0e1..a032f95adff 100644
--- a/gdb/alpha-bsd-tdep.c
+++ b/gdb/alpha-bsd-tdep.c
@@ -18,10 +18,11 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "regcache.h"
 
-#include "alpha-tdep.h"
+/* Local non-gdb includes.  */
 #include "alpha-bsd-tdep.h"
+#include "alpha-tdep.h"
+#include "regcache.h"
 
 /* Conviently, GDB uses the same register numbering as the
    ptrace register structure used by BSD on Alpha.  */
diff --git a/gdb/alpha-linux-nat.c b/gdb/alpha-linux-nat.c
index 18806971a76..91f5b4c6fb0 100644
--- a/gdb/alpha-linux-nat.c
+++ b/gdb/alpha-linux-nat.c
@@ -17,17 +17,18 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "target.h"
-#include "regcache.h"
-#include "linux-nat-trad.h"
 
-#include "alpha-tdep.h"
-
-#include "nat/gdb_ptrace.h"
+/* Standard C includes.  */
 #include <alpha/ptrace.h>
-
 #include <sys/procfs.h>
+
+/* Local non-gdb includes.  */
+#include "alpha-tdep.h"
 #include "gregset.h"
+#include "linux-nat-trad.h"
+#include "nat/gdb_ptrace.h"
+#include "regcache.h"
+#include "target.h"
 
 /* The address of UNIQUE for ptrace.  */
 #define ALPHA_UNIQUE_PTRACE_ADDR 65
diff --git a/gdb/alpha-linux-tdep.c b/gdb/alpha-linux-tdep.c
index bfa611e646f..fbfd6b3f8d5 100644
--- a/gdb/alpha-linux-tdep.c
+++ b/gdb/alpha-linux-tdep.c
@@ -17,14 +17,16 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "alpha-tdep.h"
 #include "frame.h"
+#include "linux-tdep.h"
 #include "osabi.h"
+#include "regcache.h"
+#include "regset.h"
 #include "solib-svr4.h"
 #include "symtab.h"
-#include "regset.h"
-#include "regcache.h"
-#include "linux-tdep.h"
-#include "alpha-tdep.h"
 
 /* This enum represents the signals' numbers on the Alpha
    architecture.  It just contains the signal definitions which are
diff --git a/gdb/alpha-mdebug-tdep.c b/gdb/alpha-mdebug-tdep.c
index caab08b1220..590aa8e5772 100644
--- a/gdb/alpha-mdebug-tdep.c
+++ b/gdb/alpha-mdebug-tdep.c
@@ -17,16 +17,17 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "frame.h"
-#include "frame-unwind.h"
-#include "frame-base.h"
-#include "symtab.h"
-#include "gdbcore.h"
-#include "block.h"
-#include "trad-frame.h"
 
+/* Local non-gdb includes.  */
 #include "alpha-tdep.h"
+#include "block.h"
+#include "frame-base.h"
+#include "frame-unwind.h"
+#include "frame.h"
+#include "gdbcore.h"
 #include "mdebugread.h"
+#include "symtab.h"
+#include "trad-frame.h"
 
 /* FIXME: Some of this code should perhaps be merged with mips.  */
 
diff --git a/gdb/alpha-nbsd-tdep.c b/gdb/alpha-nbsd-tdep.c
index 534b64687e3..1922fec9c13 100644
--- a/gdb/alpha-nbsd-tdep.c
+++ b/gdb/alpha-nbsd-tdep.c
@@ -20,18 +20,19 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "alpha-bsd-tdep.h"
+#include "alpha-tdep.h"
 #include "frame.h"
 #include "gdbcore.h"
+#include "nbsd-tdep.h"
 #include "osabi.h"
 #include "regcache.h"
 #include "regset.h"
-#include "value.h"
-
-#include "alpha-tdep.h"
-#include "alpha-bsd-tdep.h"
-#include "nbsd-tdep.h"
 #include "solib-svr4.h"
 #include "target.h"
+#include "value.h"
 
 /* Core file support.  */
 
diff --git a/gdb/alpha-obsd-tdep.c b/gdb/alpha-obsd-tdep.c
index d7e292603af..0e6450f7e8f 100644
--- a/gdb/alpha-obsd-tdep.c
+++ b/gdb/alpha-obsd-tdep.c
@@ -18,13 +18,14 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "alpha-bsd-tdep.h"
+#include "alpha-tdep.h"
 #include "frame.h"
 #include "gdbcore.h"
-#include "osabi.h"
-
 #include "obsd-tdep.h"
-#include "alpha-tdep.h"
-#include "alpha-bsd-tdep.h"
+#include "osabi.h"
 #include "solib-svr4.h"
 
 /* Signal trampolines.  */
diff --git a/gdb/alpha-tdep.c b/gdb/alpha-tdep.c
index af9b9b97407..b47b0f0928d 100644
--- a/gdb/alpha-tdep.c
+++ b/gdb/alpha-tdep.c
@@ -18,31 +18,33 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "frame.h"
-#include "frame-unwind.h"
-#include "frame-base.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "alpha-tdep.h"
+#include "arch-utils.h"
+#include "block.h"
+#include "dis-asm.h"
 #include "dwarf2-frame.h"
-#include "inferior.h"
-#include "symtab.h"
-#include "value.h"
+#include "elf-bfd.h"
+#include "frame-base.h"
+#include "frame-unwind.h"
+#include "frame.h"
 #include "gdbcmd.h"
 #include "gdbcore.h"
-#include "dis-asm.h"
-#include "symfile.h"
-#include "objfiles.h"
+#include "infcall.h"
+#include "inferior.h"
 #include "linespec.h"
+#include "objfiles.h"
+#include "osabi.h"
 #include "regcache.h"
 #include "reggroups.h"
-#include "arch-utils.h"
-#include "osabi.h"
-#include "block.h"
-#include "infcall.h"
+#include "symfile.h"
+#include "symtab.h"
 #include "trad-frame.h"
-
-#include "elf-bfd.h"
-
-#include "alpha-tdep.h"
-#include <algorithm>
+#include "value.h"
 
 /* Instruction decoding.  The notations for registers, immediates and
    opcodes are the same as the one used in Compaq's Alpha architecture
diff --git a/gdb/amd64-bsd-nat.c b/gdb/amd64-bsd-nat.c
index 35763a5b955..07ddb86c155 100644
--- a/gdb/amd64-bsd-nat.c
+++ b/gdb/amd64-bsd-nat.c
@@ -18,6 +18,8 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "inferior.h"
 #include "regcache.h"
 #include "target.h"
diff --git a/gdb/amd64-darwin-tdep.c b/gdb/amd64-darwin-tdep.c
index 46867f40a38..5d21ba755d8 100644
--- a/gdb/amd64-darwin-tdep.c
+++ b/gdb/amd64-darwin-tdep.c
@@ -19,24 +19,25 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "amd64-darwin-tdep.h"
+#include "amd64-tdep.h"
+#include "common/x86-xstate.h"
+#include "dwarf2-frame.h"
 #include "frame.h"
-#include "inferior.h"
 #include "gdbcore.h"
-#include "target.h"
-#include "symtab.h"
-#include "regcache.h"
-#include "objfiles.h"
-
+#include "i386-darwin-tdep.h"
 #include "i387-tdep.h"
-#include "common/x86-xstate.h"
-#include "amd64-tdep.h"
+#include "inferior.h"
+#include "objfiles.h"
 #include "osabi.h"
-#include "ui-out.h"
-#include "amd64-darwin-tdep.h"
-#include "i386-darwin-tdep.h"
-#include "solib.h"
+#include "regcache.h"
 #include "solib-darwin.h"
-#include "dwarf2-frame.h"
+#include "solib.h"
+#include "symtab.h"
+#include "target.h"
+#include "ui-out.h"
 
 /* Offsets into the struct x86_thread_state64 where we'll find the saved regs.
    From <mach/i386/thread_status.h> and amd64-tdep.h.  */
diff --git a/gdb/amd64-dicos-tdep.c b/gdb/amd64-dicos-tdep.c
index 8ca838e3c83..4dbb20104c5 100644
--- a/gdb/amd64-dicos-tdep.c
+++ b/gdb/amd64-dicos-tdep.c
@@ -18,10 +18,12 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "osabi.h"
+
+/* Local non-gdb includes.  */
 #include "amd64-tdep.h"
 #include "common/x86-xstate.h"
 #include "dicos-tdep.h"
+#include "osabi.h"
 
 static void
 amd64_dicos_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
diff --git a/gdb/amd64-fbsd-nat.c b/gdb/amd64-fbsd-nat.c
index cc676d3214f..4e5291082a2 100644
--- a/gdb/amd64-fbsd-nat.c
+++ b/gdb/amd64-fbsd-nat.c
@@ -18,23 +18,26 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "inferior.h"
-#include "regcache.h"
-#include "target.h"
 
+/* Standard C includes.  */
+#include <machine/reg.h>
 #include <signal.h>
-#include <sys/types.h>
 #include <sys/ptrace.h>
 #include <sys/sysctl.h>
+#include <sys/types.h>
 #include <sys/user.h>
-#include <machine/reg.h>
 
-#include "fbsd-nat.h"
-#include "amd64-tdep.h"
-#include "amd64-nat.h"
+/* Local non-gdb includes.  */
 #include "amd64-bsd-nat.h"
-#include "x86-nat.h"
+#include "amd64-nat.h"
+#include "amd64-tdep.h"
 #include "common/x86-xstate.h"
+#include "fbsd-nat.h"
+#include "inferior.h"
+#include "regcache.h"
+#include "target.h"
+#include "x86-nat.h"
+
 
 
 class amd64_fbsd_nat_target final
diff --git a/gdb/amd64-fbsd-tdep.c b/gdb/amd64-fbsd-tdep.c
index 7e2e9edf21d..9c5ff301ef3 100644
--- a/gdb/amd64-fbsd-tdep.c
+++ b/gdb/amd64-fbsd-tdep.c
@@ -18,17 +18,18 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "amd64-tdep.h"
 #include "arch-utils.h"
+#include "common/x86-xstate.h"
+#include "fbsd-tdep.h"
 #include "frame.h"
 #include "gdbcore.h"
-#include "regcache.h"
+#include "i386-fbsd-tdep.h"
 #include "osabi.h"
+#include "regcache.h"
 #include "regset.h"
-#include "i386-fbsd-tdep.h"
-#include "common/x86-xstate.h"
-
-#include "amd64-tdep.h"
-#include "fbsd-tdep.h"
 #include "solib-svr4.h"
 
 /* Support for signal handlers.  */
diff --git a/gdb/amd64-linux-nat.c b/gdb/amd64-linux-nat.c
index a0bb105f5aa..853c73c1530 100644
--- a/gdb/amd64-linux-nat.c
+++ b/gdb/amd64-linux-nat.c
@@ -19,25 +19,27 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "inferior.h"
-#include "regcache.h"
-#include "elf/common.h"
-#include <sys/uio.h>
-#include "nat/gdb_ptrace.h"
+
+/* Standard C includes.  */
 #include <asm/prctl.h>
 #include <sys/reg.h>
-#include "gregset.h"
-#include "gdb_proc_service.h"
+#include <sys/uio.h>
 
+/* Local non-gdb includes.  */
+#include "amd64-linux-tdep.h"
 #include "amd64-nat.h"
 #include "amd64-tdep.h"
-#include "amd64-linux-tdep.h"
-#include "i386-linux-tdep.h"
 #include "common/x86-xstate.h"
-
-#include "x86-linux-nat.h"
-#include "nat/linux-ptrace.h"
+#include "elf/common.h"
+#include "gdb_proc_service.h"
+#include "gregset.h"
+#include "i386-linux-tdep.h"
+#include "inferior.h"
 #include "nat/amd64-linux-siginfo.h"
+#include "nat/gdb_ptrace.h"
+#include "nat/linux-ptrace.h"
+#include "regcache.h"
+#include "x86-linux-nat.h"
 
 /* This definition comes from prctl.h.  Kernels older than 2.5.64
    do not have it.  */
diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
index 5475cf629f3..8d27225b4ad 100644
--- a/gdb/amd64-linux-tdep.c
+++ b/gdb/amd64-linux-tdep.c
@@ -19,28 +19,29 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "amd64-linux-tdep.h"
+#include "amd64-tdep.h"
 #include "arch-utils.h"
+#include "arch/amd64.h"
+#include "common/x86-xstate.h"
 #include "frame.h"
 #include "gdbcore.h"
-#include "regcache.h"
-#include "osabi.h"
-#include "symtab.h"
 #include "gdbtypes.h"
-#include "reggroups.h"
-#include "regset.h"
-#include "parser-defs.h"
-#include "user-regs.h"
-#include "amd64-linux-tdep.h"
+#include "glibc-tdep.h"
 #include "i386-linux-tdep.h"
 #include "linux-tdep.h"
-#include "common/x86-xstate.h"
-
-#include "amd64-tdep.h"
+#include "osabi.h"
+#include "parser-defs.h"
+#include "regcache.h"
+#include "reggroups.h"
+#include "regset.h"
 #include "solib-svr4.h"
-#include "xml-syscall.h"
-#include "glibc-tdep.h"
-#include "arch/amd64.h"
+#include "symtab.h"
 #include "target-descriptions.h"
+#include "user-regs.h"
+#include "xml-syscall.h"
 
 /* The syscall's XML filename for i386.  */
 #define XML_SYSCALL_FILENAME_AMD64 "syscalls/amd64-linux.xml"
diff --git a/gdb/amd64-nat.c b/gdb/amd64-nat.c
index 3dcac73d88a..1c02d35f2d7 100644
--- a/gdb/amd64-nat.c
+++ b/gdb/amd64-nat.c
@@ -18,12 +18,13 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdbarch.h"
-#include "regcache.h"
 
-#include "i386-tdep.h"
-#include "amd64-tdep.h"
+/* Local non-gdb includes.  */
 #include "amd64-nat.h"
+#include "amd64-tdep.h"
+#include "gdbarch.h"
+#include "i386-tdep.h"
+#include "regcache.h"
 
 /* The following bits of code help with implementing debugging 32-bit
    code natively on AMD64.  The idea is to define two mappings between
diff --git a/gdb/amd64-nbsd-nat.c b/gdb/amd64-nbsd-nat.c
index 24e3aae7ecb..3a610cbbf71 100644
--- a/gdb/amd64-nbsd-nat.c
+++ b/gdb/amd64-nbsd-nat.c
@@ -18,12 +18,13 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "target.h"
 
-#include "nbsd-nat.h"
-#include "amd64-tdep.h"
+/* Local non-gdb includes.  */
 #include "amd64-bsd-nat.h"
 #include "amd64-nat.h"
+#include "amd64-tdep.h"
+#include "nbsd-nat.h"
+#include "target.h"
 
 /* Mapping between the general-purpose registers in NetBSD/amd64
    `struct reg' format and GDB's register cache layout for
diff --git a/gdb/amd64-nbsd-tdep.c b/gdb/amd64-nbsd-tdep.c
index 06905d65dfd..99b17220545 100644
--- a/gdb/amd64-nbsd-tdep.c
+++ b/gdb/amd64-nbsd-tdep.c
@@ -18,16 +18,17 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "arch-utils.h"
-#include "frame.h"
-#include "gdbcore.h"
-#include "osabi.h"
-#include "symtab.h"
 
+/* Local non-gdb includes.  */
 #include "amd64-tdep.h"
+#include "arch-utils.h"
 #include "common/x86-xstate.h"
+#include "frame.h"
+#include "gdbcore.h"
 #include "nbsd-tdep.h"
+#include "osabi.h"
 #include "solib-svr4.h"
+#include "symtab.h"
 
 /* Support for signal handlers.  */
 
diff --git a/gdb/amd64-obsd-nat.c b/gdb/amd64-obsd-nat.c
index 4963c42d06c..cf6694e99c2 100644
--- a/gdb/amd64-obsd-nat.c
+++ b/gdb/amd64-obsd-nat.c
@@ -18,14 +18,15 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdbcore.h"
-#include "regcache.h"
-#include "target.h"
 
-#include "amd64-tdep.h"
+/* Local non-gdb includes.  */
 #include "amd64-bsd-nat.h"
 #include "amd64-nat.h"
+#include "amd64-tdep.h"
+#include "gdbcore.h"
 #include "obsd-nat.h"
+#include "regcache.h"
+#include "target.h"
 
 /* Mapping between the general-purpose registers in OpenBSD/amd64
    `struct reg' format and GDB's register cache layout for
diff --git a/gdb/amd64-obsd-tdep.c b/gdb/amd64-obsd-tdep.c
index cd1a1c31b88..71a263f1455 100644
--- a/gdb/amd64-obsd-tdep.c
+++ b/gdb/amd64-obsd-tdep.c
@@ -18,24 +18,25 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "frame.h"
+
+/* Local non-gdb includes.  */
+#include "amd64-tdep.h"
+#include "bsd-uthread.h"
+#include "common/x86-xstate.h"
 #include "frame-unwind.h"
+#include "frame.h"
 #include "gdbcore.h"
-#include "symtab.h"
+#include "i387-tdep.h"
 #include "objfiles.h"
+#include "obsd-tdep.h"
 #include "osabi.h"
 #include "regcache.h"
 #include "regset.h"
+#include "solib-svr4.h"
+#include "symtab.h"
 #include "target.h"
 #include "trad-frame.h"
 
-#include "obsd-tdep.h"
-#include "amd64-tdep.h"
-#include "i387-tdep.h"
-#include "common/x86-xstate.h"
-#include "solib-svr4.h"
-#include "bsd-uthread.h"
-
 /* Support for signal handlers.  */
 
 /* Default page size.  */
diff --git a/gdb/amd64-sol2-tdep.c b/gdb/amd64-sol2-tdep.c
index 56d2e225822..7d691e869dd 100644
--- a/gdb/amd64-sol2-tdep.c
+++ b/gdb/amd64-sol2-tdep.c
@@ -20,16 +20,17 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "amd64-tdep.h"
+#include "common/x86-xstate.h"
 #include "frame.h"
 #include "gdbcore.h"
-#include "regcache.h"
 #include "osabi.h"
-#include "symtab.h"
-
+#include "regcache.h"
 #include "sol2-tdep.h"
-#include "amd64-tdep.h"
-#include "common/x86-xstate.h"
 #include "solib-svr4.h"
+#include "symtab.h"
 
 /* Mapping between the general-purpose registers in gregset_t format
    and GDB's register cache layout.  */
diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c
index d5892954d74..16c3e61306b 100644
--- a/gdb/amd64-tdep.c
+++ b/gdb/amd64-tdep.c
@@ -20,34 +20,38 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "opcode/i386.h"
-#include "dis-asm.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "amd64-tdep.h"
 #include "arch-utils.h"
+#include "arch/amd64.h"
+#include "ax-gdb.h"
+#include "ax.h"
 #include "block.h"
+#include "common/byte-vector.h"
+#include "common/x86-xstate.h"
+#include "dis-asm.h"
+#include "disasm.h"
 #include "dummy-frame.h"
-#include "frame.h"
 #include "frame-base.h"
 #include "frame-unwind.h"
-#include "inferior.h"
-#include "infrun.h"
+#include "frame.h"
 #include "gdbcmd.h"
 #include "gdbcore.h"
+#include "i387-tdep.h"
+#include "inferior.h"
+#include "infrun.h"
 #include "objfiles.h"
+#include "opcode/i386.h"
+#include "osabi.h"
+#include "producer.h"
 #include "regcache.h"
 #include "regset.h"
 #include "symfile.h"
-#include "disasm.h"
-#include "amd64-tdep.h"
-#include "i387-tdep.h"
-#include "common/x86-xstate.h"
-#include <algorithm>
 #include "target-descriptions.h"
-#include "arch/amd64.h"
-#include "producer.h"
-#include "ax.h"
-#include "ax-gdb.h"
-#include "common/byte-vector.h"
-#include "osabi.h"
 #include "x86-tdep.h"
 
 /* Note that the AMD64 architecture was previously known as x86-64.
diff --git a/gdb/amd64-windows-nat.c b/gdb/amd64-windows-nat.c
index 378262a56e3..dcefa9fead8 100644
--- a/gdb/amd64-windows-nat.c
+++ b/gdb/amd64-windows-nat.c
@@ -16,12 +16,15 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "windows-nat.h"
-#include "x86-nat.h"
-#include "amd64-tdep.h"
 
+/* Standard C includes.  */
 #include <windows.h>
 
+/* Local non-gdb includes.  */
+#include "amd64-tdep.h"
+#include "windows-nat.h"
+#include "x86-nat.h"
+
 #define context_offset(x) (offsetof (CONTEXT, x))
 static const int mappings[] =
 {
diff --git a/gdb/amd64-windows-tdep.c b/gdb/amd64-windows-tdep.c
index 922da9e48bc..9dfa8e4e9d8 100644
--- a/gdb/amd64-windows-tdep.c
+++ b/gdb/amd64-windows-tdep.c
@@ -16,22 +16,26 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "osabi.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
 #include "amd64-tdep.h"
-#include "common/x86-xstate.h"
-#include "gdbtypes.h"
-#include "gdbcore.h"
-#include "regcache.h"
-#include "windows-tdep.h"
-#include "frame.h"
-#include "objfiles.h"
-#include "frame-unwind.h"
-#include "coff/internal.h"
 #include "coff/i386.h"
+#include "coff/internal.h"
 #include "coff/pe.h"
+#include "common/x86-xstate.h"
+#include "frame-unwind.h"
+#include "frame.h"
+#include "gdbcore.h"
+#include "gdbtypes.h"
 #include "libcoff.h"
+#include "objfiles.h"
+#include "osabi.h"
+#include "regcache.h"
 #include "value.h"
-#include <algorithm>
+#include "windows-tdep.h"
 
 /* The registers used to pass integer arguments during a function call.  */
 static int amd64_windows_dummy_call_integer_regs[] =
diff --git a/gdb/annotate.c b/gdb/annotate.c
index 97cb4c8855d..20df956582d 100644
--- a/gdb/annotate.c
+++ b/gdb/annotate.c
@@ -17,15 +17,18 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "annotate.h"
-#include "value.h"
-#include "target.h"
-#include "gdbtypes.h"
 #include "breakpoint.h"
-#include "observable.h"
+#include "gdbtypes.h"
 #include "inferior.h"
 #include "infrun.h"
+#include "observable.h"
+#include "target.h"
 #include "top.h"
+#include "value.h"
+
 
 
 /* Prototypes for local functions.  */
diff --git a/gdb/annotate.h b/gdb/annotate.h
index 4a9e1b58f28..b55dffeb072 100644
--- a/gdb/annotate.h
+++ b/gdb/annotate.h
@@ -19,8 +19,8 @@
 #ifndef ANNOTATE_H
 #define ANNOTATE_H
 
-#include "symtab.h"
 #include "gdbtypes.h"
+#include "symtab.h"
 
 extern void annotate_breakpoint (int);
 extern void annotate_catchpoint (int);
diff --git a/gdb/arc-newlib-tdep.c b/gdb/arc-newlib-tdep.c
index 5fa4094def8..c91ec3add9d 100644
--- a/gdb/arc-newlib-tdep.c
+++ b/gdb/arc-newlib-tdep.c
@@ -20,8 +20,9 @@
 
 #include "defs.h"
 
-#include "gdbarch.h"
+/* Local non-gdb includes.  */
 #include "arc-tdep.h"
+#include "gdbarch.h"
 #include "osabi.h"
 
 /* Implement the 'init_osabi' method of struct gdb_osabi_handler.  */
diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c
index 009af1190a5..6b899eedd22 100644
--- a/gdb/arc-tdep.c
+++ b/gdb/arc-tdep.c
@@ -20,13 +20,15 @@
 
 /* GDB header files.  */
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "arch-utils.h"
 #include "disasm.h"
 #include "dwarf2-frame.h"
 #include "frame-base.h"
 #include "frame-unwind.h"
-#include "gdbcore.h"
 #include "gdbcmd.h"
+#include "gdbcore.h"
 #include "objfiles.h"
 #include "prologue-value.h"
 #include "trad-frame.h"
diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c
index 52a08daa3b9..ab113bcc0e7 100644
--- a/gdb/arch-utils.c
+++ b/gdb/arch-utils.c
@@ -19,24 +19,22 @@
 
 #include "defs.h"
 
+/* Local non-gdb includes.  */
 #include "arch-utils.h"
+#include "common/version.h"
+#include "dis-asm.h"
+#include "floatformat.h"
 #include "gdbcmd.h"
-#include "inferior.h"		/* enum CALL_DUMMY_LOCATION et al.  */
+#include "gdbcore.h"
+#include "inferior.h"
 #include "infrun.h"
+#include "language.h"
+#include "objfiles.h"
+#include "osabi.h"
 #include "regcache.h"
 #include "sim-regno.h"
-#include "gdbcore.h"
-#include "osabi.h"
-#include "target-descriptions.h"
-#include "objfiles.h"
-#include "language.h"
 #include "symtab.h"
-
-#include "common/version.h"
-
-#include "floatformat.h"
-
-#include "dis-asm.h"
+#include "target-descriptions.h"
 
 int
 default_displaced_step_hw_singlestep (struct gdbarch *gdbarch,
diff --git a/gdb/arm-bsd-tdep.c b/gdb/arm-bsd-tdep.c
index 13894c4b14b..f6900426f1b 100644
--- a/gdb/arm-bsd-tdep.c
+++ b/gdb/arm-bsd-tdep.c
@@ -18,12 +18,13 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "arm-tdep.h"
 #include "osabi.h"
 #include "regcache.h"
 #include "regset.h"
 
-#include "arm-tdep.h"
-
 /* Core file support.  */
 
 /* Sizeof `struct reg' in <machine/reg.h>.  */
diff --git a/gdb/arm-fbsd-nat.c b/gdb/arm-fbsd-nat.c
index f85ecc17c05..f0b07804bb4 100644
--- a/gdb/arm-fbsd-nat.c
+++ b/gdb/arm-fbsd-nat.c
@@ -18,16 +18,18 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "target.h"
 
-#include <sys/types.h>
-#include <sys/ptrace.h>
+/* Standard C includes.  */
 #include <machine/reg.h>
+#include <sys/ptrace.h>
+#include <sys/types.h>
 
-#include "fbsd-nat.h"
-#include "arm-tdep.h"
+/* Local non-gdb includes.  */
 #include "arm-fbsd-tdep.h"
+#include "arm-tdep.h"
+#include "fbsd-nat.h"
 #include "inf-ptrace.h"
+#include "target.h"
 
 struct arm_fbsd_nat_target : public fbsd_nat_target
 {
diff --git a/gdb/arm-fbsd-tdep.c b/gdb/arm-fbsd-tdep.c
index dea3abbdd36..c79873c33e1 100644
--- a/gdb/arm-fbsd-tdep.c
+++ b/gdb/arm-fbsd-tdep.c
@@ -19,10 +19,11 @@
 
 #include "defs.h"
 
-#include "elf/common.h"
-#include "arm-tdep.h"
+/* Local non-gdb includes.  */
 #include "arm-fbsd-tdep.h"
+#include "arm-tdep.h"
 #include "auxv.h"
+#include "elf/common.h"
 #include "fbsd-tdep.h"
 #include "gdbcore.h"
 #include "osabi.h"
diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c
index 52668da9fcf..2c2f6952133 100644
--- a/gdb/arm-linux-nat.c
+++ b/gdb/arm-linux-nat.c
@@ -17,28 +17,29 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "inferior.h"
-#include "gdbcore.h"
-#include "regcache.h"
-#include "target.h"
-#include "linux-nat.h"
-#include "target-descriptions.h"
-#include "auxv.h"
-#include "observable.h"
-#include "gdbthread.h"
-
-#include "arm-tdep.h"
-#include "arm-linux-tdep.h"
-#include "aarch32-linux-nat.h"
 
+/* Standard C includes.  */
 #include <elf/common.h>
+#include <sys/procfs.h>
 #include <sys/user.h>
-#include "nat/gdb_ptrace.h"
 #include <sys/utsname.h>
-#include <sys/procfs.h>
 
-#include "nat/linux-ptrace.h"
+/* Local non-gdb includes.  */
+#include "aarch32-linux-nat.h"
+#include "arm-linux-tdep.h"
+#include "arm-tdep.h"
+#include "auxv.h"
+#include "gdbcore.h"
+#include "gdbthread.h"
+#include "inferior.h"
+#include "linux-nat.h"
 #include "linux-tdep.h"
+#include "nat/gdb_ptrace.h"
+#include "nat/linux-ptrace.h"
+#include "observable.h"
+#include "regcache.h"
+#include "target-descriptions.h"
+#include "target.h"
 
 /* Prototypes for supply_gregset etc.  */
 #include "gregset.h"
diff --git a/gdb/arm-linux-tdep.c b/gdb/arm-linux-tdep.c
index a5ad06434c2..90fadbd5284 100644
--- a/gdb/arm-linux-tdep.c
+++ b/gdb/arm-linux-tdep.c
@@ -18,43 +18,45 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "target.h"
-#include "value.h"
-#include "gdbtypes.h"
-#include "gdbcore.h"
-#include "frame.h"
-#include "regcache.h"
-#include "solib-svr4.h"
-#include "osabi.h"
-#include "regset.h"
-#include "trad-frame.h"
-#include "tramp-frame.h"
-#include "breakpoint.h"
-#include "auxv.h"
-#include "xml-syscall.h"
 
-#include "arch/arm.h"
+/* Standard C includes.  */
+#include <ctype.h>
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
 #include "arch/arm-get-next-pcs.h"
 #include "arch/arm-linux.h"
-#include "arm-tdep.h"
+#include "arch/arm.h"
 #include "arm-linux-tdep.h"
-#include "linux-tdep.h"
+#include "arm-tdep.h"
+#include "auxv.h"
+#include "breakpoint.h"
+#include "cli/cli-utils.h"
+#include "elf/common.h"
+#include "frame.h"
+#include "gdbcore.h"
+#include "gdbthread.h"
+#include "gdbtypes.h"
 #include "glibc-tdep.h"
-#include "arch-utils.h"
 #include "inferior.h"
 #include "infrun.h"
-#include "gdbthread.h"
-#include "symfile.h"
-
-#include "record-full.h"
 #include "linux-record.h"
-
-#include "cli/cli-utils.h"
-#include "stap-probe.h"
+#include "linux-tdep.h"
+#include "osabi.h"
 #include "parser-defs.h"
+#include "record-full.h"
+#include "regcache.h"
+#include "regset.h"
+#include "solib-svr4.h"
+#include "stap-probe.h"
+#include "symfile.h"
+#include "target.h"
+#include "trad-frame.h"
+#include "tramp-frame.h"
 #include "user-regs.h"
-#include <ctype.h>
-#include "elf/common.h"
+#include "value.h"
+#include "xml-syscall.h"
+
 extern int arm_apcs_32;
 
 /* Under ARM GNU/Linux the traditional way of performing a breakpoint
diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c
index 2a83553a3fe..09f4f0f1c47 100644
--- a/gdb/arm-nbsd-nat.c
+++ b/gdb/arm-nbsd-nat.c
@@ -18,17 +18,20 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdbcore.h"
-#include "inferior.h"
-#include "regcache.h"
-#include "target.h"
-#include <sys/types.h>
-#include <sys/ptrace.h>
-#include <machine/reg.h>
+
+/* Standard C includes.  */
 #include <machine/frame.h>
+#include <machine/reg.h>
+#include <sys/ptrace.h>
+#include <sys/types.h>
 
+/* Local non-gdb includes.  */
 #include "arm-tdep.h"
+#include "gdbcore.h"
 #include "inf-ptrace.h"
+#include "inferior.h"
+#include "regcache.h"
+#include "target.h"
 
 class arm_netbsd_nat_target final : public inf_ptrace_target
 {
diff --git a/gdb/arm-nbsd-tdep.c b/gdb/arm-nbsd-tdep.c
index 6b782300920..2a13badbcdd 100644
--- a/gdb/arm-nbsd-tdep.c
+++ b/gdb/arm-nbsd-tdep.c
@@ -18,10 +18,11 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "osabi.h"
 
+/* Local non-gdb includes.  */
 #include "arch/arm.h"
 #include "arm-tdep.h"
+#include "osabi.h"
 #include "solib-svr4.h"
 
 /* Description of the longjmp buffer.  */
diff --git a/gdb/arm-obsd-tdep.c b/gdb/arm-obsd-tdep.c
index a6055ab171d..44d9d993cb6 100644
--- a/gdb/arm-obsd-tdep.c
+++ b/gdb/arm-obsd-tdep.c
@@ -18,13 +18,14 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "osabi.h"
-#include "trad-frame.h"
-#include "tramp-frame.h"
 
-#include "obsd-tdep.h"
+/* Local non-gdb includes.  */
 #include "arm-tdep.h"
+#include "obsd-tdep.h"
+#include "osabi.h"
 #include "solib-svr4.h"
+#include "trad-frame.h"
+#include "tramp-frame.h"
 
 /* Signal trampolines.  */
 
diff --git a/gdb/arm-pikeos-tdep.c b/gdb/arm-pikeos-tdep.c
index 21add740a40..250346f502b 100644
--- a/gdb/arm-pikeos-tdep.c
+++ b/gdb/arm-pikeos-tdep.c
@@ -16,8 +16,10 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "objfiles.h"
+
+/* Local non-gdb includes.  */
 #include "arm-tdep.h"
+#include "objfiles.h"
 #include "osabi.h"
 
 /* The gdbarch_register_osabi handler for ARM PikeOS; it performs
diff --git a/gdb/arm-symbian-tdep.c b/gdb/arm-symbian-tdep.c
index 71521de7a91..e078655506d 100644
--- a/gdb/arm-symbian-tdep.c
+++ b/gdb/arm-symbian-tdep.c
@@ -18,13 +18,15 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "elf-bfd.h"
 #include "frame.h"
 #include "objfiles.h"
 #include "osabi.h"
-#include "solib.h"
 #include "solib-target.h"
+#include "solib.h"
 #include "target.h"
-#include "elf-bfd.h"
 
 /* If PC is in a DLL import stub, return the address of the `real'
    function belonging to the stub.  */
diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 599f785b349..07280cfb1b2 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -19,55 +19,54 @@
 
 #include "defs.h"
 
-#include <ctype.h>		/* XXX for isupper ().  */
+/* Standard C includes.  */
+#include <ctype.h>
 
-#include "frame.h"
-#include "inferior.h"
-#include "infrun.h"
-#include "gdbcmd.h"
-#include "gdbcore.h"
-#include "dis-asm.h"		/* For register styles.  */
-#include "disasm.h"
-#include "regcache.h"
-#include "reggroups.h"
-#include "target-float.h"
-#include "value.h"
-#include "arch-utils.h"
-#include "osabi.h"
-#include "frame-unwind.h"
-#include "frame-base.h"
-#include "trad-frame.h"
-#include "objfiles.h"
-#include "dwarf2-frame.h"
-#include "gdbtypes.h"
-#include "prologue-value.h"
-#include "remote.h"
-#include "target-descriptions.h"
-#include "user-regs.h"
-#include "observable.h"
+/* Standard C++ includes.  */
+#include <algorithm>
 
-#include "arch/arm.h"
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
 #include "arch/arm-get-next-pcs.h"
+#include "arch/arm.h"
 #include "arm-tdep.h"
-#include "gdb/sim-arm.h"
-
-#include "elf-bfd.h"
 #include "coff/internal.h"
-#include "elf/arm.h"
-
 #include "common/vec.h"
-
-#include "record.h"
-#include "record-full.h"
-#include <algorithm>
-
-#include "features/arm/arm-with-m.c"
+#include "dis-asm.h"
+#include "disasm.h"
+#include "dwarf2-frame.h"
+#include "elf-bfd.h"
+#include "elf/arm.h"
+#include "features/arm/arm-with-iwmmxt.c"
 #include "features/arm/arm-with-m-fpa-layout.c"
 #include "features/arm/arm-with-m-vfp-d16.c"
-#include "features/arm/arm-with-iwmmxt.c"
+#include "features/arm/arm-with-m.c"
+#include "features/arm/arm-with-neon.c"
 #include "features/arm/arm-with-vfpv2.c"
 #include "features/arm/arm-with-vfpv3.c"
-#include "features/arm/arm-with-neon.c"
+#include "frame-base.h"
+#include "frame-unwind.h"
+#include "frame.h"
+#include "gdb/sim-arm.h"
+#include "gdbcmd.h"
+#include "gdbcore.h"
+#include "gdbtypes.h"
+#include "inferior.h"
+#include "infrun.h"
+#include "objfiles.h"
+#include "observable.h"
+#include "osabi.h"
+#include "prologue-value.h"
+#include "record-full.h"
+#include "record.h"
+#include "regcache.h"
+#include "reggroups.h"
+#include "remote.h"
+#include "target-descriptions.h"
+#include "target-float.h"
+#include "trad-frame.h"
+#include "user-regs.h"
+#include "value.h"
 
 #if GDB_SELF_TEST
 #include "common/selftest.h"
diff --git a/gdb/arm-wince-tdep.c b/gdb/arm-wince-tdep.c
index 6eae60e8a7f..0ca6c813ae2 100644
--- a/gdb/arm-wince-tdep.c
+++ b/gdb/arm-wince-tdep.c
@@ -19,13 +19,14 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "osabi.h"
-#include "gdbcore.h"
-#include "target.h"
-#include "frame.h"
 
+/* Local non-gdb includes.  */
 #include "arch/arm.h"
 #include "arm-tdep.h"
+#include "frame.h"
+#include "gdbcore.h"
+#include "osabi.h"
+#include "target.h"
 #include "windows-tdep.h"
 
 static const gdb_byte arm_wince_le_breakpoint[] = { 0x10, 0x00, 0x00, 0xe6 };
diff --git a/gdb/auto-load.c b/gdb/auto-load.c
index ae7a189dc04..fd40cbb2de2 100644
--- a/gdb/auto-load.c
+++ b/gdb/auto-load.c
@@ -18,29 +18,35 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Standard C includes.  */
 #include <ctype.h>
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
 #include "auto-load.h"
-#include "progspace.h"
-#include "gdb_regex.h"
-#include "ui-out.h"
-#include "filenames.h"
-#include "command.h"
-#include "observable.h"
-#include "objfiles.h"
-#include "cli/cli-script.h"
-#include "gdbcmd.h"
 #include "cli/cli-cmds.h"
 #include "cli/cli-decode.h"
+#include "cli/cli-script.h"
 #include "cli/cli-setshow.h"
-#include "readline/tilde.h"
-#include "completer.h"
-#include "fnmatch.h"
-#include "top.h"
+#include "command.h"
 #include "common/filestuff.h"
+#include "common/pathstuff.h"
+#include "completer.h"
 #include "extension.h"
+#include "filenames.h"
+#include "fnmatch.h"
 #include "gdb/section-scripts.h"
-#include <algorithm>
-#include "common/pathstuff.h"
+#include "gdb_regex.h"
+#include "gdbcmd.h"
+#include "objfiles.h"
+#include "observable.h"
+#include "progspace.h"
+#include "readline/tilde.h"
+#include "top.h"
+#include "ui-out.h"
 
 /* The section to look in for auto-loaded scripts (in file formats that
    support sections).
diff --git a/gdb/auxv.c b/gdb/auxv.c
index 13caa936651..e654abd3b3f 100644
--- a/gdb/auxv.c
+++ b/gdb/auxv.c
@@ -18,21 +18,23 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "target.h"
-#include "gdbtypes.h"
-#include "command.h"
-#include "inferior.h"
-#include "valprint.h"
-#include "gdbcore.h"
-#include "observable.h"
-#include "common/filestuff.h"
-#include "objfiles.h"
 
+/* Standard C includes.  */
+#include <fcntl.h>
+#include <unistd.h>
+
+/* Local non-gdb includes.  */
 #include "auxv.h"
+#include "command.h"
+#include "common/filestuff.h"
 #include "elf/common.h"
-
-#include <unistd.h>
-#include <fcntl.h>
+#include "gdbcore.h"
+#include "gdbtypes.h"
+#include "inferior.h"
+#include "objfiles.h"
+#include "observable.h"
+#include "target.h"
+#include "valprint.h"
 
 
 /* Implement the to_xfer_partial target_ops method.  This function
diff --git a/gdb/avr-tdep.c b/gdb/avr-tdep.c
index 6d11ee1618c..64be41ad35f 100644
--- a/gdb/avr-tdep.c
+++ b/gdb/avr-tdep.c
@@ -23,20 +23,24 @@
    by Denis Chertykov, denisc@overta.ru */
 
 #include "defs.h"
-#include "frame.h"
-#include "frame-unwind.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
+#include "dis-asm.h"
 #include "frame-base.h"
-#include "trad-frame.h"
+#include "frame-unwind.h"
+#include "frame.h"
 #include "gdbcmd.h"
 #include "gdbcore.h"
 #include "gdbtypes.h"
 #include "inferior.h"
-#include "symfile.h"
-#include "arch-utils.h"
-#include "regcache.h"
-#include "dis-asm.h"
 #include "objfiles.h"
-#include <algorithm>
+#include "regcache.h"
+#include "symfile.h"
+#include "trad-frame.h"
 
 /* AVR Background:
 
diff --git a/gdb/ax-gdb.c b/gdb/ax-gdb.c
index 778e89515b6..0783ab1fb9f 100644
--- a/gdb/ax-gdb.c
+++ b/gdb/ax-gdb.c
@@ -18,35 +18,36 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "symfile.h"
-#include "gdbtypes.h"
-#include "language.h"
-#include "value.h"
-#include "expression.h"
-#include "command.h"
-#include "gdbcmd.h"
-#include "frame.h"
-#include "target.h"
-#include "ax.h"
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
 #include "ax-gdb.h"
+#include "ax.h"
 #include "block.h"
-#include "regcache.h"
-#include "user-regs.h"
-#include "dictionary.h"
 #include "breakpoint.h"
-#include "tracepoint.h"
-#include "cp-support.h"
-#include "arch-utils.h"
+#include "c-lang.h"
 #include "cli/cli-utils.h"
+#include "command.h"
+#include "common/format.h"
+#include "cp-support.h"
+#include "dictionary.h"
+#include "expression.h"
+#include "frame.h"
+#include "gdbcmd.h"
+#include "gdbtypes.h"
+#include "language.h"
 #include "linespec.h"
 #include "location.h"
 #include "objfiles.h"
+#include "regcache.h"
+#include "symfile.h"
+#include "symtab.h"
+#include "target.h"
+#include "tracepoint.h"
 #include "typeprint.h"
+#include "user-regs.h"
 #include "valprint.h"
-#include "c-lang.h"
-
-#include "common/format.h"
+#include "value.h"
 
 /* To make sense of this file, you should read doc/agentexpr.texi.
    Then look at the types and enums in ax-gdb.h.  For the code itself,
diff --git a/gdb/ax-gdb.h b/gdb/ax-gdb.h
index 4420b654d88..49ea26ec466 100644
--- a/gdb/ax-gdb.h
+++ b/gdb/ax-gdb.h
@@ -19,7 +19,7 @@
 #ifndef AX_GDB_H
 #define AX_GDB_H
 
-#include "ax.h"  /* For agent_expr_up.  */
+#include "ax.h"
 
 struct expression;
 union exp_element;
diff --git a/gdb/ax-general.c b/gdb/ax-general.c
index f956dfc2f53..c8499324f46 100644
--- a/gdb/ax-general.c
+++ b/gdb/ax-general.c
@@ -22,10 +22,11 @@
    outside of GDB (test suites, the stub, etc.)  */
 
 #include "defs.h"
-#include "ax.h"
 
-#include "value.h"
+/* Local non-gdb includes.  */
+#include "ax.h"
 #include "user-regs.h"
+#include "value.h"
 
 static void grow_expr (struct agent_expr *x, int n);
 
diff --git a/gdb/bcache.c b/gdb/bcache.c
index 14a78474962..37ca7c455a8 100644
--- a/gdb/bcache.c
+++ b/gdb/bcache.c
@@ -20,8 +20,10 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdb_obstack.h"
+
+/* Local non-gdb includes.  */
 #include "bcache.h"
+#include "gdb_obstack.h"
 
 /* The type used to hold a single bcache string.  The user data is
    stored in d.data.  Since it can be any type, it needs to have the
diff --git a/gdb/bfd-target.c b/gdb/bfd-target.c
index ffe85ae3e0e..15a9e6039fb 100644
--- a/gdb/bfd-target.c
+++ b/gdb/bfd-target.c
@@ -18,10 +18,12 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "target.h"
+
+/* Local non-gdb includes.  */
 #include "bfd-target.h"
 #include "exec.h"
 #include "gdb_bfd.h"
+#include "target.h"
 
 /* A target that wraps a BFD.  */
 
diff --git a/gdb/bfin-linux-tdep.c b/gdb/bfin-linux-tdep.c
index 3fc6b6a6586..bfdc106fb67 100644
--- a/gdb/bfin-linux-tdep.c
+++ b/gdb/bfin-linux-tdep.c
@@ -20,14 +20,16 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "arch-utils.h"
+#include "bfin-tdep.h"
+#include "linux-tdep.h"
+#include "osabi.h"
 #include "regcache.h"
-#include "tramp-frame.h"
 #include "trad-frame.h"
-#include "osabi.h"
+#include "tramp-frame.h"
 #include "xml-syscall.h"
-#include "linux-tdep.h"
-#include "bfin-tdep.h"
 
 /* From <asm/sigcontext.h>.  */
 
diff --git a/gdb/bfin-tdep.c b/gdb/bfin-tdep.c
index 9d3e8ebce16..830cb1c2fd8 100644
--- a/gdb/bfin-tdep.c
+++ b/gdb/bfin-tdep.c
@@ -20,25 +20,27 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "inferior.h"
-#include "gdbcore.h"
+
+/* Local non-gdb includes.  */
 #include "arch-utils.h"
-#include "regcache.h"
-#include "frame.h"
-#include "frame-unwind.h"
-#include "frame-base.h"
-#include "trad-frame.h"
+#include "bfin-tdep.h"
 #include "dis-asm.h"
-#include "sim-regno.h"
-#include "gdb/sim-bfin.h"
 #include "dwarf2-frame.h"
-#include "symtab.h"
 #include "elf-bfd.h"
 #include "elf/bfin.h"
-#include "osabi.h"
+#include "frame-base.h"
+#include "frame-unwind.h"
+#include "frame.h"
+#include "gdb/sim-bfin.h"
+#include "gdbcore.h"
 #include "infcall.h"
+#include "inferior.h"
+#include "osabi.h"
+#include "regcache.h"
+#include "sim-regno.h"
+#include "symtab.h"
+#include "trad-frame.h"
 #include "xml-syscall.h"
-#include "bfin-tdep.h"
 
 /* Macros used by prologue functions.  */
 #define P_LINKAGE			0xE800
diff --git a/gdb/block.c b/gdb/block.c
index 63c7d9f3955..366141c0333 100644
--- a/gdb/block.c
+++ b/gdb/block.c
@@ -18,14 +18,16 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "addrmap.h"
 #include "block.h"
-#include "symtab.h"
-#include "symfile.h"
-#include "gdb_obstack.h"
 #include "cp-support.h"
-#include "addrmap.h"
+#include "gdb_obstack.h"
 #include "gdbtypes.h"
 #include "objfiles.h"
+#include "symfile.h"
+#include "symtab.h"
 
 /* This is used by struct block to store namespace-related info for
    C++ files, namely using declarations and the current namespace in
diff --git a/gdb/blockframe.c b/gdb/blockframe.c
index fe7807b87a6..8b1acab22f4 100644
--- a/gdb/blockframe.c
+++ b/gdb/blockframe.c
@@ -19,21 +19,23 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
+
+/* Local non-gdb includes.  */
+#include "annotate.h"
 #include "bfd.h"
-#include "objfiles.h"
+#include "block.h"
+#include "command.h"
+#include "dummy-frame.h"
 #include "frame.h"
+#include "gdbcmd.h"
 #include "gdbcore.h"
-#include "value.h"
-#include "target.h"
 #include "inferior.h"
-#include "annotate.h"
-#include "regcache.h"
-#include "dummy-frame.h"
-#include "command.h"
-#include "gdbcmd.h"
-#include "block.h"
 #include "inline-frame.h"
+#include "objfiles.h"
+#include "regcache.h"
+#include "symtab.h"
+#include "target.h"
+#include "value.h"
 
 /* Return the innermost lexical block in execution in a specified
    stack frame.  The frame address is assumed valid.
diff --git a/gdb/break-catch-sig.c b/gdb/break-catch-sig.c
index 53540ee8320..14f901f07c2 100644
--- a/gdb/break-catch-sig.c
+++ b/gdb/break-catch-sig.c
@@ -18,18 +18,23 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "arch-utils.h"
+
+/* Standard C includes.  */
 #include <ctype.h>
+
+/* Standard C++ includes.  */
+#include <string>
+
+/* Local non-gdb includes.  */
+#include "annotate.h"
+#include "arch-utils.h"
 #include "breakpoint.h"
+#include "cli/cli-utils.h"
+#include "completer.h"
 #include "gdbcmd.h"
 #include "inferior.h"
 #include "infrun.h"
-#include "annotate.h"
 #include "valprint.h"
-#include "cli/cli-utils.h"
-#include "completer.h"
-
-#include <string>
 
 #define INTERNAL_SIGNAL(x) ((x) == GDB_SIGNAL_TRAP || (x) == GDB_SIGNAL_INT)
 
diff --git a/gdb/break-catch-syscall.c b/gdb/break-catch-syscall.c
index 6a911fbc2a3..1d02e9b7b3a 100644
--- a/gdb/break-catch-syscall.c
+++ b/gdb/break-catch-syscall.c
@@ -18,16 +18,20 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Standard C includes.  */
 #include <ctype.h>
+
+/* Local non-gdb includes.  */
+#include "annotate.h"
+#include "arch-utils.h"
 #include "breakpoint.h"
+#include "cli/cli-utils.h"
 #include "gdbcmd.h"
 #include "inferior.h"
-#include "cli/cli-utils.h"
-#include "annotate.h"
 #include "mi/mi-common.h"
-#include "valprint.h"
-#include "arch-utils.h"
 #include "observable.h"
+#include "valprint.h"
 #include "xml-syscall.h"
 
 /* An instance of this type is used to represent a syscall catchpoint.
diff --git a/gdb/break-catch-throw.c b/gdb/break-catch-throw.c
index c8d66e0737c..bad882f50fd 100644
--- a/gdb/break-catch-throw.c
+++ b/gdb/break-catch-throw.c
@@ -18,24 +18,28 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "arch-utils.h"
+
+/* Standard C includes.  */
 #include <ctype.h>
-#include "breakpoint.h"
-#include "gdbcmd.h"
-#include "inferior.h"
+
+/* Local non-gdb includes.  */
 #include "annotate.h"
-#include "valprint.h"
+#include "arch-utils.h"
+#include "breakpoint.h"
 #include "cli/cli-utils.h"
 #include "completer.h"
-#include "gdb_obstack.h"
-#include "mi/mi-common.h"
-#include "linespec.h"
-#include "probe.h"
-#include "objfiles.h"
 #include "cp-abi.h"
-#include "gdb_regex.h"
 #include "cp-support.h"
+#include "gdb_obstack.h"
+#include "gdb_regex.h"
+#include "gdbcmd.h"
+#include "inferior.h"
+#include "linespec.h"
 #include "location.h"
+#include "mi/mi-common.h"
+#include "objfiles.h"
+#include "probe.h"
+#include "valprint.h"
 
 /* Enums for exception-handling support.  */
 enum exception_event_kind
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 7799d1c1b48..ed6833565e5 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -18,58 +18,62 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "arch-utils.h"
+
+/* Standard C includes.  */
 #include <ctype.h>
-#include "hashtab.h"
-#include "symtab.h"
-#include "frame.h"
+
+/* Local non-gdb includes.  */
+#include "ada-lang.h"
+#include "annotate.h"
+#include "arch-utils.h"
+#include "ax-gdb.h"
+#include "block.h"
 #include "breakpoint.h"
-#include "tracepoint.h"
-#include "gdbtypes.h"
+#include "cli/cli-script.h"
+#include "cli/cli-style.h"
+#include "cli/cli-utils.h"
+#include "command.h"
+#include "common/format.h"
+#include "completer.h"
+#include "continuations.h"
+#include "dummy-frame.h"
 #include "expression.h"
-#include "gdbcore.h"
+#include "filenames.h"
+#include "frame.h"
+#include "gdb-demangle.h"
+#include "gdb_regex.h"
 #include "gdbcmd.h"
-#include "value.h"
-#include "command.h"
+#include "gdbcore.h"
+#include "gdbthread.h"
+#include "gdbtypes.h"
+#include "hashtab.h"
 #include "inferior.h"
 #include "infrun.h"
-#include "gdbthread.h"
-#include "target.h"
+#include "interps.h"
+#include "jit.h"
 #include "language.h"
-#include "gdb-demangle.h"
-#include "filenames.h"
-#include "annotate.h"
-#include "symfile.h"
-#include "objfiles.h"
-#include "source.h"
 #include "linespec.h"
-#include "completer.h"
-#include "ui-out.h"
-#include "cli/cli-script.h"
-#include "block.h"
-#include "solib.h"
-#include "solist.h"
-#include "observable.h"
 #include "memattr.h"
-#include "ada-lang.h"
-#include "top.h"
-#include "valprint.h"
-#include "jit.h"
+#include "mi/mi-main.h"
+#include "objfiles.h"
+#include "observable.h"
 #include "parser-defs.h"
-#include "gdb_regex.h"
 #include "probe.h"
-#include "cli/cli-utils.h"
-#include "continuations.h"
-#include "stack.h"
 #include "skip.h"
-#include "ax-gdb.h"
-#include "dummy-frame.h"
-#include "interps.h"
-#include "common/format.h"
+#include "solib.h"
+#include "solist.h"
+#include "source.h"
+#include "stack.h"
+#include "symfile.h"
+#include "symtab.h"
+#include "target.h"
 #include "thread-fsm.h"
 #include "tid-parse.h"
-#include "cli/cli-style.h"
-#include "mi/mi-main.h"
+#include "top.h"
+#include "tracepoint.h"
+#include "ui-out.h"
+#include "valprint.h"
+#include "value.h"
 
 /* readline include files */
 #include "readline/readline.h"
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
index a91e3e334cf..3221719b889 100644
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -19,17 +19,19 @@
 #if !defined (BREAKPOINT_H)
 #define BREAKPOINT_H 1
 
-#include "frame.h"
-#include "value.h"
-#include "common/vec.h"
+#include <vector>
+
+/* Local non-gdb includes.  */
 #include "ax.h"
+#include "cli/cli-script.h"
 #include "command.h"
+#include "common/array-view.h"
 #include "common/break-common.h"
-#include "probe.h"
+#include "common/vec.h"
+#include "frame.h"
 #include "location.h"
-#include <vector>
-#include "common/array-view.h"
-#include "cli/cli-script.h"
+#include "probe.h"
+#include "value.h"
 
 struct block;
 struct gdbpy_breakpoint_object;
diff --git a/gdb/bsd-uthread.c b/gdb/bsd-uthread.c
index af048f7a18f..a4cc3c9c4fa 100644
--- a/gdb/bsd-uthread.c
+++ b/gdb/bsd-uthread.c
@@ -18,6 +18,10 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "bsd-uthread.h"
+#include "gdb_obstack.h"
 #include "gdbcore.h"
 #include "gdbthread.h"
 #include "inferior.h"
@@ -29,10 +33,6 @@
 #include "symfile.h"
 #include "target.h"
 
-#include "gdb_obstack.h"
-
-#include "bsd-uthread.h"
-
 static const target_info bsd_uthread_target_info = {
   "bsd-uthreads",
   N_("BSD user-level threads"),
diff --git a/gdb/btrace.c b/gdb/btrace.c
index 12af46814a9..bb8eb26b7a2 100644
--- a/gdb/btrace.c
+++ b/gdb/btrace.c
@@ -20,20 +20,22 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "btrace.h"
+#include "cli/cli-utils.h"
+#include "common/rsp-low.h"
+#include "disasm.h"
+#include "filenames.h"
+#include "gdbcmd.h"
 #include "gdbthread.h"
 #include "inferior.h"
-#include "target.h"
 #include "record.h"
-#include "symtab.h"
-#include "disasm.h"
+#include "regcache.h"
 #include "source.h"
-#include "filenames.h"
+#include "symtab.h"
+#include "target.h"
 #include "xml-support.h"
-#include "regcache.h"
-#include "common/rsp-low.h"
-#include "gdbcmd.h"
-#include "cli/cli-utils.h"
 
 /* For maintenance commands.  */
 #include "record-btrace.h"
diff --git a/gdb/build-id.c b/gdb/build-id.c
index 27f29cd0442..e21ee294a70 100644
--- a/gdb/build-id.c
+++ b/gdb/build-id.c
@@ -18,14 +18,16 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "bfd.h"
-#include "gdb_bfd.h"
 #include "build-id.h"
 #include "common/gdb_vecs.h"
-#include "symfile.h"
-#include "objfiles.h"
 #include "filenames.h"
+#include "gdb_bfd.h"
 #include "gdbcore.h"
+#include "objfiles.h"
+#include "symfile.h"
 
 /* See build-id.h.  */
 
diff --git a/gdb/build-id.h b/gdb/build-id.h
index b8b033e62aa..478410b5954 100644
--- a/gdb/build-id.h
+++ b/gdb/build-id.h
@@ -20,8 +20,8 @@
 #ifndef BUILD_ID_H
 #define BUILD_ID_H
 
-#include "gdb_bfd.h"
 #include "common/rsp-low.h"
+#include "gdb_bfd.h"
 
 /* Locate NT_GNU_BUILD_ID from ABFD and return its content.  */
 
diff --git a/gdb/buildsym-legacy.c b/gdb/buildsym-legacy.c
index a29c1280971..7327db7693e 100644
--- a/gdb/buildsym-legacy.c
+++ b/gdb/buildsym-legacy.c
@@ -17,6 +17,8 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "buildsym-legacy.h"
 
 /* The work-in-progress of the compunit we are building.
diff --git a/gdb/buildsym.c b/gdb/buildsym.c
index 9a23c8f5254..50f0f42e471 100644
--- a/gdb/buildsym.c
+++ b/gdb/buildsym.c
@@ -17,23 +17,27 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "buildsym-legacy.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "addrmap.h"
 #include "bfd.h"
-#include "gdb_obstack.h"
-#include "symtab.h"
-#include "symfile.h"
-#include "objfiles.h"
-#include "gdbtypes.h"
-#include "complaints.h"
-#include "expression.h"		/* For "enum exp_opcode" used by...  */
-#include "filenames.h"		/* For DOSish file names.  */
-#include "macrotab.h"
-#include "demangle.h"		/* Needed by SYMBOL_INIT_DEMANGLED_NAME.  */
 #include "block.h"
+#include "buildsym-legacy.h"
+#include "complaints.h"
 #include "cp-support.h"
+#include "demangle.h"
 #include "dictionary.h"
-#include "addrmap.h"
-#include <algorithm>
+#include "expression.h"
+#include "filenames.h"
+#include "gdb_obstack.h"
+#include "gdbtypes.h"
+#include "macrotab.h"
+#include "objfiles.h"
+#include "symfile.h"
+#include "symtab.h"
 
 /* For cleanup_undefined_stabs_types and finish_global_stabs (somewhat
    questionable--see comment where we call them).  */
diff --git a/gdb/c-lang.c b/gdb/c-lang.c
index 36c750204da..0438f4bd088 100644
--- a/gdb/c-lang.c
+++ b/gdb/c-lang.c
@@ -18,23 +18,27 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "expression.h"
-#include "parser-defs.h"
-#include "language.h"
-#include "varobj.h"
+
+/* Standard C includes.  */
+#include <ctype.h>
+
+/* Local non-gdb includes.  */
 #include "c-lang.h"
 #include "c-support.h"
-#include "valprint.h"
-#include "macroscope.h"
 #include "charset.h"
-#include "demangle.h"
 #include "cp-abi.h"
 #include "cp-support.h"
+#include "demangle.h"
+#include "expression.h"
 #include "gdb_obstack.h"
-#include <ctype.h>
 #include "gdbcore.h"
+#include "gdbtypes.h"
+#include "language.h"
+#include "macroscope.h"
+#include "parser-defs.h"
+#include "symtab.h"
+#include "valprint.h"
+#include "varobj.h"
 
 /* Given a C string type, STR_TYPE, return the corresponding target
    character set name.  */
diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c
index 6690ca53bcd..f8e02c27963 100644
--- a/gdb/c-typeprint.c
+++ b/gdb/c-typeprint.c
@@ -17,21 +17,23 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdb_obstack.h"
-#include "bfd.h"		/* Binary File Description.  */
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "expression.h"
-#include "value.h"
-#include "gdbcore.h"
-#include "target.h"
-#include "language.h"
-#include "demangle.h"
+
+/* Local non-gdb includes.  */
+#include "bfd.h"
 #include "c-lang.h"
 #include "cli/cli-style.h"
-#include "typeprint.h"
 #include "cp-abi.h"
 #include "cp-support.h"
+#include "demangle.h"
+#include "expression.h"
+#include "gdb_obstack.h"
+#include "gdbcore.h"
+#include "gdbtypes.h"
+#include "language.h"
+#include "symtab.h"
+#include "target.h"
+#include "typeprint.h"
+#include "value.h"
 
 /* A list of access specifiers used for printing.  */
 
diff --git a/gdb/c-valprint.c b/gdb/c-valprint.c
index c4306f1488f..d2b07d08db2 100644
--- a/gdb/c-valprint.c
+++ b/gdb/c-valprint.c
@@ -18,16 +18,19 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "expression.h"
-#include "value.h"
-#include "valprint.h"
-#include "language.h"
+
+/* Local non-gdb includes.  */
 #include "c-lang.h"
 #include "cp-abi.h"
-#include "target.h"
+#include "expression.h"
+#include "gdbtypes.h"
+#include "language.h"
 #include "objfiles.h"
+#include "symtab.h"
+#include "target.h"
+#include "valprint.h"
+#include "value.h"
+
 
 
 /* A helper for c_textual_element_type.  This checks the name of the
diff --git a/gdb/c-varobj.c b/gdb/c-varobj.c
index 2d247745c04..bcbc1537e12 100644
--- a/gdb/c-varobj.c
+++ b/gdb/c-varobj.c
@@ -16,10 +16,12 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "value.h"
-#include "varobj.h"
+
+/* Local non-gdb includes.  */
 #include "gdbthread.h"
 #include "valprint.h"
+#include "value.h"
+#include "varobj.h"
 
 static void cplus_class_num_children (struct type *type, int children[3]);
 
diff --git a/gdb/charset.c b/gdb/charset.c
index 5d8a9966031..505ccd35f85 100644
--- a/gdb/charset.c
+++ b/gdb/charset.c
@@ -18,16 +18,20 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "charset.h"
-#include "gdbcmd.h"
-#include "gdb_obstack.h"
-#include "common/gdb_wait.h"
+
+/* Standard C includes.  */
+#include <ctype.h>
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
 #include "charset-list.h"
-#include "common/vec.h"
+#include "charset.h"
 #include "common/environ.h"
-#include "arch-utils.h"
 #include "common/gdb_vecs.h"
-#include <ctype.h>
+#include "common/gdb_wait.h"
+#include "common/vec.h"
+#include "gdb_obstack.h"
+#include "gdbcmd.h"
 
 #ifdef USE_WIN32API
 #include <windows.h>
diff --git a/gdb/cli-out.c b/gdb/cli-out.c
index 55c8d2b3b1b..4665da4ebb3 100644
--- a/gdb/cli-out.c
+++ b/gdb/cli-out.c
@@ -21,11 +21,13 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "ui-out.h"
+
+/* Local non-gdb includes.  */
 #include "cli-out.h"
+#include "cli/cli-style.h"
 #include "completer.h"
 #include "readline/readline.h"
-#include "cli/cli-style.h"
+#include "ui-out.h"
 
 /* These are the CLI output functions */
 
diff --git a/gdb/cli-out.h b/gdb/cli-out.h
index eeb555fbbec..995d14dd4a2 100644
--- a/gdb/cli-out.h
+++ b/gdb/cli-out.h
@@ -20,9 +20,11 @@
 #ifndef CLI_OUT_H
 #define CLI_OUT_H
 
-#include "ui-out.h"
 #include <vector>
 
+/* Local non-gdb includes.  */
+#include "ui-out.h"
+
 class cli_ui_out : public ui_out
 {
 public:
diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c
index f5721382f4c..06da8411ff1 100644
--- a/gdb/coff-pe-read.c
+++ b/gdb/coff-pe-read.c
@@ -23,20 +23,20 @@
 
 #include "defs.h"
 
-#include "coff-pe-read.h"
+/* Standard C includes.  */
+#include <ctype.h>
 
+/* Local non-gdb includes.  */
 #include "bfd.h"
-#include "gdbtypes.h"
-
+#include "coff-pe-read.h"
+#include "coff/internal.h"
 #include "command.h"
+#include "common/common-utils.h"
 #include "gdbcmd.h"
-#include "symtab.h"
-#include "symfile.h"
+#include "gdbtypes.h"
 #include "objfiles.h"
-#include "common/common-utils.h"
-#include "coff/internal.h"
-
-#include <ctype.h>
+#include "symfile.h"
+#include "symtab.h"
 
 /* Internal section information */
 
diff --git a/gdb/coffread.c b/gdb/coffread.c
index 4354741ab64..ae0d05bddf3 100644
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -18,30 +18,30 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "demangle.h"
-#include "breakpoint.h"
 
-#include "bfd.h"
-#include "gdb_obstack.h"
+/* Standard C includes.  */
 #include <ctype.h>
 
-#include "coff/internal.h"	/* Internal format of COFF symbols in BFD */
-#include "libcoff.h"		/* FIXME secret internal data from BFD */
-#include "objfiles.h"
+/* Local non-gdb includes.  */
+#include "bfd.h"
+#include "block.h"
+#include "breakpoint.h"
+#include "build-id.h"
 #include "buildsym-legacy.h"
-#include "gdb-stabs.h"
-#include "stabsread.h"
+#include "coff-pe-read.h"
+#include "coff/internal.h"
 #include "complaints.h"
-#include "target.h"
-#include "block.h"
+#include "demangle.h"
 #include "dictionary.h"
-
-#include "coff-pe-read.h"
-
+#include "gdb-stabs.h"
+#include "gdb_obstack.h"
+#include "gdbtypes.h"
+#include "libcoff.h"
+#include "objfiles.h"
 #include "psymtab.h"
-#include "build-id.h"
+#include "stabsread.h"
+#include "symtab.h"
+#include "target.h"
 
 /* Key for COFF-associated data.  */
 
diff --git a/gdb/complaints.c b/gdb/complaints.c
index c5b5471ee18..b1422076989 100644
--- a/gdb/complaints.c
+++ b/gdb/complaints.c
@@ -18,10 +18,14 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "complaints.h"
+
+/* Standard C++ includes.  */
+#include <unordered_map>
+
+/* Local non-gdb includes.  */
 #include "command.h"
+#include "complaints.h"
 #include "gdbcmd.h"
-#include <unordered_map>
 
 /* Map format strings to counters.  */
 
diff --git a/gdb/completer.c b/gdb/completer.c
index d7cf4fd1203..ae7999926fd 100644
--- a/gdb/completer.c
+++ b/gdb/completer.c
@@ -17,20 +17,24 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
+#include "cli/cli-decode.h"
+#include "common/gdb_signals.h"
 #include "expression.h"
-#include "filenames.h"		/* For DOSish file names.  */
+#include "filenames.h"
+#include "gdbtypes.h"
 #include "language.h"
-#include "common/gdb_signals.h"
-#include "target.h"
+#include "linespec.h"
+#include "location.h"
 #include "reggroups.h"
+#include "symtab.h"
+#include "target.h"
 #include "user-regs.h"
-#include "arch-utils.h"
-#include "location.h"
-#include <algorithm>
-#include "linespec.h"
-#include "cli/cli-decode.h"
 
 /* FIXME: This is needed because of lookup_cmd_1 ().  We should be
    calling a hook instead so we eliminate the CLI dependency.  */
diff --git a/gdb/completer.h b/gdb/completer.h
index 52f8d7dff4f..282e954a4e8 100644
--- a/gdb/completer.h
+++ b/gdb/completer.h
@@ -17,8 +17,8 @@
 #if !defined (COMPLETER_H)
 #define COMPLETER_H 1
 
-#include "common/gdb_vecs.h"
 #include "command.h"
+#include "common/gdb_vecs.h"
 
 /* Types of functions in struct match_list_displayer.  */
 
diff --git a/gdb/continuations.c b/gdb/continuations.c
index 1feee32ebaa..3f565a8f810 100644
--- a/gdb/continuations.c
+++ b/gdb/continuations.c
@@ -18,9 +18,11 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "continuations.h"
 #include "gdbthread.h"
 #include "inferior.h"
-#include "continuations.h"
 
 struct continuation
 {
diff --git a/gdb/corefile.c b/gdb/corefile.c
index bf859fbbb8d..7a99a4d79dc 100644
--- a/gdb/corefile.c
+++ b/gdb/corefile.c
@@ -18,20 +18,24 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include <signal.h>
+
+/* Standard C includes.  */
 #include <fcntl.h>
-#include "inferior.h"
-#include "symtab.h"
+#include <signal.h>
+#include <sys/stat.h>
+
+/* Local non-gdb includes.  */
+#include "bfd.h"
+#include "cli/cli-utils.h"
 #include "command.h"
+#include "completer.h"
+#include "dis-asm.h"
 #include "gdbcmd.h"
-#include "bfd.h"
-#include "target.h"
 #include "gdbcore.h"
-#include "dis-asm.h"
-#include <sys/stat.h>
-#include "completer.h"
+#include "inferior.h"
 #include "observable.h"
-#include "cli/cli-utils.h"
+#include "symtab.h"
+#include "target.h"
 
 /* You can have any number of hooks for `exec_file_command' command to
    call.  If there's only one hook, it is set in exec_file_display
diff --git a/gdb/corelow.c b/gdb/corelow.c
index 7fb42970de4..e7f164f4f27 100644
--- a/gdb/corelow.c
+++ b/gdb/corelow.c
@@ -18,31 +18,35 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "arch-utils.h"
-#include <signal.h>
+
+/* Standard C includes.  */
 #include <fcntl.h>
-#include "frame.h"		/* required by inferior.h */
-#include "inferior.h"
-#include "infrun.h"
-#include "symtab.h"
-#include "command.h"
+#include <signal.h>
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
 #include "bfd.h"
-#include "target.h"
-#include "process-stratum-target.h"
+#include "command.h"
+#include "common/filestuff.h"
+#include "completer.h"
+#include "exec.h"
+#include "filenames.h"
+#include "frame.h"
+#include "gdb_bfd.h"
 #include "gdbcore.h"
 #include "gdbthread.h"
+#include "inferior.h"
+#include "infrun.h"
+#include "objfiles.h"
+#include "process-stratum-target.h"
+#include "progspace.h"
+#include "readline/readline.h"
 #include "regcache.h"
 #include "regset.h"
-#include "symfile.h"
-#include "exec.h"
-#include "readline/readline.h"
 #include "solib.h"
-#include "filenames.h"
-#include "progspace.h"
-#include "objfiles.h"
-#include "gdb_bfd.h"
-#include "completer.h"
-#include "common/filestuff.h"
+#include "symfile.h"
+#include "symtab.h"
+#include "target.h"
 
 #ifndef O_LARGEFILE
 #define O_LARGEFILE 0
diff --git a/gdb/cp-abi.c b/gdb/cp-abi.c
index b858b190668..07db7effbb9 100644
--- a/gdb/cp-abi.c
+++ b/gdb/cp-abi.c
@@ -18,11 +18,14 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "value.h"
-#include "cp-abi.h"
+
+/* Local non-gdb includes.  */
 #include "command.h"
+#include "cp-abi.h"
 #include "gdbcmd.h"
 #include "ui-out.h"
+#include "value.h"
+
 static struct cp_abi_ops *find_cp_abi (const char *short_name);
 
 static struct cp_abi_ops current_cp_abi = { "", NULL };
diff --git a/gdb/cp-namespace.c b/gdb/cp-namespace.c
index 5b352d1d77b..574ae7e9334 100644
--- a/gdb/cp-namespace.c
+++ b/gdb/cp-namespace.c
@@ -19,20 +19,24 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "cp-support.h"
-#include "gdb_obstack.h"
-#include "symtab.h"
-#include "symfile.h"
+
+/* Standard C++ includes.  */
+#include <string>
+
+/* Local non-gdb includes.  */
 #include "block.h"
-#include "objfiles.h"
-#include "gdbtypes.h"
-#include "dictionary.h"
+#include "buildsym.h"
 #include "command.h"
+#include "cp-support.h"
+#include "dictionary.h"
 #include "frame.h"
-#include "buildsym.h"
+#include "gdb_obstack.h"
+#include "gdbtypes.h"
 #include "language.h"
 #include "namespace.h"
-#include <string>
+#include "objfiles.h"
+#include "symfile.h"
+#include "symtab.h"
 
 static struct block_symbol
   cp_lookup_nested_symbol_1 (struct type *container_type,
diff --git a/gdb/cp-support.c b/gdb/cp-support.c
index b79dd5c086f..9970f0ca864 100644
--- a/gdb/cp-support.c
+++ b/gdb/cp-support.c
@@ -19,24 +19,28 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Standard C includes.  */
+#include <signal.h>
+
+/* Local non-gdb includes.  */
+#include "block.h"
+#include "common/gdb_setjmp.h"
+#include "common/selftest.h"
+#include "complaints.h"
+#include "cp-abi.h"
 #include "cp-support.h"
 #include "demangle.h"
-#include "gdbcmd.h"
 #include "dictionary.h"
-#include "objfiles.h"
+#include "expression.h"
 #include "frame.h"
-#include "symtab.h"
-#include "block.h"
-#include "complaints.h"
+#include "gdbcmd.h"
 #include "gdbtypes.h"
-#include "expression.h"
-#include "value.h"
-#include "cp-abi.h"
 #include "namespace.h"
-#include <signal.h>
-#include "common/gdb_setjmp.h"
+#include "objfiles.h"
 #include "safe-ctype.h"
-#include "common/selftest.h"
+#include "symtab.h"
+#include "value.h"
 
 #define d_left(dc) (dc)->u.s_binary.left
 #define d_right(dc) (dc)->u.s_binary.right
diff --git a/gdb/cp-valprint.c b/gdb/cp-valprint.c
index 443c3b06dac..f6e7e538679 100644
--- a/gdb/cp-valprint.c
+++ b/gdb/cp-valprint.c
@@ -18,24 +18,26 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdb_obstack.h"
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "expression.h"
-#include "value.h"
-#include "command.h"
-#include "gdbcmd.h"
-#include "demangle.h"
+
+/* Local non-gdb includes.  */
 #include "annotate.h"
 #include "c-lang.h"
-#include "target.h"
+#include "command.h"
+#include "common/byte-vector.h"
 #include "cp-abi.h"
-#include "valprint.h"
 #include "cp-support.h"
-#include "language.h"
+#include "demangle.h"
+#include "expression.h"
 #include "extension.h"
+#include "gdb_obstack.h"
+#include "gdbcmd.h"
+#include "gdbtypes.h"
+#include "language.h"
+#include "symtab.h"
+#include "target.h"
 #include "typeprint.h"
-#include "common/byte-vector.h"
+#include "valprint.h"
+#include "value.h"
 
 /* Controls printing of vtbl's.  */
 static void
diff --git a/gdb/cris-linux-tdep.c b/gdb/cris-linux-tdep.c
index 27681cb8b27..8f765b5060f 100644
--- a/gdb/cris-linux-tdep.c
+++ b/gdb/cris-linux-tdep.c
@@ -22,13 +22,14 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "osabi.h"
+
+/* Local non-gdb includes.  */
+#include "cris-tdep.h"
 #include "linux-tdep.h"
+#include "osabi.h"
 #include "solib-svr4.h"
 #include "symtab.h"
 
-#include "cris-tdep.h"
-
 static void
 cris_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
 {
diff --git a/gdb/cris-tdep.c b/gdb/cris-tdep.c
index 8eda05806f8..a41335ded66 100644
--- a/gdb/cris-tdep.c
+++ b/gdb/cris-tdep.c
@@ -21,30 +21,29 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "frame.h"
-#include "frame-unwind.h"
-#include "frame-base.h"
-#include "trad-frame.h"
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
+#include "cris-tdep.h"
+#include "dis-asm.h"
 #include "dwarf2-frame.h"
-#include "symtab.h"
-#include "inferior.h"
-#include "gdbtypes.h"
-#include "gdbcore.h"
+#include "frame-base.h"
+#include "frame-unwind.h"
+#include "frame.h"
 #include "gdbcmd.h"
-#include "target.h"
-#include "value.h"
+#include "gdbcore.h"
+#include "gdbtypes.h"
+#include "inferior.h"
+#include "objfiles.h"
 #include "opcode/cris.h"
 #include "osabi.h"
-#include "arch-utils.h"
 #include "regcache.h"
-
-#include "objfiles.h"
-
-#include "solib.h"              /* Support for shared libraries.  */
 #include "solib-svr4.h"
-#include "dis-asm.h"
-
-#include "cris-tdep.h"
+#include "solib.h"
+#include "symtab.h"
+#include "target.h"
+#include "trad-frame.h"
+#include "value.h"
 
 enum cris_num_regs
 {
diff --git a/gdb/csky-linux-tdep.c b/gdb/csky-linux-tdep.c
index ab4af9f6f15..235d4dbcfb6 100644
--- a/gdb/csky-linux-tdep.c
+++ b/gdb/csky-linux-tdep.c
@@ -20,15 +20,17 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "osabi.h"
+
+/* Local non-gdb includes.  */
+#include "csky-tdep.h"
+#include "gdbarch.h"
 #include "glibc-tdep.h"
 #include "linux-tdep.h"
-#include "gdbarch.h"
-#include "solib-svr4.h"
+#include "osabi.h"
 #include "regset.h"
+#include "solib-svr4.h"
 #include "trad-frame.h"
 #include "tramp-frame.h"
-#include "csky-tdep.h"
 
 /* Functions, definitions, and data structures for C-Sky core file debug.  */
 
diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c
index cd7d8c5a0b1..cabc5e14918 100644
--- a/gdb/csky-tdep.c
+++ b/gdb/csky-tdep.c
@@ -20,43 +20,47 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+#include <vector>
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
+#include "block.h"
 #include "common/gdb_assert.h"
+#include "csky-tdep.h"
+#include "dis-asm.h"
+#include "dwarf2-frame.h"
+#include "elf-bfd.h"
+#include "elf/csky.h"
+#include "floatformat.h"
+#include "frame-base.h"
+#include "frame-unwind.h"
 #include "frame.h"
-#include "inferior.h"
-#include "symtab.h"
-#include "value.h"
 #include "gdbcmd.h"
-#include "language.h"
 #include "gdbcore.h"
-#include "symfile.h"
-#include "objfiles.h"
 #include "gdbtypes.h"
-#include "target.h"
-#include "arch-utils.h"
-#include "regcache.h"
+#include "infcall.h"
+#include "inferior.h"
+#include "language.h"
+#include "objfiles.h"
+#include "opcode/csky.h"
 #include "osabi.h"
-#include "block.h"
+#include "regcache.h"
 #include "reggroups.h"
-#include "elf/csky.h"
-#include "elf-bfd.h"
-#include "symcat.h"
-#include "sim-regno.h"
-#include "dis-asm.h"
-#include "frame-unwind.h"
-#include "frame-base.h"
-#include "trad-frame.h"
-#include "infcall.h"
-#include "floatformat.h"
+#include "regset.h"
 #include "remote.h"
+#include "sim-regno.h"
+#include "symcat.h"
+#include "symfile.h"
+#include "symtab.h"
 #include "target-descriptions.h"
-#include "dwarf2-frame.h"
+#include "target.h"
+#include "trad-frame.h"
 #include "user-regs.h"
 #include "valprint.h"
-#include "csky-tdep.h"
-#include "regset.h"
-#include "opcode/csky.h"
-#include <algorithm>
-#include <vector>
+#include "value.h"
 
 /* Control debugging information emitted in this file.  */
 static int csky_debug = 0;
diff --git a/gdb/ctf.c b/gdb/ctf.c
index 7a95df78152..6796931edf3 100644
--- a/gdb/ctf.c
+++ b/gdb/ctf.c
@@ -20,18 +20,24 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "ctf.h"
-#include "tracepoint.h"
-#include "regcache.h"
+
+/* Standard C includes.  */
+#include <ctype.h>
 #include <sys/stat.h>
-#include "exec.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "common/filestuff.h"
 #include "completer.h"
-#include "inferior.h"
+#include "ctf.h"
+#include "exec.h"
 #include "gdbthread.h"
+#include "inferior.h"
+#include "regcache.h"
 #include "tracefile.h"
-#include <ctype.h>
-#include <algorithm>
-#include "common/filestuff.h"
+#include "tracepoint.h"
 
 /* The CTF target.  */
 
diff --git a/gdb/d-lang.c b/gdb/d-lang.c
index 637e012b32e..7fb6c52748e 100644
--- a/gdb/d-lang.c
+++ b/gdb/d-lang.c
@@ -18,13 +18,15 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "language.h"
-#include "varobj.h"
-#include "d-lang.h"
+
+/* Local non-gdb includes.  */
 #include "c-lang.h"
-#include "demangle.h"
 #include "cp-support.h"
+#include "d-lang.h"
+#include "demangle.h"
+#include "language.h"
+#include "symtab.h"
+#include "varobj.h"
 
 /* The name of the symbol to use to get the name of the main subprogram.  */
 static const char D_MAIN[] = "D main";
diff --git a/gdb/d-namespace.c b/gdb/d-namespace.c
index 4edef188e9e..e5d4adf8df6 100644
--- a/gdb/d-namespace.c
+++ b/gdb/d-namespace.c
@@ -18,12 +18,14 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
+
+/* Local non-gdb includes.  */
 #include "block.h"
-#include "language.h"
-#include "namespace.h"
 #include "d-lang.h"
 #include "gdb_obstack.h"
+#include "language.h"
+#include "namespace.h"
+#include "symtab.h"
 
 /* This returns the length of first component of NAME, which should be
    the demangled name of a D variable/function/method/etc.
diff --git a/gdb/d-valprint.c b/gdb/d-valprint.c
index 54652364a8f..6d58ecaa622 100644
--- a/gdb/d-valprint.c
+++ b/gdb/d-valprint.c
@@ -18,10 +18,12 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdbtypes.h"
-#include "gdbcore.h"
-#include "d-lang.h"
+
+/* Local non-gdb includes.  */
 #include "c-lang.h"
+#include "d-lang.h"
+#include "gdbcore.h"
+#include "gdbtypes.h"
 
 /* Assuming that TYPE is a TYPE_CODE_STRUCT, verify that TYPE is a
    dynamic array, and then print its value to STREAM.  Return zero if
diff --git a/gdb/darwin-nat-info.c b/gdb/darwin-nat-info.c
index ca3b2e87252..88ee027f71e 100644
--- a/gdb/darwin-nat-info.c
+++ b/gdb/darwin-nat-info.c
@@ -28,24 +28,25 @@
    Tiger is no longer important.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "gdbcore.h"
-#include "value.h"
-#include "gdbcmd.h"
-#include "inferior.h"
 
+/* Standard C includes.  */
+#include <mach/mach_init.h>
+#include <mach/mach_port.h>
+#include <mach/mach_vm.h>
+#include <mach/task.h>
+#include <mach/thread_act.h>
+#include <mach/thread_info.h>
+#include <mach/vm_map.h>
 #include <sys/sysctl.h>
 
+/* Local non-gdb includes.  */
 #include "darwin-nat.h"
-
-#include <mach/thread_info.h>
-#include <mach/thread_act.h>
-#include <mach/task.h>
-#include <mach/vm_map.h>
-#include <mach/mach_port.h>
-#include <mach/mach_init.h>
-#include <mach/mach_vm.h>
+#include "gdbcmd.h"
+#include "gdbcore.h"
+#include "gdbtypes.h"
+#include "inferior.h"
+#include "symtab.h"
+#include "value.h"
 
 #define CHECK_ARGS(what, args) do { \
   if ((NULL == args) || ((args[0] != '0') && (args[1] != 'x'))) \
diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index 6247b0656c9..ec9a313d599 100644
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -19,55 +19,56 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "top.h"
-#include "inferior.h"
-#include "target.h"
-#include "symfile.h"
-#include "symtab.h"
-#include "objfiles.h"
-#include "gdbcmd.h"
-#include "gdbcore.h"
-#include "gdbthread.h"
-#include "regcache.h"
-#include "event-top.h"
-#include "inf-loop.h"
-#include <sys/stat.h>
-#include "inf-child.h"
-#include "value.h"
-#include "arch-utils.h"
-#include "bfd.h"
-#include "bfd/mach-o.h"
 
+/* Standard C includes.  */
 #include <copyfile.h>
-#include <sys/ptrace.h>
-#include <sys/signal.h>
-#include <setjmp.h>
-#include <sys/types.h>
-#include <unistd.h>
-#include <signal.h>
 #include <ctype.h>
-#include <sys/sysctl.h>
-#include <sys/proc.h>
 #include <libproc.h>
-#include <sys/syscall.h>
-#include <spawn.h>
-
 #include <mach/mach_error.h>
-#include <mach/mach_vm.h>
 #include <mach/mach_init.h>
-#include <mach/vm_map.h>
-#include <mach/task.h>
 #include <mach/mach_port.h>
-#include <mach/thread_act.h>
+#include <mach/mach_vm.h>
 #include <mach/port.h>
+#include <mach/task.h>
+#include <mach/thread_act.h>
+#include <mach/vm_map.h>
+#include <setjmp.h>
+#include <signal.h>
+#include <spawn.h>
+#include <sys/proc.h>
+#include <sys/ptrace.h>
+#include <sys/signal.h>
+#include <sys/stat.h>
+#include <sys/syscall.h>
+#include <sys/sysctl.h>
+#include <sys/types.h>
+#include <unistd.h>
 
-#include "darwin-nat.h"
-#include "filenames.h"
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
+#include "bfd.h"
+#include "bfd/mach-o.h"
 #include "common/filestuff.h"
 #include "common/gdb_unlinker.h"
 #include "common/pathstuff.h"
 #include "common/scoped_fd.h"
+#include "darwin-nat.h"
+#include "event-top.h"
+#include "filenames.h"
+#include "gdbcmd.h"
+#include "gdbcore.h"
+#include "gdbthread.h"
+#include "inf-child.h"
+#include "inf-loop.h"
+#include "inferior.h"
 #include "nat/fork-inferior.h"
+#include "objfiles.h"
+#include "regcache.h"
+#include "symfile.h"
+#include "symtab.h"
+#include "target.h"
+#include "top.h"
+#include "value.h"
 
 /* Quick overview.
    Darwin kernel is Mach + BSD derived kernel.  Note that they share the
diff --git a/gdb/darwin-nat.h b/gdb/darwin-nat.h
index 9091efd88f1..cd656b1e487 100644
--- a/gdb/darwin-nat.h
+++ b/gdb/darwin-nat.h
@@ -17,9 +17,11 @@
 #ifndef DARWIN_NAT_H
 #define DARWIN_NAT_H
 
-#include "inf-child.h"
 #include <mach/mach.h>
+
+/* Local non-gdb includes.  */
 #include "gdbthread.h"
+#include "inf-child.h"
 
 /* This needs to be overridden by the platform specific nat code.  */
 
diff --git a/gdb/dcache.c b/gdb/dcache.c
index 5a2e8f8000b..6226ae477e1 100644
--- a/gdb/dcache.c
+++ b/gdb/dcache.c
@@ -18,12 +18,14 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "dcache.h"
 #include "gdbcmd.h"
 #include "gdbcore.h"
-#include "target-dcache.h"
 #include "inferior.h"
 #include "splay-tree.h"
+#include "target-dcache.h"
 
 /* Commands with a prefix of `{set,show} dcache'.  */
 static struct cmd_list_element *dcache_set_list = NULL;
diff --git a/gdb/dcache.h b/gdb/dcache.h
index 9c29074c919..97ed5362303 100644
--- a/gdb/dcache.h
+++ b/gdb/dcache.h
@@ -21,7 +21,7 @@
 #ifndef DCACHE_H
 #define DCACHE_H
 
-#include "target.h"	/* for enum target_xfer_status */
+#include "target.h"
 
 typedef struct dcache_struct DCACHE;
 
diff --git a/gdb/demangle.c b/gdb/demangle.c
index 29f46968a29..8e5065a27b0 100644
--- a/gdb/demangle.c
+++ b/gdb/demangle.c
@@ -24,11 +24,13 @@
    to a styles of demangling, and GDB specific.  */
 
 #include "defs.h"
-#include "cli/cli-utils.h" /* for skip_to_space */
+
+/* Local non-gdb includes.  */
+#include "cli/cli-utils.h"
 #include "command.h"
-#include "gdbcmd.h"
 #include "demangle.h"
 #include "gdb-demangle.h"
+#include "gdbcmd.h"
 #include "language.h"
 
 /* Select the default C++ demangling style to use.  The default is "auto",
diff --git a/gdb/dicos-tdep.c b/gdb/dicos-tdep.c
index bacba963685..48f11a55d31 100644
--- a/gdb/dicos-tdep.c
+++ b/gdb/dicos-tdep.c
@@ -18,11 +18,13 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "dicos-tdep.h"
+#include "inferior.h"
 #include "osabi.h"
-#include "solib.h"
 #include "solib-target.h"
-#include "inferior.h"
-#include "dicos-tdep.h"
+#include "solib.h"
 
 void
 dicos_init_abi (struct gdbarch *gdbarch)
diff --git a/gdb/dictionary.c b/gdb/dictionary.c
index 88eff2fa439..b4b544b3942 100644
--- a/gdb/dictionary.c
+++ b/gdb/dictionary.c
@@ -21,13 +21,19 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Standard C includes.  */
 #include <ctype.h>
-#include "gdb_obstack.h"
-#include "symtab.h"
+
+/* Standard C++ includes.  */
+#include <unordered_map>
+
+/* Local non-gdb includes.  */
 #include "buildsym.h"
 #include "dictionary.h"
+#include "gdb_obstack.h"
 #include "safe-ctype.h"
-#include <unordered_map>
+#include "symtab.h"
 
 /* This file implements dictionaries, which are tables that associate
    symbols to names.  They are represented by an opaque type 'struct
diff --git a/gdb/disasm-selftests.c b/gdb/disasm-selftests.c
index 48b466baf13..b12a99f6741 100644
--- a/gdb/disasm-selftests.c
+++ b/gdb/disasm-selftests.c
@@ -18,6 +18,8 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "disasm.h"
 
 #if GDB_SELF_TEST
diff --git a/gdb/disasm.c b/gdb/disasm.c
index 7c7a148935e..d989a8b7f50 100644
--- a/gdb/disasm.c
+++ b/gdb/disasm.c
@@ -18,19 +18,23 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
 #include "arch-utils.h"
-#include "target.h"
-#include "value.h"
-#include "ui-out.h"
+#include "common/gdb_optional.h"
+#include "dis-asm.h"
 #include "disasm.h"
-#include "gdbcore.h"
 #include "gdbcmd.h"
-#include "dis-asm.h"
-#include "source.h"
+#include "gdbcore.h"
 #include "safe-ctype.h"
-#include <algorithm>
-#include "common/gdb_optional.h"
+#include "source.h"
+#include "target.h"
+#include "ui-out.h"
 #include "valprint.h"
+#include "value.h"
 
 /* Disassemble functions.
    FIXME: We should get rid of all the duplicate code in gdb that does
diff --git a/gdb/disasm.h b/gdb/disasm.h
index d3cc6312093..39d838195bd 100644
--- a/gdb/disasm.h
+++ b/gdb/disasm.h
@@ -19,8 +19,8 @@
 #ifndef DISASM_H
 #define DISASM_H
 
-#include "dis-asm.h"
 #include "common/enum-flags.h"
+#include "dis-asm.h"
 
 enum gdb_disassembly_flag
   {
diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c
index bd5cddcf804..0114c401af1 100644
--- a/gdb/dtrace-probe.c
+++ b/gdb/dtrace-probe.c
@@ -20,19 +20,21 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "probe.h"
+
+/* Local non-gdb includes.  */
+#include "ax-gdb.h"
+#include "ax.h"
 #include "common/vec.h"
+#include "complaints.h"
 #include "elf-bfd.h"
 #include "gdbtypes.h"
-#include "obstack.h"
-#include "objfiles.h"
-#include "complaints.h"
-#include "value.h"
-#include "ax.h"
-#include "ax-gdb.h"
+#include "inferior.h"
 #include "language.h"
+#include "objfiles.h"
+#include "obstack.h"
 #include "parser-defs.h"
-#include "inferior.h"
+#include "probe.h"
+#include "value.h"
 
 /* The type of the ELF sections where we will find the DOF programs
    with information about probes.  */
diff --git a/gdb/dummy-frame.c b/gdb/dummy-frame.c
index aebdd233d74..99d3d7c8bc3 100644
--- a/gdb/dummy-frame.c
+++ b/gdb/dummy-frame.c
@@ -19,16 +19,18 @@
 
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "command.h"
 #include "dummy-frame.h"
-#include "regcache.h"
-#include "frame.h"
-#include "inferior.h"
 #include "frame-unwind.h"
-#include "command.h"
+#include "frame.h"
 #include "gdbcmd.h"
-#include "observable.h"
 #include "gdbthread.h"
 #include "infcall.h"
+#include "inferior.h"
+#include "observable.h"
+#include "regcache.h"
 
 struct dummy_frame_id
 {
diff --git a/gdb/dwarf-index-cache.c b/gdb/dwarf-index-cache.c
index 445f8b199e6..41340b8d8de 100644
--- a/gdb/dwarf-index-cache.c
+++ b/gdb/dwarf-index-cache.c
@@ -18,19 +18,24 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "dwarf-index-cache.h"
 
+/* Standard C includes.  */
+#include <stdlib.h>
+
+/* Standard C++ includes.  */
+#include <string>
+
+/* Local non-gdb includes.  */
 #include "build-id.h"
 #include "cli/cli-cmds.h"
 #include "command.h"
-#include "common/scoped_mmap.h"
 #include "common/pathstuff.h"
+#include "common/scoped_mmap.h"
+#include "common/selftest.h"
+#include "dwarf-index-cache.h"
 #include "dwarf-index-write.h"
 #include "dwarf2read.h"
 #include "objfiles.h"
-#include "common/selftest.h"
-#include <string>
-#include <stdlib.h>
 
 /* When set to 1, show debug messages about the index cache.  */
 static int debug_index_cache = 0;
diff --git a/gdb/dwarf-index-cache.h b/gdb/dwarf-index-cache.h
index 2f267632141..807cfea00b7 100644
--- a/gdb/dwarf-index-cache.h
+++ b/gdb/dwarf-index-cache.h
@@ -20,8 +20,8 @@
 #ifndef DWARF_INDEX_CACHE_H
 #define DWARF_INDEX_CACHE_H
 
-#include "dwarf-index-common.h"
 #include "common/array-view.h"
+#include "dwarf-index-common.h"
 #include "symfile.h"
 
 /* Base of the classes used to hold the resources of the indices loaded from
diff --git a/gdb/dwarf-index-common.c b/gdb/dwarf-index-common.c
index 220d74881a0..4a5ef6245f6 100644
--- a/gdb/dwarf-index-common.c
+++ b/gdb/dwarf-index-common.c
@@ -18,6 +18,8 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "dwarf-index-common.h"
 
 /* See dwarf-index-common.h.  */
diff --git a/gdb/dwarf-index-write.c b/gdb/dwarf-index-write.c
index 01c1256bcb6..0c4173c90ef 100644
--- a/gdb/dwarf-index-write.c
+++ b/gdb/dwarf-index-write.c
@@ -19,6 +19,14 @@
 
 #include "defs.h"
 
+/* Standard C++ includes.  */
+#include <algorithm>
+#include <cmath>
+#include <set>
+#include <unordered_map>
+#include <unordered_set>
+
+/* Local non-gdb includes.  */
 #include "addrmap.h"
 #include "cli/cli-decode.h"
 #include "common/byte-vector.h"
@@ -35,12 +43,6 @@
 #include "objfiles.h"
 #include "psympriv.h"
 
-#include <algorithm>
-#include <cmath>
-#include <set>
-#include <unordered_map>
-#include <unordered_set>
-
 /* Ensure only legit values are used.  */
 #define DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE(cu_index, value) \
   do { \
diff --git a/gdb/dwarf-index-write.h b/gdb/dwarf-index-write.h
index b1d1180c8e3..2d6248035a6 100644
--- a/gdb/dwarf-index-write.h
+++ b/gdb/dwarf-index-write.h
@@ -20,8 +20,8 @@
 #ifndef DWARF_INDEX_WRITE_H
 #define DWARF_INDEX_WRITE_H
 
-#include "symfile.h"
 #include "dwarf2read.h"
+#include "symfile.h"
 
 /* Create an index file for OBJFILE in the directory DIR.  BASENAME is the
    desired filename, minus the extension, which gets added by this function
diff --git a/gdb/dwarf2-frame-tailcall.c b/gdb/dwarf2-frame-tailcall.c
index 4cf7f5ff63a..c4e9c0991fc 100644
--- a/gdb/dwarf2-frame-tailcall.c
+++ b/gdb/dwarf2-frame-tailcall.c
@@ -18,16 +18,18 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "frame.h"
+
+/* Local non-gdb includes.  */
+#include "block.h"
 #include "dwarf2-frame-tailcall.h"
+#include "dwarf2-frame.h"
 #include "dwarf2loc.h"
 #include "frame-unwind.h"
-#include "block.h"
-#include "hashtab.h"
+#include "frame.h"
 #include "gdbtypes.h"
+#include "hashtab.h"
 #include "regcache.h"
 #include "value.h"
-#include "dwarf2-frame.h"
 
 /* Contains struct tailcall_cache indexed by next_bottom_frame.  */
 static htab_t cache_htab;
diff --git a/gdb/dwarf2-frame.c b/gdb/dwarf2-frame.c
index 178ac44ecbe..b657af2786c 100644
--- a/gdb/dwarf2-frame.c
+++ b/gdb/dwarf2-frame.c
@@ -20,25 +20,27 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "dwarf2expr.h"
+
+/* Local non-gdb includes.  */
+#include "ax.h"
+#include "complaints.h"
+#include "dwarf2-frame-tailcall.h"
+#include "dwarf2-frame.h"
 #include "dwarf2.h"
-#include "frame.h"
+#include "dwarf2expr.h"
+#include "dwarf2loc.h"
+#include "dwarf2read.h"
 #include "frame-base.h"
 #include "frame-unwind.h"
+#include "frame.h"
 #include "gdbcore.h"
 #include "gdbtypes.h"
-#include "symtab.h"
 #include "objfiles.h"
+#include "record.h"
 #include "regcache.h"
+#include "symtab.h"
 #include "value.h"
-#include "record.h"
 
-#include "complaints.h"
-#include "dwarf2-frame.h"
-#include "dwarf2read.h"
-#include "ax.h"
-#include "dwarf2loc.h"
-#include "dwarf2-frame-tailcall.h"
 #if GDB_SELF_TEST
 #include "common/selftest.h"
 #include "selftest-arch.h"
diff --git a/gdb/dwarf2expr.c b/gdb/dwarf2expr.c
index e412e182c01..17bec73149b 100644
--- a/gdb/dwarf2expr.c
+++ b/gdb/dwarf2expr.c
@@ -20,14 +20,16 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "value.h"
-#include "gdbcore.h"
+
+/* Local non-gdb includes.  */
+#include "common/underlying.h"
 #include "dwarf2.h"
 #include "dwarf2expr.h"
 #include "dwarf2loc.h"
-#include "common/underlying.h"
+#include "gdbcore.h"
+#include "gdbtypes.h"
+#include "symtab.h"
+#include "value.h"
 
 /* Cookie for gdbarch data.  */
 
diff --git a/gdb/dwarf2expr.h b/gdb/dwarf2expr.h
index c7cbf32d5e7..eb2259bfc44 100644
--- a/gdb/dwarf2expr.h
+++ b/gdb/dwarf2expr.h
@@ -22,8 +22,8 @@
 #if !defined (DWARF2EXPR_H)
 #define DWARF2EXPR_H
 
-#include "leb128.h"
 #include "gdbtypes.h"
+#include "leb128.h"
 
 /* The location of a value.  */
 enum dwarf_value_location
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index 29d289b4d0c..bac74461f9a 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -20,30 +20,34 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "ui-out.h"
-#include "value.h"
-#include "frame.h"
-#include "gdbcore.h"
-#include "target.h"
-#include "inferior.h"
-#include "ax.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+#include <unordered_set>
+#include <vector>
+
+/* Local non-gdb includes.  */
 #include "ax-gdb.h"
-#include "regcache.h"
-#include "objfiles.h"
+#include "ax.h"
 #include "block.h"
-#include "gdbcmd.h"
+#include "common/byte-vector.h"
+#include "common/selftest.h"
+#include "common/underlying.h"
+#include "compile/compile.h"
 #include "complaints.h"
+#include "dwarf2-frame.h"
 #include "dwarf2.h"
 #include "dwarf2expr.h"
 #include "dwarf2loc.h"
-#include "dwarf2-frame.h"
-#include "compile/compile.h"
-#include "common/selftest.h"
-#include <algorithm>
-#include <vector>
-#include <unordered_set>
-#include "common/underlying.h"
-#include "common/byte-vector.h"
+#include "frame.h"
+#include "gdbcmd.h"
+#include "gdbcore.h"
+#include "inferior.h"
+#include "objfiles.h"
+#include "regcache.h"
+#include "target.h"
+#include "ui-out.h"
+#include "value.h"
 
 extern int dwarf_always_disassemble;
 
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 8881a1e28a8..c10d9affce9 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -29,67 +29,73 @@
    E.g., load_partial_dies, read_partial_die.  */
 
 #include "defs.h"
-#include "dwarf2read.h"
-#include "dwarf-index-cache.h"
-#include "dwarf-index-common.h"
+
+/* Standard C includes.  */
+#include <ctype.h>
+#include <fcntl.h>
+#include <sys/stat.h>
+#include <sys/types.h>
+
+/* Standard C++ includes.  */
+#include <algorithm>
+#include <cmath>
+#include <forward_list>
+#include <set>
+#include <unordered_map>
+#include <unordered_set>
+
+/* Local non-gdb includes.  */
+#include "addrmap.h"
 #include "bfd.h"
-#include "elf-bfd.h"
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "objfiles.h"
-#include "dwarf2.h"
-#include "buildsym.h"
-#include "demangle.h"
-#include "gdb-demangle.h"
-#include "expression.h"
-#include "filenames.h"	/* for DOSish file names */
-#include "macrotab.h"
-#include "language.h"
-#include "complaints.h"
-#include "dwarf2expr.h"
-#include "dwarf2loc.h"
-#include "cp-support.h"
-#include "hashtab.h"
-#include "command.h"
-#include "gdbcmd.h"
 #include "block.h"
-#include "addrmap.h"
-#include "typeprint.h"
-#include "psympriv.h"
-#include <sys/stat.h>
-#include "completer.h"
-#include "common/vec.h"
+#include "build-id.h"
+#include "buildsym.h"
 #include "c-lang.h"
-#include "go-lang.h"
-#include "valprint.h"
-#include "gdbcore.h" /* for gnutarget */
-#include "gdb/gdb-index.h"
-#include <ctype.h>
-#include "gdb_bfd.h"
-#include "f-lang.h"
-#include "source.h"
+#include "command.h"
+#include "common/byte-vector.h"
 #include "common/filestuff.h"
-#include "build-id.h"
-#include "namespace.h"
-#include "common/gdb_unlinker.h"
 #include "common/function-view.h"
 #include "common/gdb_optional.h"
-#include "common/underlying.h"
-#include "common/byte-vector.h"
+#include "common/gdb_unlinker.h"
 #include "common/hash_enum.h"
+#include "common/pathstuff.h"
+#include "common/selftest.h"
+#include "common/underlying.h"
+#include "common/vec.h"
+#include "complaints.h"
+#include "completer.h"
+#include "cp-support.h"
+#include "demangle.h"
+#include "dwarf-index-cache.h"
+#include "dwarf-index-common.h"
+#include "dwarf2.h"
+#include "dwarf2expr.h"
+#include "dwarf2loc.h"
+#include "dwarf2read.h"
+#include "elf-bfd.h"
+#include "expression.h"
+#include "f-lang.h"
 #include "filename-seen-cache.h"
+#include "filenames.h"
+#include "gdb-demangle.h"
+#include "gdb/gdb-index.h"
+#include "gdb_bfd.h"
+#include "gdbcmd.h"
+#include "gdbcore.h"
+#include "gdbtypes.h"
+#include "go-lang.h"
+#include "hashtab.h"
+#include "language.h"
+#include "macrotab.h"
+#include "namespace.h"
+#include "objfiles.h"
 #include "producer.h"
-#include <fcntl.h>
-#include <sys/types.h>
-#include <algorithm>
-#include <unordered_set>
-#include <unordered_map>
-#include "common/selftest.h"
-#include <cmath>
-#include <set>
-#include <forward_list>
+#include "psympriv.h"
 #include "rust-lang.h"
-#include "common/pathstuff.h"
+#include "source.h"
+#include "symtab.h"
+#include "typeprint.h"
+#include "valprint.h"
 
 /* When == 1, print basic high level tracing messages.
    When > 1, be more verbose.
diff --git a/gdb/dwarf2read.h b/gdb/dwarf2read.h
index 34c66167b5b..8845e99d6bf 100644
--- a/gdb/dwarf2read.h
+++ b/gdb/dwarf2read.h
@@ -21,6 +21,8 @@
 #define DWARF2READ_H
 
 #include <unordered_map>
+
+/* Local non-gdb includes.  */
 #include "dwarf-index-cache.h"
 #include "filename-seen-cache.h"
 #include "gdb_obstack.h"
diff --git a/gdb/elfread.c b/gdb/elfread.c
index 55a16bb2f8e..6d67418fa0a 100644
--- a/gdb/elfread.c
+++ b/gdb/elfread.c
@@ -20,34 +20,36 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
+#include "auxv.h"
+#include "bcache.h"
 #include "bfd.h"
+#include "build-id.h"
+#include "complaints.h"
+#include "demangle.h"
 #include "elf-bfd.h"
 #include "elf/common.h"
 #include "elf/internal.h"
 #include "elf/mips.h"
-#include "symtab.h"
-#include "symfile.h"
-#include "objfiles.h"
-#include "stabsread.h"
-#include "gdb-stabs.h"
-#include "complaints.h"
-#include "demangle.h"
-#include "psympriv.h"
 #include "filenames.h"
-#include "probe.h"
-#include "arch-utils.h"
+#include "gdb-stabs.h"
+#include "gdb_bfd.h"
+#include "gdbthread.h"
 #include "gdbtypes.h"
-#include "value.h"
 #include "infcall.h"
-#include "gdbthread.h"
 #include "inferior.h"
-#include "regcache.h"
-#include "bcache.h"
-#include "gdb_bfd.h"
-#include "build-id.h"
 #include "location.h"
-#include "auxv.h"
 #include "mdebugread.h"
+#include "objfiles.h"
+#include "probe.h"
+#include "psympriv.h"
+#include "regcache.h"
+#include "stabsread.h"
+#include "symfile.h"
+#include "symtab.h"
+#include "value.h"
 
 /* Forward declarations.  */
 extern const struct sym_fns elf_sym_fns_gdb_index;
diff --git a/gdb/eval.c b/gdb/eval.c
index 3f768b45309..a67fd4f6716 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -18,29 +18,33 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
-#include "value.h"
+
+/* Standard C includes.  */
+#include <ctype.h>
+
+/* Local non-gdb includes.  */
+#include "block.h"
+#include "cp-abi.h"
+#include "cp-support.h"
 #include "expression.h"
-#include "target.h"
+#include "f-lang.h"
 #include "frame.h"
+#include "gdb_obstack.h"
 #include "gdbthread.h"
-#include "language.h"		/* For CAST_IS_CONVERSION.  */
-#include "f-lang.h"		/* For array bound stuff.  */
-#include "cp-abi.h"
+#include "gdbtypes.h"
 #include "infcall.h"
+#include "language.h"
 #include "objc-lang.h"
-#include "block.h"
+#include "objfiles.h"
 #include "parser-defs.h"
-#include "cp-support.h"
-#include "ui-out.h"
 #include "regcache.h"
+#include "symtab.h"
+#include "target.h"
+#include "typeprint.h"
+#include "ui-out.h"
 #include "user-regs.h"
 #include "valprint.h"
-#include "gdb_obstack.h"
-#include "objfiles.h"
-#include "typeprint.h"
-#include <ctype.h>
+#include "value.h"
 
 /* This is defined in valops.c */
 extern int overload_resolution;
diff --git a/gdb/event-loop.c b/gdb/event-loop.c
index 28e81646fbd..be09c2ceb3b 100644
--- a/gdb/event-loop.c
+++ b/gdb/event-loop.c
@@ -18,9 +18,11 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
+#include "common/queue.h"
 #include "event-loop.h"
 #include "event-top.h"
-#include "common/queue.h"
 #include "ser-event.h"
 
 #ifdef HAVE_POLL
diff --git a/gdb/event-top.c b/gdb/event-top.c
index fb5d51c6e10..78cbead9379 100644
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -20,26 +20,30 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "top.h"
-#include "inferior.h"
-#include "infrun.h"
-#include "target.h"
-#include "terminal.h"		/* for job_control */
+
+/* Standard C includes.  */
+#include <signal.h>
+
+/* Local non-gdb includes.  */
+#include "annotate.h"
+#include "cli/cli-script.h"
+#include "common/buffer.h"
+#include "continuations.h"
 #include "event-loop.h"
 #include "event-top.h"
+#include "gdb_select.h"
+#include "gdbcmd.h"
+#include "gdbthread.h"
+#include "inferior.h"
+#include "infrun.h"
 #include "interps.h"
-#include <signal.h>
-#include "cli/cli-script.h"     /* for reset_command_nest_depth */
 #include "main.h"
-#include "gdbthread.h"
-#include "observable.h"
-#include "continuations.h"
-#include "gdbcmd.h"		/* for dont_repeat() */
-#include "annotate.h"
 #include "maint.h"
-#include "common/buffer.h"
+#include "observable.h"
 #include "ser-event.h"
-#include "gdb_select.h"
+#include "target.h"
+#include "terminal.h"
+#include "top.h"
 
 /* readline include files.  */
 #include "readline/readline.h"
diff --git a/gdb/exceptions.c b/gdb/exceptions.c
index a29ef0cde50..c9a1fa7236c 100644
--- a/gdb/exceptions.c
+++ b/gdb/exceptions.c
@@ -18,16 +18,18 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "exceptions.h"
+
+/* Local non-gdb includes.  */
+#include "annotate.h"
 #include "breakpoint.h"
-#include "target.h"
+#include "common/gdb_optional.h"
+#include "exceptions.h"
+#include "gdbthread.h"
 #include "inferior.h"
-#include "annotate.h"
-#include "ui-out.h"
 #include "serial.h"
-#include "gdbthread.h"
+#include "target.h"
 #include "top.h"
-#include "common/gdb_optional.h"
+#include "ui-out.h"
 
 static void
 print_flush (void)
diff --git a/gdb/exec.c b/gdb/exec.c
index 77bd140a8e8..1c3c16c053e 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -18,34 +18,38 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Standard C includes.  */
+#include <ctype.h>
+#include <fcntl.h>
+#include <sys/stat.h>
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
+#include "common/pathstuff.h"
+#include "completer.h"
+#include "exec.h"
+#include "filenames.h"
 #include "frame.h"
-#include "inferior.h"
-#include "target.h"
+#include "gcore.h"
+#include "gdb_bfd.h"
 #include "gdbcmd.h"
+#include "gdbcore.h"
+#include "gdbthread.h"
+#include "inferior.h"
 #include "language.h"
-#include "filenames.h"
-#include "symfile.h"
 #include "objfiles.h"
-#include "completer.h"
-#include "value.h"
-#include "exec.h"
 #include "observable.h"
-#include "arch-utils.h"
-#include "gdbthread.h"
 #include "progspace.h"
-#include "gdb_bfd.h"
-#include "gcore.h"
-#include "source.h"
-
-#include <fcntl.h>
 #include "readline/readline.h"
-#include "gdbcore.h"
-
-#include <ctype.h>
-#include <sys/stat.h>
 #include "solist.h"
-#include <algorithm>
-#include "common/pathstuff.h"
+#include "source.h"
+#include "symfile.h"
+#include "target.h"
+#include "value.h"
 
 void (*deprecated_file_changed_hook) (const char *);
 
diff --git a/gdb/exec.h b/gdb/exec.h
index e9af4802872..3778a7e32f1 100644
--- a/gdb/exec.h
+++ b/gdb/exec.h
@@ -20,10 +20,10 @@
 #ifndef EXEC_H
 #define EXEC_H
 
-#include "target.h"
-#include "progspace.h"
 #include "memrange.h"
+#include "progspace.h"
 #include "symfile-add-flags.h"
+#include "target.h"
 
 struct target_section;
 struct target_ops;
diff --git a/gdb/expprint.c b/gdb/expprint.c
index a22499f4833..2b136e26c62 100644
--- a/gdb/expprint.c
+++ b/gdb/expprint.c
@@ -18,19 +18,22 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
+
+/* Standard C includes.  */
+#include <ctype.h>
+
+/* Local non-gdb includes.  */
+#include "block.h"
 #include "expression.h"
-#include "value.h"
+#include "gdbtypes.h"
 #include "language.h"
+#include "objfiles.h"
 #include "parser-defs.h"
-#include "user-regs.h"		/* For user_reg_map_regnum_to_name.  */
+#include "symtab.h"
 #include "target.h"
-#include "block.h"
-#include "objfiles.h"
+#include "user-regs.h"
 #include "valprint.h"
-
-#include <ctype.h>
+#include "value.h"
 
 void
 print_expression (struct expression *exp, struct ui_file *stream)
diff --git a/gdb/extension-priv.h b/gdb/extension-priv.h
index 97594f853a2..5b99c0fb8db 100644
--- a/gdb/extension-priv.h
+++ b/gdb/extension-priv.h
@@ -21,9 +21,11 @@
 #ifndef EXTENSION_PRIV_H
 #define EXTENSION_PRIV_H
 
-#include "extension.h"
 #include <signal.h>
+
+/* Local non-gdb includes.  */
 #include "cli/cli-script.h"
+#include "extension.h"
 
 /* High level description of an extension/scripting language.
    An entry for each is compiled into GDB regardless of whether the support
diff --git a/gdb/extension.c b/gdb/extension.c
index 8637bc53f2e..0e44140786e 100644
--- a/gdb/extension.c
+++ b/gdb/extension.c
@@ -21,17 +21,21 @@
    have "ext_lang" in the name, and no other symbol in gdb does.  */
 
 #include "defs.h"
+
+/* Standard C includes.  */
 #include <signal.h>
-#include "target.h"
+
+/* Local non-gdb includes.  */
 #include "auto-load.h"
 #include "breakpoint.h"
+#include "cli/cli-script.h"
 #include "event-top.h"
-#include "extension.h"
 #include "extension-priv.h"
+#include "extension.h"
+#include "guile/guile.h"
 #include "observable.h"
-#include "cli/cli-script.h"
 #include "python/python.h"
-#include "guile/guile.h"
+#include "target.h"
 
 /* Iterate over all external extension languages, regardless of whether the
    support has been compiled in or not.
diff --git a/gdb/extension.h b/gdb/extension.h
index 2f1b71851c6..a77f1575ede 100644
--- a/gdb/extension.h
+++ b/gdb/extension.h
@@ -20,9 +20,9 @@
 #ifndef EXTENSION_H
 #define EXTENSION_H
 
-#include "mi/mi-cmds.h" /* For PRINT_NO_VALUES, etc.  */
-#include "common/vec.h"
 #include "common/array-view.h"
+#include "common/vec.h"
+#include "mi/mi-cmds.h"
 
 struct breakpoint;
 struct command_line;
diff --git a/gdb/f-lang.c b/gdb/f-lang.c
index 7bd119690b4..5128caea815 100644
--- a/gdb/f-lang.c
+++ b/gdb/f-lang.c
@@ -21,22 +21,25 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
+
+/* Standard C includes.  */
+#include <math.h>
+
+/* Local non-gdb includes.  */
+#include "c-lang.h"
+#include "charset.h"
+#include "cp-support.h"
 #include "expression.h"
-#include "parser-defs.h"
-#include "language.h"
-#include "varobj.h"
-#include "gdbcore.h"
 #include "f-lang.h"
+#include "gdbcore.h"
+#include "gdbtypes.h"
+#include "language.h"
+#include "parser-defs.h"
+#include "symtab.h"
+#include "target-float.h"
 #include "valprint.h"
 #include "value.h"
-#include "cp-support.h"
-#include "charset.h"
-#include "c-lang.h"
-#include "target-float.h"
-
-#include <math.h>
+#include "varobj.h"
 
 /* Local functions */
 
diff --git a/gdb/f-typeprint.c b/gdb/f-typeprint.c
index a0e34b3058d..d3c83b0720f 100644
--- a/gdb/f-typeprint.c
+++ b/gdb/f-typeprint.c
@@ -21,16 +21,18 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdb_obstack.h"
+
+/* Local non-gdb includes.  */
 #include "bfd.h"
-#include "symtab.h"
-#include "gdbtypes.h"
 #include "expression.h"
-#include "value.h"
+#include "f-lang.h"
+#include "gdb_obstack.h"
 #include "gdbcore.h"
+#include "gdbtypes.h"
+#include "symtab.h"
 #include "target.h"
-#include "f-lang.h"
 #include "typeprint.h"
+#include "value.h"
 
 #if 0				/* Currently unused.  */
 static void f_type_print_args (struct type *, struct ui_file *);
diff --git a/gdb/f-valprint.c b/gdb/f-valprint.c
index 5f9dd4dedb8..0dea6ba407e 100644
--- a/gdb/f-valprint.c
+++ b/gdb/f-valprint.c
@@ -21,18 +21,20 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
+
+/* Local non-gdb includes.  */
+#include "block.h"
+#include "command.h"
+#include "dictionary.h"
 #include "expression.h"
-#include "value.h"
-#include "valprint.h"
-#include "language.h"
 #include "f-lang.h"
 #include "frame.h"
 #include "gdbcore.h"
-#include "command.h"
-#include "block.h"
-#include "dictionary.h"
+#include "gdbtypes.h"
+#include "language.h"
+#include "symtab.h"
+#include "valprint.h"
+#include "value.h"
 
 static void f77_get_dynamic_length_of_aggregate (struct type *);
 
diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index d4f4c8cf359..fe85847edce 100644
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -18,33 +18,37 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "common/byte-vector.h"
-#include "gdbcore.h"
-#include "inferior.h"
-#include "regcache.h"
-#include "regset.h"
-#include "gdbcmd.h"
-#include "gdbthread.h"
-#include "common/gdb_wait.h"
-#include "inf-ptrace.h"
-#include <sys/types.h>
+
+/* Standard C includes.  */
+#if defined(HAVE_KINFO_GETFILE) || defined(HAVE_KINFO_GETVMMAP)
+#include <libutil.h>
+#endif
 #include <sys/procfs.h>
 #include <sys/ptrace.h>
 #include <sys/signal.h>
 #include <sys/sysctl.h>
+#include <sys/types.h>
 #include <sys/user.h>
-#if defined(HAVE_KINFO_GETFILE) || defined(HAVE_KINFO_GETVMMAP)
-#include <libutil.h>
-#endif
+
+/* Standard C++ includes.  */
+#include <list>
+
+/* Local non-gdb includes.  */
+#include "common/byte-vector.h"
 #if !defined(HAVE_KINFO_GETVMMAP)
 #include "common/filestuff.h"
 #endif
-
+#include "common/gdb_wait.h"
 #include "elf-bfd.h"
 #include "fbsd-nat.h"
 #include "fbsd-tdep.h"
-
-#include <list>
+#include "gdbcmd.h"
+#include "gdbcore.h"
+#include "gdbthread.h"
+#include "inf-ptrace.h"
+#include "inferior.h"
+#include "regcache.h"
+#include "regset.h"
 
 /* Return the name of a file that can be opened to get the symbols for
    the child process identified by PID.  */
diff --git a/gdb/fbsd-nat.h b/gdb/fbsd-nat.h
index b0c9eb16c77..5dec9825393 100644
--- a/gdb/fbsd-nat.h
+++ b/gdb/fbsd-nat.h
@@ -20,9 +20,11 @@
 #ifndef FBSD_NAT_H
 #define FBSD_NAT_H
 
-#include "inf-ptrace.h"
 #include <sys/proc.h>
 
+/* Local non-gdb includes.  */
+#include "inf-ptrace.h"
+
 #ifdef TRAP_BRKPT
 /* MIPS does not set si_code for SIGTRAP.  sparc64 reports
    non-standard values in si_code for SIGTRAP.  */
diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c
index cd207d88bc3..73d62cffe01 100644
--- a/gdb/fbsd-tdep.c
+++ b/gdb/fbsd-tdep.c
@@ -18,19 +18,22 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Standard C includes.  */
+#include <arpa/inet.h>
+#include <sys/socket.h>
+
+/* Local non-gdb includes.  */
 #include "auxv.h"
+#include "elf-bfd.h"
+#include "fbsd-tdep.h"
 #include "gdbcore.h"
+#include "gdbthread.h"
 #include "inferior.h"
+#include "objfiles.h"
 #include "regcache.h"
 #include "regset.h"
-#include "gdbthread.h"
-#include "objfiles.h"
 #include "xml-syscall.h"
-#include <sys/socket.h>
-#include <arpa/inet.h>
-
-#include "elf-bfd.h"
-#include "fbsd-tdep.h"
 
 /* This enum is derived from FreeBSD's <sys/signal.h>.  */
 
diff --git a/gdb/filename-seen-cache.c b/gdb/filename-seen-cache.c
index a8ea0858ac8..65ac33c9fa6 100644
--- a/gdb/filename-seen-cache.c
+++ b/gdb/filename-seen-cache.c
@@ -18,6 +18,8 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "filename-seen-cache.h"
 #include "filenames.h"
 
diff --git a/gdb/filename-seen-cache.h b/gdb/filename-seen-cache.h
index 824245e77e6..5ed63047589 100644
--- a/gdb/filename-seen-cache.h
+++ b/gdb/filename-seen-cache.h
@@ -20,8 +20,8 @@
 #ifndef FILENAME_SEEN_CACHE_H
 #define FILENAME_SEEN_CACHE_H
 
-#include "defs.h"
 #include "common/function-view.h"
+#include "defs.h"
 
 /* Cache to watch for file names already seen.  */
 
diff --git a/gdb/filesystem.c b/gdb/filesystem.c
index fdc4713007a..e5eab1c1079 100644
--- a/gdb/filesystem.c
+++ b/gdb/filesystem.c
@@ -18,6 +18,8 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "filesystem.h"
 #include "gdbarch.h"
 #include "gdbcmd.h"
diff --git a/gdb/findcmd.c b/gdb/findcmd.c
index 52f8f80aaae..6d66730edee 100644
--- a/gdb/findcmd.c
+++ b/gdb/findcmd.c
@@ -18,14 +18,20 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "arch-utils.h"
+
+/* Standard C includes.  */
 #include <ctype.h>
-#include "gdbcmd.h"
-#include "value.h"
-#include "target.h"
-#include "cli/cli-utils.h"
+
+/* Standard C++ includes.  */
 #include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
+#include "cli/cli-utils.h"
 #include "common/byte-vector.h"
+#include "gdbcmd.h"
+#include "target.h"
+#include "value.h"
 
 /* Copied from bfd_put_bits.  */
 
diff --git a/gdb/findvar.c b/gdb/findvar.c
index e89ee37ffc7..0b97db57199 100644
--- a/gdb/findvar.c
+++ b/gdb/findvar.c
@@ -18,21 +18,23 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "symtab.h"
-#include "gdbtypes.h"
+
+/* Local non-gdb includes.  */
+#include "block.h"
+#include "common/selftest.h"
+#include "dwarf2loc.h"
 #include "frame.h"
-#include "value.h"
 #include "gdbcore.h"
+#include "gdbtypes.h"
 #include "inferior.h"
-#include "target.h"
-#include "symfile.h"		/* for overlay functions */
+#include "language.h"
+#include "objfiles.h"
 #include "regcache.h"
+#include "symfile.h"
+#include "symtab.h"
+#include "target.h"
 #include "user-regs.h"
-#include "block.h"
-#include "objfiles.h"
-#include "language.h"
-#include "dwarf2loc.h"
-#include "common/selftest.h"
+#include "value.h"
 
 /* Basic byte-swapping routines.  All 'extract' functions return a
    host-format integer from a target-format integer at ADDR which is
diff --git a/gdb/fork-child.c b/gdb/fork-child.c
index 4c49848830a..a4108231fc5 100644
--- a/gdb/fork-child.c
+++ b/gdb/fork-child.c
@@ -20,15 +20,17 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "inferior.h"
+
+/* Local non-gdb includes.  */
+#include "common/common-inferior.h"
+#include "common/filestuff.h"
+#include "common/job-control.h"
 #include "gdbcmd.h"
-#include "terminal.h"
 #include "gdbthread.h"
-#include "top.h"
-#include "common/job-control.h"
-#include "common/filestuff.h"
+#include "inferior.h"
 #include "nat/fork-inferior.h"
-#include "common/common-inferior.h"
+#include "terminal.h"
+#include "top.h"
 
 /* The exec-wrapper, if any, that will be used when starting the
    inferior.  */
diff --git a/gdb/frame-base.c b/gdb/frame-base.c
index 47897fc653d..8a580cd2084 100644
--- a/gdb/frame-base.c
+++ b/gdb/frame-base.c
@@ -18,6 +18,8 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
+
+/* Local non-gdb includes.  */
 #include "frame-base.h"
 #include "frame.h"
 #include "gdb_obstack.h"
diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c
index e5ddeba9077..46096c212b4 100644
--- a/gdb/frame-unwind.c
+++ b/gdb/frame-unwind.c
@@ -18,14 +18,16 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "frame.h"
-#include "frame-unwind.h"
+
+/* Local non-gdb includes.  */
 #include "dummy-frame.h"
+#include "frame-unwind.h"
+#include "frame.h"
+#include "gdb_obstack.h"
 #include "inline-frame.h"
-#include "value.h"
 #include "regcache.h"
-#include "gdb_obstack.h"
 #include "target.h"
+#include "value.h"
 
 static struct gdbarch_data *frame_unwind_data;
 
diff --git a/gdb/frame.c b/gdb/frame.c
index d8b5f819f1d..9b8f0bcc400 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -18,30 +18,32 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "frame.h"
-#include "target.h"
-#include "value.h"
-#include "inferior.h"	/* for inferior_ptid */
-#include "regcache.h"
-#include "user-regs.h"
-#include "gdb_obstack.h"
-#include "dummy-frame.h"
-#include "sentinel-frame.h"
-#include "gdbcore.h"
+
+/* Local non-gdb includes.  */
 #include "annotate.h"
-#include "language.h"
-#include "frame-unwind.h"
-#include "frame-base.h"
+#include "block.h"
 #include "command.h"
+#include "dummy-frame.h"
+#include "frame-base.h"
+#include "frame-unwind.h"
+#include "frame.h"
+#include "gdb_obstack.h"
 #include "gdbcmd.h"
-#include "observable.h"
-#include "objfiles.h"
+#include "gdbcore.h"
 #include "gdbthread.h"
-#include "block.h"
+#include "hashtab.h"
+#include "inferior.h"
 #include "inline-frame.h"
+#include "language.h"
+#include "objfiles.h"
+#include "observable.h"
+#include "regcache.h"
+#include "sentinel-frame.h"
+#include "target.h"
 #include "tracepoint.h"
-#include "hashtab.h"
+#include "user-regs.h"
 #include "valprint.h"
+#include "value.h"
 
 /* The sentinel frame terminates the innermost end of the frame chain.
    If unwound, it returns the information needed to construct an
diff --git a/gdb/frv-linux-tdep.c b/gdb/frv-linux-tdep.c
index e5261455fd9..b47d373421e 100644
--- a/gdb/frv-linux-tdep.c
+++ b/gdb/frv-linux-tdep.c
@@ -19,18 +19,20 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "gdbcore.h"
-#include "target.h"
-#include "frame.h"
-#include "osabi.h"
-#include "regcache.h"
+
+/* Local non-gdb includes.  */
 #include "elf-bfd.h"
 #include "elf/frv.h"
-#include "frv-tdep.h"
-#include "trad-frame.h"
 #include "frame-unwind.h"
-#include "regset.h"
+#include "frame.h"
+#include "frv-tdep.h"
+#include "gdbcore.h"
 #include "linux-tdep.h"
+#include "osabi.h"
+#include "regcache.h"
+#include "regset.h"
+#include "target.h"
+#include "trad-frame.h"
 
 /* Define the size (in bytes) of an FR-V instruction.  */
 static const int frv_instr_size = 4;
diff --git a/gdb/frv-tdep.c b/gdb/frv-tdep.c
index 804206bcb37..9c00f96c190 100644
--- a/gdb/frv-tdep.c
+++ b/gdb/frv-tdep.c
@@ -18,26 +18,28 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "inferior.h"
-#include "gdbcore.h"
+
+/* Local non-gdb includes.  */
+#include "../opcodes/frv-desc.h"
 #include "arch-utils.h"
-#include "regcache.h"
-#include "frame.h"
-#include "frame-unwind.h"
-#include "frame-base.h"
-#include "trad-frame.h"
 #include "dis-asm.h"
-#include "sim-regno.h"
-#include "gdb/sim-frv.h"
-#include "../opcodes/frv-desc.h"	/* for the H_SPR_... enums */
-#include "symtab.h"
 #include "elf-bfd.h"
 #include "elf/frv.h"
-#include "osabi.h"
-#include "infcall.h"
-#include "solib.h"
+#include "frame-base.h"
+#include "frame-unwind.h"
+#include "frame.h"
 #include "frv-tdep.h"
+#include "gdb/sim-frv.h"
+#include "gdbcore.h"
+#include "infcall.h"
+#include "inferior.h"
 #include "objfiles.h"
+#include "osabi.h"
+#include "regcache.h"
+#include "sim-regno.h"
+#include "solib.h"
+#include "symtab.h"
+#include "trad-frame.h"
 
 struct frv_unwind_cache		/* was struct frame_extra_info */
   {
diff --git a/gdb/ft32-tdep.c b/gdb/ft32-tdep.c
index bded02fae4b..404ec98484f 100644
--- a/gdb/ft32-tdep.c
+++ b/gdb/ft32-tdep.c
@@ -18,30 +18,32 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
 #include "defs.h"
-#include "frame.h"
-#include "frame-unwind.h"
+
+/* Standard C++ includes.  */
+#include <algorithm>
+
+/* Local non-gdb includes.  */
+#include "arch-utils.h"
+#include "dis-asm.h"
 #include "frame-base.h"
-#include "symtab.h"
-#include "gdbtypes.h"
+#include "frame-unwind.h"
+#include "frame.h"
+#include "ft32-tdep.h"
+#include "gdb/sim-ft32.h"
 #include "gdbcmd.h"
 #include "gdbcore.h"
-#include "value.h"
+#include "gdbtypes.h"
 #include "inferior.h"
-#include "symfile.h"
+#include "language.h"
 #include "objfiles.h"
+#include "opcode/ft32.h"
 #include "osabi.h"
-#include "language.h"
-#include "arch-utils.h"
+#include "record.h"
 #include "regcache.h"
+#include "symfile.h"
+#include "symtab.h"
 #include "trad-frame.h"
-#include "dis-asm.h"
-#include "record.h"
-
-#include "opcode/ft32.h"
-
-#include "ft32-tdep.h"
-#include "gdb/sim-ft32.h"
-#include <algorithm>
+#include "value.h"
 
 #define RAM_BIAS  0x800000  /* Bias added to RAM addresses.  */
 
-- 
2.17.2



More information about the Gdb-patches mailing list