[RFC] Sort #includes in gdb

Tom Tromey tom@tromey.com
Wed Apr 3 20:11:00 GMT 2019


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 03/29/2019 09:05 PM, Simon Marchi wrote:
>> 
>> I don't think I've mentioned it, but I really like this change.  I don't like the mental weight of having to choose where to add my include in an unorganized list :).

Pedro> Me too.  I'm waiting for this to land before touching the "namespace gdb"
Pedro> work again, since a not-insignificant part of that work revolves around
Pedro> moving "#include"s in the middle of files to the top of the file.

This patch doesn't touch those includes -- it only touches the ones at
the top of a file.  If you want to land yours first, it's no trouble for
me.  The change is just running a script.

On irc the other day, Simon had the idea that I could land the patch in
pieces: say, convert [a-f]*, test that, check it in.  I modified my
script to let me do this and the first batch went through.  So, if you'd
really rather this go first, let me know and I can do it that way.  It
may take a few days to get it all in.

Tom



More information about the Gdb-patches mailing list