[PATCH v2 16/22] Rewrite TRY/CATCH

[Pedro Alves]

On 02/27/2019 08:18 PM, Tom Tromey wrote:
> This rewrites gdb's TRY/CATCH to plain C++ try/catch.  The patch was
> largely written by script, though one change (to a comment in
> common-exceptions.h) was reverted by hand.

I reviewed this one and the next as a squashed view (any reason you
didn't squash them?), and it looks OK to me, though personally
I'd much prefer to see the explicit "struct" in:

 -  CATCH (e, RETURN_MASK_ERROR)
 +  catch (const struct gdb_exception_error &e)

go away, and end up with just:

   catch (const gdb_exception_error &e)

Thanks,
Pedro Alves