[PATCH v2 4/4] Add native target for FreeBSD/riscv.

Simon Marchi simon.marchi@ericsson.com
Thu Sep 27 20:04:00 GMT 2018


On 2018-09-24 04:51 PM, John Baldwin wrote:
> gdb/ChangeLog:
> 
> 	* Makefile.in (ALLDEPFILES): Add riscv-fbsd-nat.c.
> 	* NEWS: Mention new FreeBSD/riscv native configuration.
> 	* configure.host: Add riscv*-*-freebsd*.
> 	* configure.nat: Likewise.
> 	* riscv-fbsd-nat.c: New file.
> 
> gdb/doc/ChangeLog:
> 
> 	* gdb.texinfo (Contributors): Add SRI International and University
> 	of Cambridge for FreeBSD/riscv.
> ---
>  gdb/ChangeLog        |   8 +++
>  gdb/Makefile.in      |   1 +
>  gdb/NEWS             |   1 +
>  gdb/configure.host   |   1 +
>  gdb/configure.nat    |   4 ++
>  gdb/doc/ChangeLog    |   5 ++
>  gdb/doc/gdb.texinfo  |   6 ++
>  gdb/riscv-fbsd-nat.c | 135 +++++++++++++++++++++++++++++++++++++++++++
>  8 files changed, 161 insertions(+)
>  create mode 100644 gdb/riscv-fbsd-nat.c
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 1367f37db7..19c63706e9 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,11 @@
> +2018-09-24  John Baldwin  <jhb@FreeBSD.org>
> +
> +	* Makefile.in (ALLDEPFILES): Add riscv-fbsd-nat.c.
> +	* NEWS: Mention new FreeBSD/riscv native configuration.
> +	* configure.host: Add riscv*-*-freebsd*.
> +	* configure.nat: Likewise.
> +	* riscv-fbsd-nat.c: New file.
> +
>  2018-09-24  John Baldwin  <jhb@FreeBSD.org>
>  
>  	* Makefile.in (ALL_TARGET_OBS): Add riscv-fbsd-tdep.o.
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 2e03bb956c..13a8e16eec 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -2308,6 +2308,7 @@ ALLDEPFILES = \
>  	procfs.c \
>  	ravenscar-thread.c \
>  	remote-sim.c \
> +	riscv-fbsd-nat.c \
>  	riscv-fbsd-tdep.c \
>  	riscv-linux-nat.c \
>  	riscv-linux-tdep.c \
> diff --git a/gdb/NEWS b/gdb/NEWS
> index a191ae2714..4ae3adedc0 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -80,6 +80,7 @@ thread apply [all | COUNT | -COUNT] [FLAG]... COMMAND
>  * New native configurations
>  
>  GNU/Linux/RISC-V		riscv*-*-linux*
> +FreeBSD/riscv			riscv*-*-freebsd*

I just noticed that we write RISC-V in two different ways for GNU/Linux and
FreeBSD: RISC-V and riscv.  It's not a big deal, but it looks a bit inconsistent.

Otherwise everything looks good to me, but again I think the RISC-V ninjas should take a look.

Simon


More information about the Gdb-patches mailing list