[PATCH 2/4] Fall back to a default value of 0 for the MISA register.

Jim Wilson jimw@sifive.com
Thu Sep 20 20:57:00 GMT 2018


On Thu, Sep 20, 2018 at 1:31 PM John Baldwin <jhb@freebsd.org> wrote:
>     Use the existing instruction to determine the RISC-V breakpoint kind.

Yes, this looks like a nice solution to the problem.

In riscv_breakpoint_kind_from_pc, you are setting a byte_order local
variable but not obviously using it.  You presumably don't need byte
order here as you are only reading one byte.

Jim



More information about the Gdb-patches mailing list