[PATCH] Remove variable in get_startup_shell non-static

Tom Tromey tom@tromey.com
Fri Sep 14 12:46:00 GMT 2018


>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> IIRC this code was added by a patch of mine.  I think your patch makes
Sergio> sense.  Perhaps, since the SHELL can't change once you start GDB, this
Sergio> function could be made a bit smarter and check whether "ret" has been
Sergio> initialized or not (in order to call "getenv" just once), but really,
Sergio> that's not necessary at all, and your patch is totally fine.

Thanks, I'm going to check it in.

Tom



More information about the Gdb-patches mailing list