[PATCH] Allow a pretty-printer without a to_string method

Tom Tromey tom@tromey.com
Sun Sep 9 02:50:00 GMT 2018


>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

>> diff --git a/gdb/testsuite/gdb.python/py-prettyprint.exp b/gdb/testsuite/gdb.python/py-prettyprint.exp
>> index 2671cb8471b..fe7774fa886 100644
>> --- a/gdb/testsuite/gdb.python/py-prettyprint.exp
>> +++ b/gdb/testsuite/gdb.python/py-prettyprint.exp
>> @@ -127,6 +127,8 @@ proc run_lang_tests {exefile lang} {
>> gdb_test "print (int_type) an_int_type2" " = type=int_type, val=2"
>> gdb_test "print (int_type2) an_int_type2" " = type=int_type2, val=2"
>> 
>> +    gdb_test "print (int_type3) an_int_type2" " = {s = 27}"

Simon> Maybe just add a comment above this to indicate what this tests?  It's clear once
Simon> you go read the comment in the .py file, but it isn't here.

Simon> Otherwise, LGTM.

Thanks, I'm checking it in with that fixed.

Tom



More information about the Gdb-patches mailing list