[PATCH v2] Logical short circuiting with argument lists
Simon Marchi
simon.marchi@ericsson.com
Sat Sep 8 21:25:00 GMT 2018
On 2018-09-07 11:23 PM, Tom Tromey wrote:
>>>>>> "Richard" == Richard Bunt <richard.bunt@arm.com> writes:
>
> Thank you for the patch.
>
> Richard> koenig.exp was updated to include a testcase which exercises the
> Richard> modified skip logic in OP_VAR_VALUE, as it falls through from
> Richard> OP_ADL_FUNC.
>
> Nice, thanks.
>
> Richard> +void
> Richard> +skip_undetermined_arglist (int nargs, struct expression *exp, int *pos,
> Richard> + enum noside noside)
>
> This needs an introductory comment.
Also, you can get rid of the forward-declaration of skip_undetermined_arglist,
and the definition should be made static.
Simon
More information about the Gdb-patches
mailing list