[PATCH v2 PR gdb/16841] virtual inheritance via typedef cannot find base
Simon Marchi
simon.marchi@polymtl.ca
Sat Sep 8 08:51:00 GMT 2018
On 2018-09-08 01:12, Weimin Pan wrote:
>> Your patch still has trailing whitespaces. Try to do:
>>
>> $ git format-patch HEAD^
>> $ git am 0001-virtual-inheritance-via-typedef-cannot-find-base.patch
>>
>> and make sure you have no message other than
>>
>> Applying: virtual inheritance via typedef cannot find base
>
> It's nice to know this "git am" command. Do I use the "git am --abort"
> command to
> restore my original patch, correct problems, then use another "git am"
> command?
You shouldn't need to use --abort in this case... In my instructions, I
forgot to mention to remove your commit before applying it again (it's
expected that applying the same patch twice doesn't work). So it should
be:
$ git format-patch HEAD^
$ git reset --hard HEAD^
$ git am 0001-virtual-inheritance-via-typedef-cannot-find-base.patch
Modifications to the patch can be done by using "git commit --amend", as
usual.
Thanks!
Simon
More information about the Gdb-patches
mailing list