[PATCH v2 1/6] Unify shell-finding logic
Tom Tromey
tom@tromey.com
Sat Oct 27 17:41:00 GMT 2018
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> Not sure if I reviewed this one before, but it LGTM (with a very small
Sergio> nit below). It also can be pushed independently, IMO.
>> +/* Return the file name of the user's shell. */
Sergio> WDYT about explicitly mentioning here that "user's shell" means "the
Sergio> SHELL environment variable"?
I added some text here.
Tom
More information about the Gdb-patches
mailing list